From mboxrd@z Thu Jan 1 00:00:00 1970 From: kernel test robot Date: Sat, 21 May 2022 09:57:42 +0800 Subject: [PATCH v4 1/3] usb: gadget: add Aspeed ast2600 udc driver In-Reply-To: <20220520090617.2225080-2-neal_liu@aspeedtech.com> References: <20220520090617.2225080-2-neal_liu@aspeedtech.com> Message-ID: <202205210945.hUK3CONa-lkp@intel.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Neal, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on robh/for-next v5.18-rc7 next-20220520] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Neal-Liu/add-Aspeed-udc-driver-for-ast2600/20220520-170904 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20220521/202205210945.hUK3CONa-lkp at intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project e00cbbec06c08dc616a0d52a20f678b8fbd4e304) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/19f3e863ea1b55f570db57febb96c6e8cb39c145 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Neal-Liu/add-Aspeed-udc-driver-for-ast2600/20220520-170904 git checkout 19f3e863ea1b55f570db57febb96c6e8cb39c145 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/clk/ drivers/usb/gadget/udc/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/usb/gadget/udc/aspeed_udc.c:310:11: warning: comparison of address of 'ep->queue' equal to a null pointer is always false [-Wtautological-pointer-compare] if (&ep->queue == NULL) ~~~~^~~~~ ~~~~ >> drivers/usb/gadget/udc/aspeed_udc.c:967:7: warning: variable 'len' is uninitialized when used here [-Wuninitialized] if (len < ep->ep.maxpacket) { ^~~ drivers/usb/gadget/udc/aspeed_udc.c:908:9: note: initialize the variable 'len' to silence this warning u16 len; ^ = 0 >> drivers/usb/gadget/udc/aspeed_udc.c:1011:7: warning: variable 'epnum' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] case USB_RECIP_INTERFACE: ^~~~~~~~~~~~~~~~~~~ include/uapi/linux/usb/ch9.h:67:30: note: expanded from macro 'USB_RECIP_INTERFACE' #define USB_RECIP_INTERFACE 0x01 ^~~~ drivers/usb/gadget/udc/aspeed_udc.c:1021:16: note: uninitialized use occurs here ep = &udc->ep[epnum]; ^~~~~ drivers/usb/gadget/udc/aspeed_udc.c:1007:7: warning: variable 'epnum' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] case USB_RECIP_DEVICE: ^~~~~~~~~~~~~~~~ include/uapi/linux/usb/ch9.h:66:27: note: expanded from macro 'USB_RECIP_DEVICE' #define USB_RECIP_DEVICE 0x00 ^~~~ drivers/usb/gadget/udc/aspeed_udc.c:1021:16: note: uninitialized use occurs here ep = &udc->ep[epnum]; ^~~~~ drivers/usb/gadget/udc/aspeed_udc.c:1002:11: note: initialize the variable 'epnum' to silence this warning u16 epnum; ^ = 0 >> drivers/usb/gadget/udc/aspeed_udc.c:1096:6: warning: variable 'rc' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (udc->driver) { ^~~~~~~~~~~ drivers/usb/gadget/udc/aspeed_udc.c:1108:6: note: uninitialized use occurs here if (rc >= 0) ^~ drivers/usb/gadget/udc/aspeed_udc.c:1096:2: note: remove the 'if' if its condition is always true if (udc->driver) { ^~~~~~~~~~~~~~~~~ drivers/usb/gadget/udc/aspeed_udc.c:1039:8: note: initialize the variable 'rc' to silence this warning int rc; ^ = 0 5 warnings generated. vim +310 drivers/usb/gadget/udc/aspeed_udc.c 304 305 static void ast_udc_nuke(struct ast_udc_ep *ep, int status) 306 { 307 int count = 0; 308 309 /* Sanity check */ > 310 if (&ep->queue == NULL) 311 return; 312 313 while (!list_empty(&ep->queue)) { 314 struct ast_udc_request *req; 315 316 req = list_entry(ep->queue.next, struct ast_udc_request, 317 queue); 318 ast_udc_done(ep, req, status); 319 count++; 320 } 321 322 if (count) 323 EP_DBG(ep, "Nuked %d request(s)\n", count); 324 } 325 -- 0-DAY CI Kernel Test Service https://01.org/lkp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3653AC433F5 for ; Sat, 21 May 2022 01:58:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354316AbiEUB6f (ORCPT ); Fri, 20 May 2022 21:58:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239135AbiEUB6b (ORCPT ); Fri, 20 May 2022 21:58:31 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AFCF15F6C0; Fri, 20 May 2022 18:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653098310; x=1684634310; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=DrWDg9joVp2dABARq0RhykWRXTcxvZJXfd8ePCmsTW0=; b=KlwufDRPyR7kImVQBqWLXX6PFnzV/3OPbDzM7YP88cfOvxiRxAjRopsg KTE6v0XCQyQ4PTMfEHvI3SBPT/zRMph/0pGmzYTLsQk427ivkBT8+ukKv F8rvsn/vrF9Qhx1zdGS51u6WzV98i9di3OQNLXdtikvpqjFNl1aSVJpGP 7xp3czWnGcq+aAvQ15eHh/IqgzuPs2jBjC/CpLnL/olxqd6qWm3y1Lv2R NgRVGeJrEc9u21PyCCKbKkQEphQlbOqU92JYRsXgPOo2uv9unax8g1q/A S7tdoWs/0Jfg8hbTT/ePeyRT2Cv5OgcXKAXNlIJXHsRRIfvQb6TZx2HLg A==; X-IronPort-AV: E=McAfee;i="6400,9594,10353"; a="298102845" X-IronPort-AV: E=Sophos;i="5.91,240,1647327600"; d="scan'208";a="298102845" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2022 18:58:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,240,1647327600"; d="scan'208";a="546969294" Received: from lkp-server02.sh.intel.com (HELO 242b25809ac7) ([10.239.97.151]) by orsmga006.jf.intel.com with ESMTP; 20 May 2022 18:58:23 -0700 Received: from kbuild by 242b25809ac7 with local (Exim 4.95) (envelope-from ) id 1nsENq-0005lm-Q8; Sat, 21 May 2022 01:58:22 +0000 Date: Sat, 21 May 2022 09:57:42 +0800 From: kernel test robot To: Neal Liu , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Felipe Balbi , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , Geert Uytterhoeven , Li Yang Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Neal Liu , linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH v4 1/3] usb: gadget: add Aspeed ast2600 udc driver Message-ID: <202205210945.hUK3CONa-lkp@intel.com> References: <20220520090617.2225080-2-neal_liu@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220520090617.2225080-2-neal_liu@aspeedtech.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi Neal, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on robh/for-next v5.18-rc7 next-20220520] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Neal-Liu/add-Aspeed-udc-driver-for-ast2600/20220520-170904 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20220521/202205210945.hUK3CONa-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project e00cbbec06c08dc616a0d52a20f678b8fbd4e304) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/19f3e863ea1b55f570db57febb96c6e8cb39c145 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Neal-Liu/add-Aspeed-udc-driver-for-ast2600/20220520-170904 git checkout 19f3e863ea1b55f570db57febb96c6e8cb39c145 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/clk/ drivers/usb/gadget/udc/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/usb/gadget/udc/aspeed_udc.c:310:11: warning: comparison of address of 'ep->queue' equal to a null pointer is always false [-Wtautological-pointer-compare] if (&ep->queue == NULL) ~~~~^~~~~ ~~~~ >> drivers/usb/gadget/udc/aspeed_udc.c:967:7: warning: variable 'len' is uninitialized when used here [-Wuninitialized] if (len < ep->ep.maxpacket) { ^~~ drivers/usb/gadget/udc/aspeed_udc.c:908:9: note: initialize the variable 'len' to silence this warning u16 len; ^ = 0 >> drivers/usb/gadget/udc/aspeed_udc.c:1011:7: warning: variable 'epnum' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] case USB_RECIP_INTERFACE: ^~~~~~~~~~~~~~~~~~~ include/uapi/linux/usb/ch9.h:67:30: note: expanded from macro 'USB_RECIP_INTERFACE' #define USB_RECIP_INTERFACE 0x01 ^~~~ drivers/usb/gadget/udc/aspeed_udc.c:1021:16: note: uninitialized use occurs here ep = &udc->ep[epnum]; ^~~~~ drivers/usb/gadget/udc/aspeed_udc.c:1007:7: warning: variable 'epnum' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] case USB_RECIP_DEVICE: ^~~~~~~~~~~~~~~~ include/uapi/linux/usb/ch9.h:66:27: note: expanded from macro 'USB_RECIP_DEVICE' #define USB_RECIP_DEVICE 0x00 ^~~~ drivers/usb/gadget/udc/aspeed_udc.c:1021:16: note: uninitialized use occurs here ep = &udc->ep[epnum]; ^~~~~ drivers/usb/gadget/udc/aspeed_udc.c:1002:11: note: initialize the variable 'epnum' to silence this warning u16 epnum; ^ = 0 >> drivers/usb/gadget/udc/aspeed_udc.c:1096:6: warning: variable 'rc' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (udc->driver) { ^~~~~~~~~~~ drivers/usb/gadget/udc/aspeed_udc.c:1108:6: note: uninitialized use occurs here if (rc >= 0) ^~ drivers/usb/gadget/udc/aspeed_udc.c:1096:2: note: remove the 'if' if its condition is always true if (udc->driver) { ^~~~~~~~~~~~~~~~~ drivers/usb/gadget/udc/aspeed_udc.c:1039:8: note: initialize the variable 'rc' to silence this warning int rc; ^ = 0 5 warnings generated. vim +310 drivers/usb/gadget/udc/aspeed_udc.c 304 305 static void ast_udc_nuke(struct ast_udc_ep *ep, int status) 306 { 307 int count = 0; 308 309 /* Sanity check */ > 310 if (&ep->queue == NULL) 311 return; 312 313 while (!list_empty(&ep->queue)) { 314 struct ast_udc_request *req; 315 316 req = list_entry(ep->queue.next, struct ast_udc_request, 317 queue); 318 ast_udc_done(ep, req, status); 319 count++; 320 } 321 322 if (count) 323 EP_DBG(ep, "Nuked %d request(s)\n", count); 324 } 325 -- 0-DAY CI Kernel Test Service https://01.org/lkp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AA02C433FE for ; Sat, 21 May 2022 02:00:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WZ5KvoAszPdkfDx1aoNijgjlshalowdkDC0/bbvpfwU=; b=1bPkWJy8DyrIz7 LfRqAOcbR3NMIdspS7N6zZVkR/vaCvlfMVug5bDDbPvtzcmhlJzunrJ/9KMQJOgusqvEIDq5QljAD UXWo+x6ifzJaY5lR3qA9qYrHeNLkihapkcgjVS06HMz0UYbh/f106Y3FOKMnAkHu7RjlAbx36dlxK 96QSPPGRQj0ExqT0z45PFsxnbitJyt2RgjgSO8onSjs5hjf2tuTO0tRW5CPDhvlF/BFUdvajQjF0I Gf7/+r453uJoldKtPLMDusVPK9WrXADqwgoLufNq62KnXZaNmW0v6oWNQmPmf57MKkKzV8iX6QxFu arZNNgwUvZhsnXHCjNwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsEO5-00FBaY-JB; Sat, 21 May 2022 01:58:37 +0000 Received: from mga01.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsEO1-00FBZa-7S for linux-arm-kernel@lists.infradead.org; Sat, 21 May 2022 01:58:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653098313; x=1684634313; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=DrWDg9joVp2dABARq0RhykWRXTcxvZJXfd8ePCmsTW0=; b=VHzNa1K+GPrzTzLZWZ5PBU74AU/lFyyQSjyqcS0r/6rYbsQDycqV3SVh ujjJNWvmjJWnMCyzdnvwvdD6nn2OPuIqB8TS8nzIrEjG6PwVQUmJa5Rq3 og3ZEBtAtM3kyn3+p0Slz53YKVX5nhOkCsbITY/nTp47waLENRFU8ATgk XdpcfK3FfwxRz5hZ+aifBBmduHKz6DAIO4LuU+z4UTsrBpaicMc/NuTBs YC0KsXeWoD4KTRKRhQ8YdeyY9XmHbaqwca+wVUy6ocXfqcP+Ngu6aCVVf EbHXUVX0gmrT0T9P2iWPp2IrJXogfNbF7NlFFGVVOS/PQuadkWBBiqnv4 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10353"; a="298102842" X-IronPort-AV: E=Sophos;i="5.91,240,1647327600"; d="scan'208";a="298102842" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2022 18:58:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,240,1647327600"; d="scan'208";a="546969294" Received: from lkp-server02.sh.intel.com (HELO 242b25809ac7) ([10.239.97.151]) by orsmga006.jf.intel.com with ESMTP; 20 May 2022 18:58:23 -0700 Received: from kbuild by 242b25809ac7 with local (Exim 4.95) (envelope-from ) id 1nsENq-0005lm-Q8; Sat, 21 May 2022 01:58:22 +0000 Date: Sat, 21 May 2022 09:57:42 +0800 From: kernel test robot To: Neal Liu , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Felipe Balbi , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , Geert Uytterhoeven , Li Yang Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Neal Liu , linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH v4 1/3] usb: gadget: add Aspeed ast2600 udc driver Message-ID: <202205210945.hUK3CONa-lkp@intel.com> References: <20220520090617.2225080-2-neal_liu@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220520090617.2225080-2-neal_liu@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220520_185834_322485_B24A7CB9 X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Neal, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on robh/for-next v5.18-rc7 next-20220520] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Neal-Liu/add-Aspeed-udc-driver-for-ast2600/20220520-170904 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20220521/202205210945.hUK3CONa-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project e00cbbec06c08dc616a0d52a20f678b8fbd4e304) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/19f3e863ea1b55f570db57febb96c6e8cb39c145 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Neal-Liu/add-Aspeed-udc-driver-for-ast2600/20220520-170904 git checkout 19f3e863ea1b55f570db57febb96c6e8cb39c145 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/clk/ drivers/usb/gadget/udc/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/usb/gadget/udc/aspeed_udc.c:310:11: warning: comparison of address of 'ep->queue' equal to a null pointer is always false [-Wtautological-pointer-compare] if (&ep->queue == NULL) ~~~~^~~~~ ~~~~ >> drivers/usb/gadget/udc/aspeed_udc.c:967:7: warning: variable 'len' is uninitialized when used here [-Wuninitialized] if (len < ep->ep.maxpacket) { ^~~ drivers/usb/gadget/udc/aspeed_udc.c:908:9: note: initialize the variable 'len' to silence this warning u16 len; ^ = 0 >> drivers/usb/gadget/udc/aspeed_udc.c:1011:7: warning: variable 'epnum' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] case USB_RECIP_INTERFACE: ^~~~~~~~~~~~~~~~~~~ include/uapi/linux/usb/ch9.h:67:30: note: expanded from macro 'USB_RECIP_INTERFACE' #define USB_RECIP_INTERFACE 0x01 ^~~~ drivers/usb/gadget/udc/aspeed_udc.c:1021:16: note: uninitialized use occurs here ep = &udc->ep[epnum]; ^~~~~ drivers/usb/gadget/udc/aspeed_udc.c:1007:7: warning: variable 'epnum' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] case USB_RECIP_DEVICE: ^~~~~~~~~~~~~~~~ include/uapi/linux/usb/ch9.h:66:27: note: expanded from macro 'USB_RECIP_DEVICE' #define USB_RECIP_DEVICE 0x00 ^~~~ drivers/usb/gadget/udc/aspeed_udc.c:1021:16: note: uninitialized use occurs here ep = &udc->ep[epnum]; ^~~~~ drivers/usb/gadget/udc/aspeed_udc.c:1002:11: note: initialize the variable 'epnum' to silence this warning u16 epnum; ^ = 0 >> drivers/usb/gadget/udc/aspeed_udc.c:1096:6: warning: variable 'rc' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (udc->driver) { ^~~~~~~~~~~ drivers/usb/gadget/udc/aspeed_udc.c:1108:6: note: uninitialized use occurs here if (rc >= 0) ^~ drivers/usb/gadget/udc/aspeed_udc.c:1096:2: note: remove the 'if' if its condition is always true if (udc->driver) { ^~~~~~~~~~~~~~~~~ drivers/usb/gadget/udc/aspeed_udc.c:1039:8: note: initialize the variable 'rc' to silence this warning int rc; ^ = 0 5 warnings generated. vim +310 drivers/usb/gadget/udc/aspeed_udc.c 304 305 static void ast_udc_nuke(struct ast_udc_ep *ep, int status) 306 { 307 int count = 0; 308 309 /* Sanity check */ > 310 if (&ep->queue == NULL) 311 return; 312 313 while (!list_empty(&ep->queue)) { 314 struct ast_udc_request *req; 315 316 req = list_entry(ep->queue.next, struct ast_udc_request, 317 queue); 318 ast_udc_done(ep, req, status); 319 count++; 320 } 321 322 if (count) 323 EP_DBG(ep, "Nuked %d request(s)\n", count); 324 } 325 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07875C433EF for ; Sat, 21 May 2022 01:58:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 529C610E127; Sat, 21 May 2022 01:58:30 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 531FD10E127 for ; Sat, 21 May 2022 01:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653098309; x=1684634309; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=DrWDg9joVp2dABARq0RhykWRXTcxvZJXfd8ePCmsTW0=; b=AbRDIbsP/ZFjQyR1HZiP5O6wSAsvD4fA1ATy58GfuARHa6gOEorHM47V 1F8CZOSegp8ymwdhhQEFl7QTdIKlc7ADwAWmvp2FW/TxNSw9Wlob8M409 Xb9TBAalPGO9gjkxVFTP734PuDwuzLEU9l2KggDWWmsoYOtvWsY7Kd1sy VLT3qolI7DLq0EcgJPN72g7SfbRkqSCn2ynMerS9RPM7a2jB5pFQyguxc z8OLeoUt8qWdmqxuK0crxC23xS7erRp5BZD5QjGSZ9uLx1dgArwQ4+9ok yo/I8C056AtiqA+Uvo+da5z8rgjtNcAO+mDQzuPRxUxdYh9ZaEgNHT6Ah A==; X-IronPort-AV: E=McAfee;i="6400,9594,10353"; a="298102843" X-IronPort-AV: E=Sophos;i="5.91,240,1647327600"; d="scan'208";a="298102843" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2022 18:58:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,240,1647327600"; d="scan'208";a="546969294" Received: from lkp-server02.sh.intel.com (HELO 242b25809ac7) ([10.239.97.151]) by orsmga006.jf.intel.com with ESMTP; 20 May 2022 18:58:23 -0700 Received: from kbuild by 242b25809ac7 with local (Exim 4.95) (envelope-from ) id 1nsENq-0005lm-Q8; Sat, 21 May 2022 01:58:22 +0000 Date: Sat, 21 May 2022 09:57:42 +0800 From: kernel test robot To: Neal Liu , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Felipe Balbi , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , Geert Uytterhoeven , Li Yang Subject: Re: [PATCH v4 1/3] usb: gadget: add Aspeed ast2600 udc driver Message-ID: <202205210945.hUK3CONa-lkp@intel.com> References: <20220520090617.2225080-2-neal_liu@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220520090617.2225080-2-neal_liu@aspeedtech.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-usb@vger.kernel.org, kbuild-all@lists.01.org, linux-aspeed@lists.ozlabs.org, Neal Liu , llvm@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Neal, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on robh/for-next v5.18-rc7 next-20220520] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Neal-Liu/add-Aspeed-udc-driver-for-ast2600/20220520-170904 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20220521/202205210945.hUK3CONa-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project e00cbbec06c08dc616a0d52a20f678b8fbd4e304) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/19f3e863ea1b55f570db57febb96c6e8cb39c145 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Neal-Liu/add-Aspeed-udc-driver-for-ast2600/20220520-170904 git checkout 19f3e863ea1b55f570db57febb96c6e8cb39c145 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/clk/ drivers/usb/gadget/udc/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/usb/gadget/udc/aspeed_udc.c:310:11: warning: comparison of address of 'ep->queue' equal to a null pointer is always false [-Wtautological-pointer-compare] if (&ep->queue == NULL) ~~~~^~~~~ ~~~~ >> drivers/usb/gadget/udc/aspeed_udc.c:967:7: warning: variable 'len' is uninitialized when used here [-Wuninitialized] if (len < ep->ep.maxpacket) { ^~~ drivers/usb/gadget/udc/aspeed_udc.c:908:9: note: initialize the variable 'len' to silence this warning u16 len; ^ = 0 >> drivers/usb/gadget/udc/aspeed_udc.c:1011:7: warning: variable 'epnum' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] case USB_RECIP_INTERFACE: ^~~~~~~~~~~~~~~~~~~ include/uapi/linux/usb/ch9.h:67:30: note: expanded from macro 'USB_RECIP_INTERFACE' #define USB_RECIP_INTERFACE 0x01 ^~~~ drivers/usb/gadget/udc/aspeed_udc.c:1021:16: note: uninitialized use occurs here ep = &udc->ep[epnum]; ^~~~~ drivers/usb/gadget/udc/aspeed_udc.c:1007:7: warning: variable 'epnum' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] case USB_RECIP_DEVICE: ^~~~~~~~~~~~~~~~ include/uapi/linux/usb/ch9.h:66:27: note: expanded from macro 'USB_RECIP_DEVICE' #define USB_RECIP_DEVICE 0x00 ^~~~ drivers/usb/gadget/udc/aspeed_udc.c:1021:16: note: uninitialized use occurs here ep = &udc->ep[epnum]; ^~~~~ drivers/usb/gadget/udc/aspeed_udc.c:1002:11: note: initialize the variable 'epnum' to silence this warning u16 epnum; ^ = 0 >> drivers/usb/gadget/udc/aspeed_udc.c:1096:6: warning: variable 'rc' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (udc->driver) { ^~~~~~~~~~~ drivers/usb/gadget/udc/aspeed_udc.c:1108:6: note: uninitialized use occurs here if (rc >= 0) ^~ drivers/usb/gadget/udc/aspeed_udc.c:1096:2: note: remove the 'if' if its condition is always true if (udc->driver) { ^~~~~~~~~~~~~~~~~ drivers/usb/gadget/udc/aspeed_udc.c:1039:8: note: initialize the variable 'rc' to silence this warning int rc; ^ = 0 5 warnings generated. vim +310 drivers/usb/gadget/udc/aspeed_udc.c 304 305 static void ast_udc_nuke(struct ast_udc_ep *ep, int status) 306 { 307 int count = 0; 308 309 /* Sanity check */ > 310 if (&ep->queue == NULL) 311 return; 312 313 while (!list_empty(&ep->queue)) { 314 struct ast_udc_request *req; 315 316 req = list_entry(ep->queue.next, struct ast_udc_request, 317 queue); 318 ast_udc_done(ep, req, status); 319 count++; 320 } 321 322 if (count) 323 EP_DBG(ep, "Nuked %d request(s)\n", count); 324 } 325 -- 0-DAY CI Kernel Test Service https://01.org/lkp