From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [rafael-pm:bleeding-edge 191/248] kernel/reboot.c:517:43: warning: Parameter 'power_off' can be declared with const [constParameter]
Date: Sun, 22 May 2022 20:40:22 +0800 [thread overview]
Message-ID: <202205222015.sb44KHH8-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2654 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-acpi(a)vger.kernel.org
CC: devel(a)acpica.org
CC: linux-pm(a)vger.kernel.org
TO: Dmitry Osipenko <dmitry.osipenko@collabora.com>
CC: "Rafael J. Wysocki" <rjw@rjwysocki.net>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
head: 3d22e39d225d7adb6c670065f4ae016e759171ed
commit: fb61375ecfba49e153af561402f49f6fe3bebd39 [191/248] kernel/reboot: Add register_platform_power_off()
:::::: branch date: 20 hours ago
:::::: commit date: 3 days ago
compiler: m68k-linux-gcc (GCC) 11.3.0
reproduce (cppcheck warning):
# apt-get install cppcheck
git checkout fb61375ecfba49e153af561402f49f6fe3bebd39
cppcheck --quiet --enable=style,performance,portability --template=gcc FILE
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> kernel/reboot.c:517:43: warning: Parameter 'power_off' can be declared with const [constParameter]
void unregister_platform_power_off(void (*power_off)(void))
^
vim +/power_off +517 kernel/reboot.c
fb61375ecfba49 Dmitry Osipenko 2022-05-10 510
fb61375ecfba49 Dmitry Osipenko 2022-05-10 511 /**
fb61375ecfba49 Dmitry Osipenko 2022-05-10 512 * unregister_platform_power_off - Unregister platform-level power-off callback
fb61375ecfba49 Dmitry Osipenko 2022-05-10 513 * @power_off: Power-off callback
fb61375ecfba49 Dmitry Osipenko 2022-05-10 514 *
fb61375ecfba49 Dmitry Osipenko 2022-05-10 515 * Unregisters previously registered platform power-off callback.
fb61375ecfba49 Dmitry Osipenko 2022-05-10 516 */
fb61375ecfba49 Dmitry Osipenko 2022-05-10 @517 void unregister_platform_power_off(void (*power_off)(void))
fb61375ecfba49 Dmitry Osipenko 2022-05-10 518 {
fb61375ecfba49 Dmitry Osipenko 2022-05-10 519 if (platform_power_off_handler &&
fb61375ecfba49 Dmitry Osipenko 2022-05-10 520 platform_power_off_handler->cb_data == power_off) {
fb61375ecfba49 Dmitry Osipenko 2022-05-10 521 unregister_sys_off_handler(platform_power_off_handler);
fb61375ecfba49 Dmitry Osipenko 2022-05-10 522 platform_power_off_handler = NULL;
fb61375ecfba49 Dmitry Osipenko 2022-05-10 523 }
fb61375ecfba49 Dmitry Osipenko 2022-05-10 524 }
fb61375ecfba49 Dmitry Osipenko 2022-05-10 525 EXPORT_SYMBOL_GPL(unregister_platform_power_off);
fb61375ecfba49 Dmitry Osipenko 2022-05-10 526
--
0-DAY CI Kernel Test Service
https://01.org/lkp
reply other threads:[~2022-05-22 12:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202205222015.sb44KHH8-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.