From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Dmitry Vyukov <dvyukov@google.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next 03/19] net: add dev_hold_track() and dev_put_track() helpers
Date: Mon, 23 May 2022 11:03:15 -0700 [thread overview]
Message-ID: <20220523110315.6f0637ed@kernel.org> (raw)
In-Reply-To: <20211202032139.3156411-4-eric.dumazet@gmail.com>
On Wed, 1 Dec 2021 19:21:23 -0800 Eric Dumazet wrote:
> +static inline void dev_hold_track(struct net_device *dev,
> + netdevice_tracker *tracker, gfp_t gfp)
> +{
> + if (dev) {
> + dev_hold(dev);
> +#ifdef CONFIG_NET_DEV_REFCNT_TRACKER
> + ref_tracker_alloc(&dev->refcnt_tracker, tracker, gfp);
> +#endif
> + }
> +}
> +
> +static inline void dev_put_track(struct net_device *dev,
> + netdevice_tracker *tracker)
> +{
> + if (dev) {
> +#ifdef CONFIG_NET_DEV_REFCNT_TRACKER
> + ref_tracker_free(&dev->refcnt_tracker, tracker);
> +#endif
> + dev_put(dev);
> + }
> +}
Hi Eric, how bad would it be if we renamed dev_hold/put_track() to
netdev_hold/put()? IIUC we use the dev_ prefix for "historic reasons"
could this be an opportunity to stop doing that?
next prev parent reply other threads:[~2022-05-23 18:29 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 3:21 [PATCH net-next 00/19] net: add preliminary netdev refcount tracking Eric Dumazet
2021-12-02 3:21 ` [PATCH net-next 01/19] lib: add reference counting tracking infrastructure Eric Dumazet
2021-12-02 8:12 ` Dmitry Vyukov
2021-12-02 16:05 ` Eric Dumazet
2021-12-02 3:21 ` [PATCH net-next 02/19] lib: add tests for reference tracker Eric Dumazet
2021-12-02 3:31 ` Eric Dumazet
2021-12-02 9:03 ` kernel test robot
2021-12-02 9:03 ` kernel test robot
2021-12-02 19:25 ` kernel test robot
2021-12-02 19:25 ` kernel test robot
2021-12-02 19:46 ` Eric Dumazet
2021-12-02 19:46 ` Eric Dumazet
2021-12-03 7:37 ` Dmitry Vyukov
2021-12-03 7:37 ` Dmitry Vyukov
2021-12-02 3:21 ` [PATCH net-next 03/19] net: add dev_hold_track() and dev_put_track() helpers Eric Dumazet
2022-05-23 18:03 ` Jakub Kicinski [this message]
2022-05-23 18:14 ` Eric Dumazet
2022-05-23 18:26 ` Jakub Kicinski
2021-12-02 3:21 ` [PATCH net-next 04/19] net: add net device refcount tracker to struct netdev_rx_queue Eric Dumazet
2021-12-02 3:21 ` [PATCH net-next 05/19] net: add net device refcount tracker to struct netdev_queue Eric Dumazet
2021-12-02 3:21 ` [PATCH net-next 06/19] net: add net device refcount tracker to ethtool_phys_id() Eric Dumazet
2021-12-02 3:21 ` [PATCH net-next 07/19] net: add net device refcount tracker to dev_ifsioc() Eric Dumazet
2021-12-02 3:21 ` [PATCH net-next 08/19] drop_monitor: add net device refcount tracker Eric Dumazet
2021-12-02 5:40 ` kernel test robot
2021-12-02 5:40 ` kernel test robot
2021-12-02 5:57 ` Eric Dumazet
2021-12-02 5:57 ` Eric Dumazet
2021-12-02 3:21 ` [PATCH net-next 09/19] net: dst: add net device refcount tracking to dst_entry Eric Dumazet
2021-12-02 3:21 ` [PATCH net-next 10/19] ipv6: add net device refcount tracker to rt6_probe_deferred() Eric Dumazet
2021-12-02 3:21 ` [PATCH net-next 11/19] sit: add net device refcount tracking to ip_tunnel Eric Dumazet
2021-12-02 3:21 ` [PATCH net-next 12/19] ipv6: add net device refcount tracker to struct ip6_tnl Eric Dumazet
2021-12-02 3:21 ` [PATCH net-next 13/19] net: add net device refcount tracker to struct neighbour Eric Dumazet
2021-12-02 3:21 ` [PATCH net-next 14/19] net: add net device refcount tracker to struct pneigh_entry Eric Dumazet
2021-12-02 3:21 ` [PATCH net-next 15/19] net: add net device refcount tracker to struct neigh_parms Eric Dumazet
2021-12-02 3:21 ` [PATCH net-next 16/19] net: add net device refcount tracker to struct netdev_adjacent Eric Dumazet
2021-12-02 3:21 ` [PATCH net-next 17/19] ipv6: add net device refcount tracker to struct inet6_dev Eric Dumazet
2021-12-02 3:21 ` [PATCH net-next 18/19] ipv4: add net device refcount tracker to struct in_device Eric Dumazet
2021-12-02 3:21 ` [PATCH net-next 19/19] net/sched: add net device refcount tracker to struct Qdisc Eric Dumazet
2021-12-02 12:49 ` [PATCH net-next 00/19] net: add preliminary netdev refcount tracking dust.li
2021-12-02 15:13 ` Eric Dumazet
2021-12-03 3:46 ` dust.li
2021-12-03 4:06 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523110315.6f0637ed@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.