From: Dan Carpenter <dan.carpenter@oracle.com>
To: Uri Arev <me@wantyapps.xyz>
Cc: Viresh Kumar <vireshk@kernel.org>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: greybus: Fix indentation in fw-management.c
Date: Mon, 23 May 2022 15:31:52 +0300 [thread overview]
Message-ID: <20220523123152.GC4009@kadam> (raw)
In-Reply-To: <20220523120857.8476-1-me@wantyapps.xyz>
On Mon, May 23, 2022 at 03:08:57PM +0300, Uri Arev wrote:
> Reported by Checkpatch:
> CHECK: Alignment should match open parenthesis
>
> -Uri
>
Don't put your name in the commit message like this.
> Signed-off-by: Uri Arev <me@wantyapps.xyz>
> ---
> v2: More understandable title, add Signed-off-by line
Why didn't you fix this one as well?
CHECK: Alignment should match open parenthesis
#452: FILE: drivers/staging/greybus/fw-management.c:452:
+ ret = fw_mgmt_load_and_validate_operation(fw_mgmt,
+ intf_load.load_method, intf_load.firmware_tag);
regards,
dan carpenter
prev parent reply other threads:[~2022-05-23 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 12:08 [PATCH v2] staging: greybus: Fix indentation in fw-management.c Uri Arev
2022-05-23 12:08 ` Uri Arev
2022-05-23 12:31 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523123152.GC4009@kadam \
--to=dan.carpenter@oracle.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=me@wantyapps.xyz \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.