From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D66BC433F5 for ; Wed, 25 May 2022 14:11:20 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AD0D2169F; Wed, 25 May 2022 16:10:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AD0D2169F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1653487878; bh=yRgKy3AolnX1RBH745ck5qLpOvCyAGP/aBozRWlNa/I=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=fJA/go6PS+Sl7IunS7D1u5G8opE0fUecUq/m1RrfKoSaTz4C/qoyZ3ze4vxM7cQPE v3Q+Zquq7SbzQlQhjmSjsPED0nfbpHMGoOKlafEMwmJAdL0raolNfon47OVobXiZsd 9AYvTVjSIyHll4Tcw/BpsTKE0EvDHd3rK6YJPhjA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7A277F80533; Wed, 25 May 2022 16:08:44 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E073FF80236; Mon, 23 May 2022 18:56:16 +0200 (CEST) Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E9456F800E3 for ; Mon, 23 May 2022 18:56:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E9456F800E3 Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-e93bbb54f9so19155057fac.12 for ; Mon, 23 May 2022 09:56:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FfAOhZNasQcy6TRDHmB8U+mc653MKDmGV3a61UnarkE=; b=NDhRdc7pih0KdBwvR14I7x52eu5FfxwYrj1vlqbREjzgIHWIlXMb71e+nli+rB0omC bKt+r5iEwqFDjTrpwwNxCqCfLmU+5M/NYFD4/xtKgWJ4IWs61zAM4AVlcXwJ4kXeYcPk 9vv8Jy6zNCzgCKwZdBbrQQh5AVScTZ1X9DLyvLOKwRK/GHLDk+R8kSFgAFehyCRFTjZx 4SXpW3zL/OOWdvZFKKwwC2rfEIseAK/U7lOZupmiKgh3lx4Mqn89/jGF0SJNwCJHvG9j kYWlMXENo8+553Tzvh0jw4CT3emKvifm1+C01xSuKdL91VUavBCaXO45AYk5LSUB8Vx/ AsGw== X-Gm-Message-State: AOAM531PvMlFSNUAtEU10QweZWca0Qy2v2WZq18TVWQSX+iDsGIhTWeM HUG3tAxlO0Peg+bBAY+kig== X-Google-Smtp-Source: ABdhPJzG3ZFQrmj1v1yitS4jTC5DzQZmWnfRLp9MNvhBwUQ6yufF6JdEMRoPfxaQK0q/QMOIiKOBDg== X-Received: by 2002:a05:6870:5823:b0:f2:2dfd:8df0 with SMTP id r35-20020a056870582300b000f22dfd8df0mr6004573oap.157.1653324972043; Mon, 23 May 2022 09:56:12 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id eb38-20020a056870a8a600b000edf5a12baasm3976216oab.46.2022.05.23.09.56.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 09:56:11 -0700 (PDT) Received: (nullmailer pid 1750116 invoked by uid 1000); Mon, 23 May 2022 16:56:09 -0000 Date: Mon, 23 May 2022 11:56:09 -0500 From: Rob Herring To: Krzysztof Kozlowski Subject: Re: [PATCH] dt-bindings: Fix properties without any type Message-ID: <20220523165609.GA1743214-robh@kernel.org> References: <20220519211411.2200720-1-robh@kernel.org> <6ae55a29-0b29-f53c-c9bd-fae929f3caf7@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ae55a29-0b29-f53c-c9bd-fae929f3caf7@linaro.org> X-Mailman-Approved-At: Wed, 25 May 2022 16:08:39 +0200 Cc: alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, linux-pci@vger.kernel.org, Linus Walleij , dri-devel@lists.freedesktop.org, Thierry Reding , Guenter Roeck , Sam Ravnborg , chrome-platform@lists.linux.dev, Herbert Xu , Bartosz Golaszewski , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Jakub Kicinski , Paolo Abeni , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Kalle Valo , Maxime Ripard , linux-gpio@vger.kernel.org, Mark Brown , Matt Mackall , Bjorn Helgaas , Mauro Carvalho Chehab , Benson Leung , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Dmitry Torokhov , Sebastian Reichel , Peter Rosin , linux-crypto@vger.kernel.org, netdev@vger.kernel.org, Krzysztof Kozlowski , "David S. Miller" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, May 21, 2022 at 05:03:41PM +0200, Krzysztof Kozlowski wrote: > On 19/05/2022 23:14, Rob Herring wrote: > > Now that the schema tools can extract type information for all > > properties (in order to decode dtb files), finding properties missing > > any type definition is fairly trivial though not yet automated. > > > > Fix the various property schemas which are missing a type. Most of these > > tend to be device specific properties which don't have a vendor prefix. > > A vendor prefix is how we normally ensure a type is defined. > > > > Signed-off-by: Rob Herring > > --- > > .../arm/hisilicon/controller/hip04-bootwrapper.yaml | 5 +++-- > > .../bindings/display/bridge/toshiba,tc358768.yaml | 1 + > > .../devicetree/bindings/display/panel/panel-timing.yaml | 5 +++++ > > .../bindings/display/panel/raydium,rm67191.yaml | 1 + > > .../bindings/display/panel/samsung,s6e8aa0.yaml | 1 + > > .../devicetree/bindings/gpio/fairchild,74hc595.yaml | 1 + > > .../devicetree/bindings/input/google,cros-ec-keyb.yaml | 1 + > > .../devicetree/bindings/input/matrix-keymap.yaml | 4 ++++ > > Documentation/devicetree/bindings/media/i2c/adv7604.yaml | 3 ++- > > Documentation/devicetree/bindings/mux/reg-mux.yaml | 8 ++++++-- > > Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 + > > Documentation/devicetree/bindings/net/ingenic,mac.yaml | 1 + > > .../devicetree/bindings/net/ti,davinci-mdio.yaml | 1 + > > .../devicetree/bindings/net/wireless/ti,wlcore.yaml | 2 ++ > > .../devicetree/bindings/pci/snps,dw-pcie-ep.yaml | 6 ++++-- > > Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 ++ > > .../devicetree/bindings/pinctrl/canaan,k210-fpioa.yaml | 2 ++ > > Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml | 1 + > > .../devicetree/bindings/power/supply/battery.yaml | 7 ++++++- > > .../devicetree/bindings/power/supply/charger-manager.yaml | 1 + > > Documentation/devicetree/bindings/rng/st,stm32-rng.yaml | 1 + > > Documentation/devicetree/bindings/serial/8250.yaml | 1 + > > .../devicetree/bindings/sound/audio-graph-card2.yaml | 3 +++ > > .../devicetree/bindings/sound/imx-audio-hdmi.yaml | 3 +++ > > Documentation/devicetree/bindings/usb/smsc,usb3503.yaml | 1 + > > 25 files changed, 55 insertions(+), 8 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml b/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml > > index 7378159e61df..483caf0ce25b 100644 > > --- a/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml > > +++ b/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml > > @@ -17,14 +17,15 @@ properties: > > - const: hisilicon,hip04-bootwrapper > > > > boot-method: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > description: | > > Address and size of boot method. > > [0]: bootwrapper physical address > > [1]: bootwrapper size > > [2]: relocation physical address > > [3]: relocation size > > - minItems: 1 > > - maxItems: 2 > > + minItems: 2 > > + maxItems: 4 > > > > required: > > - compatible > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > index 3bd670b8e5cd..0b6f5bef120f 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > @@ -58,6 +58,7 @@ properties: > > > > properties: > > data-lines: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [ 16, 18, 24 ] > > > > port@1: > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml > > index 7749de95ee40..229e3b36ee29 100644 > > --- a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml > > @@ -146,6 +146,7 @@ properties: > > Horizontal sync pulse. > > 0 selects active low, 1 selects active high. > > If omitted then it is not used by the hardware > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [0, 1] > > > > vsync-active: > > @@ -153,6 +154,7 @@ properties: > > Vertical sync pulse. > > 0 selects active low, 1 selects active high. > > If omitted then it is not used by the hardware > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [0, 1] > > > > de-active: > > @@ -160,6 +162,7 @@ properties: > > Data enable. > > 0 selects active low, 1 selects active high. > > If omitted then it is not used by the hardware > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [0, 1] > > > > pixelclk-active: > > @@ -169,6 +172,7 @@ properties: > > sample data on rising edge. > > Use 1 to drive pixel data on rising edge and > > sample data on falling edge > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [0, 1] > > > > syncclk-active: > > @@ -179,6 +183,7 @@ properties: > > sample sync on rising edge of pixel clock. > > Use 1 to drive sync on rising edge and > > sample sync on falling edge of pixel clock > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [0, 1] > > > > interlaced: > > diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml > > index 745dd247c409..617aa8c8c03a 100644 > > --- a/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml > > @@ -24,6 +24,7 @@ properties: > > > > dsi-lanes: > > description: Number of DSI lanes to be used must be <3> or <4> > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [3, 4] > > > > v3p3-supply: > > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml > > index ca959451557e..1cdc91b3439f 100644 > > --- a/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml > > @@ -36,6 +36,7 @@ properties: > > > > init-delay: > > description: delay after initialization sequence [ms] > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > > panel-width-mm: > > description: physical panel width [mm] > > diff --git a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml > > index 5fe19fa5f67c..a99e7842ca17 100644 > > --- a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml > > +++ b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml > > @@ -26,6 +26,7 @@ properties: > > const: 2 > > > > registers-number: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > description: Number of daisy-chained shift registers > > > > enable-gpios: > > diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > > index e8f137abb03c..aa61fe64be63 100644 > > --- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > > +++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > > @@ -31,6 +31,7 @@ properties: > > type: boolean > > > > function-row-physmap: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > minItems: 1 > > maxItems: 15 > > description: | > > diff --git a/Documentation/devicetree/bindings/input/matrix-keymap.yaml b/Documentation/devicetree/bindings/input/matrix-keymap.yaml > > index 6699d5e32dca..9f703bb51e12 100644 > > --- a/Documentation/devicetree/bindings/input/matrix-keymap.yaml > > +++ b/Documentation/devicetree/bindings/input/matrix-keymap.yaml > > @@ -27,6 +27,10 @@ properties: > > column and linux key-code. The 32-bit big endian cell is packed as: > > row << 24 | column << 16 | key-code > > > > + linux,no-autorepeat: > > + type: boolean > > + description: Disable keyrepeat > > This should be rather a separate patch - it's documenting a missing > property, not only a type. Yes, I've dropped this hunk while applying. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38B1E259C for ; Mon, 23 May 2022 16:56:13 +0000 (UTC) Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-f189b07f57so19232986fac.1 for ; Mon, 23 May 2022 09:56:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FfAOhZNasQcy6TRDHmB8U+mc653MKDmGV3a61UnarkE=; b=XA/wPBwk/giqGEDA0QGhTvuMeS4WXxMQUaBLu5uj0tb6vrU62TQfdQSjnc3+U4rjAG jHYf2VfIUg6CR0EjOAB30XMTqemjvX3isaeqfR4XQGxNQURAY5EmSd2AtInIVasnD3tn GTJmg/Xylzqn3Ic2GbcruNlyrUcbqz3eQTmMd1N6Wi40/dNxRAU54pSjM0P6o2kSduBq FA5+HrT5b+gocdQV1DBpVDpT3XjVQPK62bTQ9sXNcgyAxuze1Ipur16Anq0bEx5Wxa7V ZPCendFjqqLE4tqAhcNZdWEJXTaAtYKfYwCudaYB1rMCW3no2Tu36G6TBkthu2Psu+KR dO1A== X-Gm-Message-State: AOAM533ZtwxvuBlofK8EnCuSxf1bqN0HHoDK6r/uCihS7YGlwGU4eTIx LZ38GJpz4lrs/fpnYfzlFw== X-Google-Smtp-Source: ABdhPJzG3ZFQrmj1v1yitS4jTC5DzQZmWnfRLp9MNvhBwUQ6yufF6JdEMRoPfxaQK0q/QMOIiKOBDg== X-Received: by 2002:a05:6870:5823:b0:f2:2dfd:8df0 with SMTP id r35-20020a056870582300b000f22dfd8df0mr6004573oap.157.1653324972043; Mon, 23 May 2022 09:56:12 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id eb38-20020a056870a8a600b000edf5a12baasm3976216oab.46.2022.05.23.09.56.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 09:56:11 -0700 (PDT) Received: (nullmailer pid 1750116 invoked by uid 1000); Mon, 23 May 2022 16:56:09 -0000 Date: Mon, 23 May 2022 11:56:09 -0500 From: Rob Herring To: Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, Krzysztof Kozlowski , Thierry Reding , Sam Ravnborg , Linus Walleij , Bartosz Golaszewski , Dmitry Torokhov , Benson Leung , Guenter Roeck , Mauro Carvalho Chehab , Peter Rosin , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Kalle Valo , Bjorn Helgaas , Sebastian Reichel , Matt Mackall , Herbert Xu , Greg Kroah-Hartman , Mark Brown , Maxime Ripard , dri-devel@lists.freedesktop.org, linux-gpio@vger.kernel.org, linux-input@vger.kernel.org, chrome-platform@lists.linux.dev, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] dt-bindings: Fix properties without any type Message-ID: <20220523165609.GA1743214-robh@kernel.org> References: <20220519211411.2200720-1-robh@kernel.org> <6ae55a29-0b29-f53c-c9bd-fae929f3caf7@linaro.org> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ae55a29-0b29-f53c-c9bd-fae929f3caf7@linaro.org> On Sat, May 21, 2022 at 05:03:41PM +0200, Krzysztof Kozlowski wrote: > On 19/05/2022 23:14, Rob Herring wrote: > > Now that the schema tools can extract type information for all > > properties (in order to decode dtb files), finding properties missing > > any type definition is fairly trivial though not yet automated. > > > > Fix the various property schemas which are missing a type. Most of these > > tend to be device specific properties which don't have a vendor prefix. > > A vendor prefix is how we normally ensure a type is defined. > > > > Signed-off-by: Rob Herring > > --- > > .../arm/hisilicon/controller/hip04-bootwrapper.yaml | 5 +++-- > > .../bindings/display/bridge/toshiba,tc358768.yaml | 1 + > > .../devicetree/bindings/display/panel/panel-timing.yaml | 5 +++++ > > .../bindings/display/panel/raydium,rm67191.yaml | 1 + > > .../bindings/display/panel/samsung,s6e8aa0.yaml | 1 + > > .../devicetree/bindings/gpio/fairchild,74hc595.yaml | 1 + > > .../devicetree/bindings/input/google,cros-ec-keyb.yaml | 1 + > > .../devicetree/bindings/input/matrix-keymap.yaml | 4 ++++ > > Documentation/devicetree/bindings/media/i2c/adv7604.yaml | 3 ++- > > Documentation/devicetree/bindings/mux/reg-mux.yaml | 8 ++++++-- > > Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 + > > Documentation/devicetree/bindings/net/ingenic,mac.yaml | 1 + > > .../devicetree/bindings/net/ti,davinci-mdio.yaml | 1 + > > .../devicetree/bindings/net/wireless/ti,wlcore.yaml | 2 ++ > > .../devicetree/bindings/pci/snps,dw-pcie-ep.yaml | 6 ++++-- > > Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 ++ > > .../devicetree/bindings/pinctrl/canaan,k210-fpioa.yaml | 2 ++ > > Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml | 1 + > > .../devicetree/bindings/power/supply/battery.yaml | 7 ++++++- > > .../devicetree/bindings/power/supply/charger-manager.yaml | 1 + > > Documentation/devicetree/bindings/rng/st,stm32-rng.yaml | 1 + > > Documentation/devicetree/bindings/serial/8250.yaml | 1 + > > .../devicetree/bindings/sound/audio-graph-card2.yaml | 3 +++ > > .../devicetree/bindings/sound/imx-audio-hdmi.yaml | 3 +++ > > Documentation/devicetree/bindings/usb/smsc,usb3503.yaml | 1 + > > 25 files changed, 55 insertions(+), 8 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml b/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml > > index 7378159e61df..483caf0ce25b 100644 > > --- a/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml > > +++ b/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml > > @@ -17,14 +17,15 @@ properties: > > - const: hisilicon,hip04-bootwrapper > > > > boot-method: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > description: | > > Address and size of boot method. > > [0]: bootwrapper physical address > > [1]: bootwrapper size > > [2]: relocation physical address > > [3]: relocation size > > - minItems: 1 > > - maxItems: 2 > > + minItems: 2 > > + maxItems: 4 > > > > required: > > - compatible > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > index 3bd670b8e5cd..0b6f5bef120f 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > @@ -58,6 +58,7 @@ properties: > > > > properties: > > data-lines: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [ 16, 18, 24 ] > > > > port@1: > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml > > index 7749de95ee40..229e3b36ee29 100644 > > --- a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml > > @@ -146,6 +146,7 @@ properties: > > Horizontal sync pulse. > > 0 selects active low, 1 selects active high. > > If omitted then it is not used by the hardware > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [0, 1] > > > > vsync-active: > > @@ -153,6 +154,7 @@ properties: > > Vertical sync pulse. > > 0 selects active low, 1 selects active high. > > If omitted then it is not used by the hardware > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [0, 1] > > > > de-active: > > @@ -160,6 +162,7 @@ properties: > > Data enable. > > 0 selects active low, 1 selects active high. > > If omitted then it is not used by the hardware > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [0, 1] > > > > pixelclk-active: > > @@ -169,6 +172,7 @@ properties: > > sample data on rising edge. > > Use 1 to drive pixel data on rising edge and > > sample data on falling edge > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [0, 1] > > > > syncclk-active: > > @@ -179,6 +183,7 @@ properties: > > sample sync on rising edge of pixel clock. > > Use 1 to drive sync on rising edge and > > sample sync on falling edge of pixel clock > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [0, 1] > > > > interlaced: > > diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml > > index 745dd247c409..617aa8c8c03a 100644 > > --- a/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml > > @@ -24,6 +24,7 @@ properties: > > > > dsi-lanes: > > description: Number of DSI lanes to be used must be <3> or <4> > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [3, 4] > > > > v3p3-supply: > > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml > > index ca959451557e..1cdc91b3439f 100644 > > --- a/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml > > @@ -36,6 +36,7 @@ properties: > > > > init-delay: > > description: delay after initialization sequence [ms] > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > > panel-width-mm: > > description: physical panel width [mm] > > diff --git a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml > > index 5fe19fa5f67c..a99e7842ca17 100644 > > --- a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml > > +++ b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml > > @@ -26,6 +26,7 @@ properties: > > const: 2 > > > > registers-number: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > description: Number of daisy-chained shift registers > > > > enable-gpios: > > diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > > index e8f137abb03c..aa61fe64be63 100644 > > --- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > > +++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > > @@ -31,6 +31,7 @@ properties: > > type: boolean > > > > function-row-physmap: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > minItems: 1 > > maxItems: 15 > > description: | > > diff --git a/Documentation/devicetree/bindings/input/matrix-keymap.yaml b/Documentation/devicetree/bindings/input/matrix-keymap.yaml > > index 6699d5e32dca..9f703bb51e12 100644 > > --- a/Documentation/devicetree/bindings/input/matrix-keymap.yaml > > +++ b/Documentation/devicetree/bindings/input/matrix-keymap.yaml > > @@ -27,6 +27,10 @@ properties: > > column and linux key-code. The 32-bit big endian cell is packed as: > > row << 24 | column << 16 | key-code > > > > + linux,no-autorepeat: > > + type: boolean > > + description: Disable keyrepeat > > This should be rather a separate patch - it's documenting a missing > property, not only a type. Yes, I've dropped this hunk while applying. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9AABC433EF for ; Mon, 23 May 2022 16:57:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NQ2VtYVRrQtA5GnC0skHZBuTVbjFO5AiIFfFq1hmNiY=; b=1mw46J+ijw2CsJ 4AS96uc9guvZKOOf4LIrq1ZXxsesR5+ai0N46Vs2EAqtzKa3PQhiE5OAmAkrpfiX+F/x2VufFWUmO nDFeeYZEdFsTje0eo/uevEqEHGD4+x8ydcEzL6lldjScgs1AGFQiGEZA2nuiLFoCWOEzTFQ5tNGem 4TWWvZUSvsvrNjuH09PmIlazsIQJzj++O6GkvXGARPHqdygw5w7ZclmNsD8l86rsZ1AANf261+FQf 3WSAXfJ/H0SY9dZwbsg9VQTBZ5P3ykr5rDWcwNE+gtUDpV5MBEp0EKZOMnKEv/yPKUgN71EiTBpTQ +8OYoY5oWs7cNj8HbojQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntBLt-005I54-VV; Mon, 23 May 2022 16:56:18 +0000 Received: from mail-oa1-f50.google.com ([209.85.160.50]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntBLq-005I43-DN for linux-arm-kernel@lists.infradead.org; Mon, 23 May 2022 16:56:16 +0000 Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-f16a3e0529so19237405fac.2 for ; Mon, 23 May 2022 09:56:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FfAOhZNasQcy6TRDHmB8U+mc653MKDmGV3a61UnarkE=; b=LQdXcciGLftuRAjLN/p/jwwRoQu1KCNsjyavP5Bxt7/xMPm6M+leuKqYB9Ncf9KoeN r7KomZXrS3vdJOtLrAkwuk32sAmP0FPCQe86Gm+2Q1fzDqxTY4z1f2ouw6f4eBCiQYyT aftg5uZ9ws62lqf8ng5qdTgbL3ilUI6dURD15uBl97UaZqb+x6Z0x73t85zrjtKFV/uX dSaWMhNUrwPXSw8HoQWcYsL3WjhZGkZ0II6W2CWemvXmEgs2X40q5Yw7UTM34ivaBk3q o21CxSQOv+KkjlL14fLYxX8RoZDYjgT5hyEAeTQBzarbVGTD4+L0mrgg7cemMWMYp26Z q6vw== X-Gm-Message-State: AOAM530ml0Ybv/2kaCUt+ayXyjP3LGHKQsAmktALvfdHrrVhgiCaR2sy lSE2L1qdDowF+5K8XrfyOA== X-Google-Smtp-Source: ABdhPJzG3ZFQrmj1v1yitS4jTC5DzQZmWnfRLp9MNvhBwUQ6yufF6JdEMRoPfxaQK0q/QMOIiKOBDg== X-Received: by 2002:a05:6870:5823:b0:f2:2dfd:8df0 with SMTP id r35-20020a056870582300b000f22dfd8df0mr6004573oap.157.1653324972043; Mon, 23 May 2022 09:56:12 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id eb38-20020a056870a8a600b000edf5a12baasm3976216oab.46.2022.05.23.09.56.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 09:56:11 -0700 (PDT) Received: (nullmailer pid 1750116 invoked by uid 1000); Mon, 23 May 2022 16:56:09 -0000 Date: Mon, 23 May 2022 11:56:09 -0500 From: Rob Herring To: Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, Krzysztof Kozlowski , Thierry Reding , Sam Ravnborg , Linus Walleij , Bartosz Golaszewski , Dmitry Torokhov , Benson Leung , Guenter Roeck , Mauro Carvalho Chehab , Peter Rosin , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Kalle Valo , Bjorn Helgaas , Sebastian Reichel , Matt Mackall , Herbert Xu , Greg Kroah-Hartman , Mark Brown , Maxime Ripard , dri-devel@lists.freedesktop.org, linux-gpio@vger.kernel.org, linux-input@vger.kernel.org, chrome-platform@lists.linux.dev, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] dt-bindings: Fix properties without any type Message-ID: <20220523165609.GA1743214-robh@kernel.org> References: <20220519211411.2200720-1-robh@kernel.org> <6ae55a29-0b29-f53c-c9bd-fae929f3caf7@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6ae55a29-0b29-f53c-c9bd-fae929f3caf7@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220523_095614_515961_68545A88 X-CRM114-Status: GOOD ( 30.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 21, 2022 at 05:03:41PM +0200, Krzysztof Kozlowski wrote: > On 19/05/2022 23:14, Rob Herring wrote: > > Now that the schema tools can extract type information for all > > properties (in order to decode dtb files), finding properties missing > > any type definition is fairly trivial though not yet automated. > > > > Fix the various property schemas which are missing a type. Most of these > > tend to be device specific properties which don't have a vendor prefix. > > A vendor prefix is how we normally ensure a type is defined. > > > > Signed-off-by: Rob Herring > > --- > > .../arm/hisilicon/controller/hip04-bootwrapper.yaml | 5 +++-- > > .../bindings/display/bridge/toshiba,tc358768.yaml | 1 + > > .../devicetree/bindings/display/panel/panel-timing.yaml | 5 +++++ > > .../bindings/display/panel/raydium,rm67191.yaml | 1 + > > .../bindings/display/panel/samsung,s6e8aa0.yaml | 1 + > > .../devicetree/bindings/gpio/fairchild,74hc595.yaml | 1 + > > .../devicetree/bindings/input/google,cros-ec-keyb.yaml | 1 + > > .../devicetree/bindings/input/matrix-keymap.yaml | 4 ++++ > > Documentation/devicetree/bindings/media/i2c/adv7604.yaml | 3 ++- > > Documentation/devicetree/bindings/mux/reg-mux.yaml | 8 ++++++-- > > Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 + > > Documentation/devicetree/bindings/net/ingenic,mac.yaml | 1 + > > .../devicetree/bindings/net/ti,davinci-mdio.yaml | 1 + > > .../devicetree/bindings/net/wireless/ti,wlcore.yaml | 2 ++ > > .../devicetree/bindings/pci/snps,dw-pcie-ep.yaml | 6 ++++-- > > Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 ++ > > .../devicetree/bindings/pinctrl/canaan,k210-fpioa.yaml | 2 ++ > > Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml | 1 + > > .../devicetree/bindings/power/supply/battery.yaml | 7 ++++++- > > .../devicetree/bindings/power/supply/charger-manager.yaml | 1 + > > Documentation/devicetree/bindings/rng/st,stm32-rng.yaml | 1 + > > Documentation/devicetree/bindings/serial/8250.yaml | 1 + > > .../devicetree/bindings/sound/audio-graph-card2.yaml | 3 +++ > > .../devicetree/bindings/sound/imx-audio-hdmi.yaml | 3 +++ > > Documentation/devicetree/bindings/usb/smsc,usb3503.yaml | 1 + > > 25 files changed, 55 insertions(+), 8 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml b/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml > > index 7378159e61df..483caf0ce25b 100644 > > --- a/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml > > +++ b/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml > > @@ -17,14 +17,15 @@ properties: > > - const: hisilicon,hip04-bootwrapper > > > > boot-method: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > description: | > > Address and size of boot method. > > [0]: bootwrapper physical address > > [1]: bootwrapper size > > [2]: relocation physical address > > [3]: relocation size > > - minItems: 1 > > - maxItems: 2 > > + minItems: 2 > > + maxItems: 4 > > > > required: > > - compatible > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > index 3bd670b8e5cd..0b6f5bef120f 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > @@ -58,6 +58,7 @@ properties: > > > > properties: > > data-lines: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [ 16, 18, 24 ] > > > > port@1: > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml > > index 7749de95ee40..229e3b36ee29 100644 > > --- a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml > > @@ -146,6 +146,7 @@ properties: > > Horizontal sync pulse. > > 0 selects active low, 1 selects active high. > > If omitted then it is not used by the hardware > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [0, 1] > > > > vsync-active: > > @@ -153,6 +154,7 @@ properties: > > Vertical sync pulse. > > 0 selects active low, 1 selects active high. > > If omitted then it is not used by the hardware > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [0, 1] > > > > de-active: > > @@ -160,6 +162,7 @@ properties: > > Data enable. > > 0 selects active low, 1 selects active high. > > If omitted then it is not used by the hardware > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [0, 1] > > > > pixelclk-active: > > @@ -169,6 +172,7 @@ properties: > > sample data on rising edge. > > Use 1 to drive pixel data on rising edge and > > sample data on falling edge > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [0, 1] > > > > syncclk-active: > > @@ -179,6 +183,7 @@ properties: > > sample sync on rising edge of pixel clock. > > Use 1 to drive sync on rising edge and > > sample sync on falling edge of pixel clock > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [0, 1] > > > > interlaced: > > diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml > > index 745dd247c409..617aa8c8c03a 100644 > > --- a/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml > > @@ -24,6 +24,7 @@ properties: > > > > dsi-lanes: > > description: Number of DSI lanes to be used must be <3> or <4> > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [3, 4] > > > > v3p3-supply: > > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml > > index ca959451557e..1cdc91b3439f 100644 > > --- a/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml > > @@ -36,6 +36,7 @@ properties: > > > > init-delay: > > description: delay after initialization sequence [ms] > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > > panel-width-mm: > > description: physical panel width [mm] > > diff --git a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml > > index 5fe19fa5f67c..a99e7842ca17 100644 > > --- a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml > > +++ b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml > > @@ -26,6 +26,7 @@ properties: > > const: 2 > > > > registers-number: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > description: Number of daisy-chained shift registers > > > > enable-gpios: > > diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > > index e8f137abb03c..aa61fe64be63 100644 > > --- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > > +++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > > @@ -31,6 +31,7 @@ properties: > > type: boolean > > > > function-row-physmap: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > minItems: 1 > > maxItems: 15 > > description: | > > diff --git a/Documentation/devicetree/bindings/input/matrix-keymap.yaml b/Documentation/devicetree/bindings/input/matrix-keymap.yaml > > index 6699d5e32dca..9f703bb51e12 100644 > > --- a/Documentation/devicetree/bindings/input/matrix-keymap.yaml > > +++ b/Documentation/devicetree/bindings/input/matrix-keymap.yaml > > @@ -27,6 +27,10 @@ properties: > > column and linux key-code. The 32-bit big endian cell is packed as: > > row << 24 | column << 16 | key-code > > > > + linux,no-autorepeat: > > + type: boolean > > + description: Disable keyrepeat > > This should be rather a separate patch - it's documenting a missing > property, not only a type. Yes, I've dropped this hunk while applying. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22F4CC433EF for ; Mon, 23 May 2022 16:56:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 41F1310E6FA; Mon, 23 May 2022 16:56:14 +0000 (UTC) Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id 04AB010E6FA for ; Mon, 23 May 2022 16:56:13 +0000 (UTC) Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-e5e433d66dso19200160fac.5 for ; Mon, 23 May 2022 09:56:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FfAOhZNasQcy6TRDHmB8U+mc653MKDmGV3a61UnarkE=; b=PkmYbeYfR96hgnXLjgVHfSo6j0r6RJ2qmFpKMV0E3N2mHMOlDT3687yI2YB0SLApor gAw/ZEBeShyWAlq6tKMjFnEXnD7WgEQhXEgk95mzFqlpdP+PEupSa/eJ1wg0t88Qno55 DnfuNc39FtqrtWkBTTTZBzODKD2IlPPviQcLS1MNftfI0u2568z46R6LIcV5CzJwaQnP pRMnY3JoeBJQe9tekBEHoGYafSKeF7TTuyXttfHivepSsDnU6XaErU2+W42HdeX8Ds9M 8VLnUbQSX+W/AtI2AJUuIYAKZKQMeeBOHVj25lSJ0/2C+TxOUH/gPA6Of+xaRfZ4ATO9 ro5w== X-Gm-Message-State: AOAM531zJHSgW8eS5nxQ3vhE6HUacQnjVNvW0VqmTrUvpVtJW11lWy2r nxb6t9+puDonhFqj3h798Q== X-Google-Smtp-Source: ABdhPJzG3ZFQrmj1v1yitS4jTC5DzQZmWnfRLp9MNvhBwUQ6yufF6JdEMRoPfxaQK0q/QMOIiKOBDg== X-Received: by 2002:a05:6870:5823:b0:f2:2dfd:8df0 with SMTP id r35-20020a056870582300b000f22dfd8df0mr6004573oap.157.1653324972043; Mon, 23 May 2022 09:56:12 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id eb38-20020a056870a8a600b000edf5a12baasm3976216oab.46.2022.05.23.09.56.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 09:56:11 -0700 (PDT) Received: (nullmailer pid 1750116 invoked by uid 1000); Mon, 23 May 2022 16:56:09 -0000 Date: Mon, 23 May 2022 11:56:09 -0500 From: Rob Herring To: Krzysztof Kozlowski Subject: Re: [PATCH] dt-bindings: Fix properties without any type Message-ID: <20220523165609.GA1743214-robh@kernel.org> References: <20220519211411.2200720-1-robh@kernel.org> <6ae55a29-0b29-f53c-c9bd-fae929f3caf7@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ae55a29-0b29-f53c-c9bd-fae929f3caf7@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding , Guenter Roeck , Sam Ravnborg , chrome-platform@lists.linux.dev, Herbert Xu , Bartosz Golaszewski , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Jakub Kicinski , Paolo Abeni , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Kalle Valo , linux-gpio@vger.kernel.org, Mark Brown , Matt Mackall , Bjorn Helgaas , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Dmitry Torokhov , Sebastian Reichel , Peter Rosin , linux-crypto@vger.kernel.org, netdev@vger.kernel.org, Krzysztof Kozlowski , "David S. Miller" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, May 21, 2022 at 05:03:41PM +0200, Krzysztof Kozlowski wrote: > On 19/05/2022 23:14, Rob Herring wrote: > > Now that the schema tools can extract type information for all > > properties (in order to decode dtb files), finding properties missing > > any type definition is fairly trivial though not yet automated. > > > > Fix the various property schemas which are missing a type. Most of these > > tend to be device specific properties which don't have a vendor prefix. > > A vendor prefix is how we normally ensure a type is defined. > > > > Signed-off-by: Rob Herring > > --- > > .../arm/hisilicon/controller/hip04-bootwrapper.yaml | 5 +++-- > > .../bindings/display/bridge/toshiba,tc358768.yaml | 1 + > > .../devicetree/bindings/display/panel/panel-timing.yaml | 5 +++++ > > .../bindings/display/panel/raydium,rm67191.yaml | 1 + > > .../bindings/display/panel/samsung,s6e8aa0.yaml | 1 + > > .../devicetree/bindings/gpio/fairchild,74hc595.yaml | 1 + > > .../devicetree/bindings/input/google,cros-ec-keyb.yaml | 1 + > > .../devicetree/bindings/input/matrix-keymap.yaml | 4 ++++ > > Documentation/devicetree/bindings/media/i2c/adv7604.yaml | 3 ++- > > Documentation/devicetree/bindings/mux/reg-mux.yaml | 8 ++++++-- > > Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 + > > Documentation/devicetree/bindings/net/ingenic,mac.yaml | 1 + > > .../devicetree/bindings/net/ti,davinci-mdio.yaml | 1 + > > .../devicetree/bindings/net/wireless/ti,wlcore.yaml | 2 ++ > > .../devicetree/bindings/pci/snps,dw-pcie-ep.yaml | 6 ++++-- > > Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 ++ > > .../devicetree/bindings/pinctrl/canaan,k210-fpioa.yaml | 2 ++ > > Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml | 1 + > > .../devicetree/bindings/power/supply/battery.yaml | 7 ++++++- > > .../devicetree/bindings/power/supply/charger-manager.yaml | 1 + > > Documentation/devicetree/bindings/rng/st,stm32-rng.yaml | 1 + > > Documentation/devicetree/bindings/serial/8250.yaml | 1 + > > .../devicetree/bindings/sound/audio-graph-card2.yaml | 3 +++ > > .../devicetree/bindings/sound/imx-audio-hdmi.yaml | 3 +++ > > Documentation/devicetree/bindings/usb/smsc,usb3503.yaml | 1 + > > 25 files changed, 55 insertions(+), 8 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml b/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml > > index 7378159e61df..483caf0ce25b 100644 > > --- a/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml > > +++ b/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml > > @@ -17,14 +17,15 @@ properties: > > - const: hisilicon,hip04-bootwrapper > > > > boot-method: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > description: | > > Address and size of boot method. > > [0]: bootwrapper physical address > > [1]: bootwrapper size > > [2]: relocation physical address > > [3]: relocation size > > - minItems: 1 > > - maxItems: 2 > > + minItems: 2 > > + maxItems: 4 > > > > required: > > - compatible > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > index 3bd670b8e5cd..0b6f5bef120f 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > @@ -58,6 +58,7 @@ properties: > > > > properties: > > data-lines: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [ 16, 18, 24 ] > > > > port@1: > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml > > index 7749de95ee40..229e3b36ee29 100644 > > --- a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml > > @@ -146,6 +146,7 @@ properties: > > Horizontal sync pulse. > > 0 selects active low, 1 selects active high. > > If omitted then it is not used by the hardware > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [0, 1] > > > > vsync-active: > > @@ -153,6 +154,7 @@ properties: > > Vertical sync pulse. > > 0 selects active low, 1 selects active high. > > If omitted then it is not used by the hardware > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [0, 1] > > > > de-active: > > @@ -160,6 +162,7 @@ properties: > > Data enable. > > 0 selects active low, 1 selects active high. > > If omitted then it is not used by the hardware > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [0, 1] > > > > pixelclk-active: > > @@ -169,6 +172,7 @@ properties: > > sample data on rising edge. > > Use 1 to drive pixel data on rising edge and > > sample data on falling edge > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [0, 1] > > > > syncclk-active: > > @@ -179,6 +183,7 @@ properties: > > sample sync on rising edge of pixel clock. > > Use 1 to drive sync on rising edge and > > sample sync on falling edge of pixel clock > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [0, 1] > > > > interlaced: > > diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml > > index 745dd247c409..617aa8c8c03a 100644 > > --- a/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml > > @@ -24,6 +24,7 @@ properties: > > > > dsi-lanes: > > description: Number of DSI lanes to be used must be <3> or <4> > > + $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [3, 4] > > > > v3p3-supply: > > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml > > index ca959451557e..1cdc91b3439f 100644 > > --- a/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml > > @@ -36,6 +36,7 @@ properties: > > > > init-delay: > > description: delay after initialization sequence [ms] > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > > panel-width-mm: > > description: physical panel width [mm] > > diff --git a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml > > index 5fe19fa5f67c..a99e7842ca17 100644 > > --- a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml > > +++ b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml > > @@ -26,6 +26,7 @@ properties: > > const: 2 > > > > registers-number: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > description: Number of daisy-chained shift registers > > > > enable-gpios: > > diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > > index e8f137abb03c..aa61fe64be63 100644 > > --- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > > +++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > > @@ -31,6 +31,7 @@ properties: > > type: boolean > > > > function-row-physmap: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > minItems: 1 > > maxItems: 15 > > description: | > > diff --git a/Documentation/devicetree/bindings/input/matrix-keymap.yaml b/Documentation/devicetree/bindings/input/matrix-keymap.yaml > > index 6699d5e32dca..9f703bb51e12 100644 > > --- a/Documentation/devicetree/bindings/input/matrix-keymap.yaml > > +++ b/Documentation/devicetree/bindings/input/matrix-keymap.yaml > > @@ -27,6 +27,10 @@ properties: > > column and linux key-code. The 32-bit big endian cell is packed as: > > row << 24 | column << 16 | key-code > > > > + linux,no-autorepeat: > > + type: boolean > > + description: Disable keyrepeat > > This should be rather a separate patch - it's documenting a missing > property, not only a type. Yes, I've dropped this hunk while applying. Rob