From: Rob Herring <robh@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Robin van der Gracht <robin@protonic.nl>,
Miguel Ojeda <ojeda@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Olof Johansson <olof@lixom.net>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: input: matrix-keymap: Add common 'linux,no-autorepeat' property
Date: Mon, 23 May 2022 14:45:03 -0500 [thread overview]
Message-ID: <20220523194503.GA2004570-robh@kernel.org> (raw)
In-Reply-To: <YovWpSvabyhcYnzL@google.com>
On Mon, May 23, 2022 at 11:47:01AM -0700, Dmitry Torokhov wrote:
> On Mon, May 23, 2022 at 12:04:49PM -0500, Rob Herring wrote:
> > 'linux,no-autorepeat' is a common property used in multiple bindings,
> > but doesn't have a common type definition nor description. Add a common
> > definition and drop the now redundant description from
> > holtek,ht16k33.yaml.
>
> We have "autorepeat" in the common input binding description, should we
> not promote it over "no-autorepeat"?
We're kind of stuck with it I think. We can't just deprecate one and
switch existing users as what would neither property present mean?
Hopefully, documented in input.yaml vs. matrix-keypad.yaml is enough to
say which one is preferred for new users.
Rob
next prev parent reply other threads:[~2022-05-23 19:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 17:04 [PATCH] dt-bindings: input: matrix-keymap: Add common 'linux,no-autorepeat' property Rob Herring
2022-05-23 18:47 ` Dmitry Torokhov
2022-05-23 19:45 ` Rob Herring [this message]
2022-05-23 22:02 ` Dmitry Torokhov
2022-05-24 13:31 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523194503.GA2004570-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=olof@lixom.net \
--cc=robin@protonic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.