Re: [PATCH net-next v2] net, neigh: introduce interval_probe_time for periodic probe

[Jakub Kicinski <kuba@kernel.org>]

On Tue, 24 May 2022 17:32:57 +0200 Daniel Borkmann wrote:
> Right, maybe we could just split this into two: 1) prevent misconfig (see
> below), and 2) make the timeout configurable as what Yuwei has. Wdyt?
> 
> diff --git a/net/core/neighbour.c b/net/core/neighbour.c
> index 47b6c1f0fdbb..54625287ee5b 100644
> --- a/net/core/neighbour.c
> +++ b/net/core/neighbour.c
> @@ -1579,7 +1579,7 @@ static void neigh_managed_work(struct work_struct *work)
>          list_for_each_entry(neigh, &tbl->managed_list, managed_list)
>                  neigh_event_send_probe(neigh, NULL, false);
>          queue_delayed_work(system_power_efficient_wq, &tbl->managed_work,
> -                          NEIGH_VAR(&tbl->parms, DELAY_PROBE_TIME));
> +                          max(NEIGH_VAR(&tbl->parms, DELAY_PROBE_TIME), HZ));
>          write_unlock_bh(&tbl->lock);
>   }

FWIW that was my reaction as well. Let's do that unless someone
disagrees.