From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, shinichiro.kawasaki@wdc.com,
dan.j.williams@intel.com, yukuai3@huawei.com,
linux-block@vger.kernel.org
Subject: Re: [PATCH] block: remove per-disk debugfs files in blk_unregister_queue
Date: Tue, 24 May 2022 14:01:34 +0200 [thread overview]
Message-ID: <20220524120134.GB17563@lst.de> (raw)
In-Reply-To: <YozFt0qFCvZVt67m@T590>
On Tue, May 24, 2022 at 07:47:03PM +0800, Ming Lei wrote:
> Not look into details yet, but as one blk-mq debugfs user, I don't like
> the idea, since I often see io hang issue when calling
> blk_mq_freeze_queue_wait(), and blk-mq debugfs is very helpful for
> investigating this kind of issue.
>
> But now blk-mq debugfs is gone with this patch __before__ draining IO in
> del_gendisk, and it becomes not useful as before.
This is the way hot it is set up, so in doubt I want it to be torn down
synchronously. There might be a way to move the teardown later, but
that will require a very careful audit.
next prev parent reply other threads:[~2022-05-24 12:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 8:33 [PATCH] block: remove per-disk debugfs files in blk_unregister_queue Christoph Hellwig
2022-05-24 9:29 ` Hannes Reinecke
2022-05-24 12:00 ` Christoph Hellwig
2022-05-24 11:47 ` Ming Lei
2022-05-24 12:01 ` Christoph Hellwig [this message]
2022-05-24 12:14 ` Ming Lei
2022-05-24 13:06 ` Christoph Hellwig
2022-05-24 14:44 ` Ming Lei
2022-05-27 7:15 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220524120134.GB17563@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=shinichiro.kawasaki@wdc.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.