From: James Prestwood <prestwoj at gmail.com>
To: iwd at lists.01.org
Subject: [PATCH 1/2] auto-t: fix eapol_reauth utility
Date: Tue, 24 May 2022 13:31:44 -0700 [thread overview]
Message-ID: <20220524203145.3218063-1-prestwoj@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1798 bytes --]
This was passing IFNAME= along with EAPOL_REAUTH which does not work
in the context of a hostapd socket where the iface is already implied.
This fixes that issue as well as resets the events array and actually
waits for the required events afterwards.
---
autotests/testEAP-PEAPv0-CryptoBinding/NoISK_test.py | 3 ---
autotests/util/hostapd.py | 5 ++++-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/autotests/testEAP-PEAPv0-CryptoBinding/NoISK_test.py b/autotests/testEAP-PEAPv0-CryptoBinding/NoISK_test.py
index 9a1fa52c..0323fdc1 100644
--- a/autotests/testEAP-PEAPv0-CryptoBinding/NoISK_test.py
+++ b/autotests/testEAP-PEAPv0-CryptoBinding/NoISK_test.py
@@ -37,9 +37,6 @@ class Test(unittest.TestCase):
hostapd.eapol_reauth(device.address)
- hostapd.wait_for_event('CTRL-EVENT-EAP-STARTED')
- hostapd.wait_for_event('CTRL-EVENT-EAP-SUCCESS')
-
condition = 'obj.state == DeviceState.connected'
wd.wait_for_object_condition(device, condition)
diff --git a/autotests/util/hostapd.py b/autotests/util/hostapd.py
index 6a9f37c7..ff5a97c1 100644
--- a/autotests/util/hostapd.py
+++ b/autotests/util/hostapd.py
@@ -163,8 +163,11 @@ class HostapdCLI(object):
ctx.start_process(cmd).wait()
def eapol_reauth(self, client_address):
- cmd = 'IFNAME=' + self.ifname + ' EAPOL_REAUTH ' + client_address
+ self.events = []
+ cmd = 'EAPOL_REAUTH ' + client_address
self.ctrl_sock.sendall(cmd.encode('utf-8'))
+ self.wait_for_event('CTRL-EVENT-EAP-STARTED')
+ self.wait_for_event('CTRL-EVENT-EAP-SUCCESS')
def reload(self):
# Seemingly all three commands needed for the instance to notice
--
2.34.1
next reply other threads:[~2022-05-24 20:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 20:31 James Prestwood [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-05-26 16:25 [PATCH 1/2] auto-t: fix eapol_reauth utility Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220524203145.3218063-1-prestwoj@gmail.com \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.