From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yuri Nudelman <ynudelman@habana.ai>
Cc: Oded Gabbay <ogabbay@kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [bug report] habanalabs: convert ts to use unified memory manager
Date: Wed, 25 May 2022 09:55:57 +0300 [thread overview]
Message-ID: <20220525065557.GA2146@kadam> (raw)
In-Reply-To: <d238619e-243b-1333-5a69-9caccfa96969@habana.ai>
On Tue, May 24, 2022 at 03:07:18PM +0000, Yuri Nudelman wrote:
>
> Hi,
>
> In this flow gfp cannot be atomic, so there is no severe problem with
> that. The fact I left explicit GFP_KERNEL flag in this code is a typo.
>
> This function serves as a callback, and is invoked via a function pointer
> through the hl_mmap_mem_buf_alloc, which can receive a GFP_ATOMIC
> argument, but not in the flow when the callback is hl_ts_alloc_buf.
That's okay then.
>
> I will change it from GFP_KERNEL to gfp to avoid the warning,
No don't do that. Just ignore false positives. Plus eventually we will
implement the other check that I mentioned.
regards,
dan carpenter
prev parent reply other threads:[~2022-05-25 6:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 13:56 [bug report] habanalabs: convert ts to use unified memory manager Dan Carpenter
2022-05-24 15:07 ` Yuri Nudelman
2022-05-25 6:55 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220525065557.GA2146@kadam \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=ynudelman@habana.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.