From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7874C433FE for ; Wed, 25 May 2022 22:20:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243501AbiEYWUO (ORCPT ); Wed, 25 May 2022 18:20:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345453AbiEYWUJ (ORCPT ); Wed, 25 May 2022 18:20:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F42A674FC; Wed, 25 May 2022 15:20:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 08C7C60A2A; Wed, 25 May 2022 22:20:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0633C385B8; Wed, 25 May 2022 22:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1653517207; bh=c7KzToDeUqtD99O2hzHK7o5kCE8vnxm1uZ6cI59st/U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lc5Bswn5/mLgrZUzDGaOfcSNR02Mm/oMMFmAsk3PMUUgwWwgJa8zBW3fhkYeoBrs6 zULKKPi/KMazKRvfEOpIG5mlq58qHM3l4UzEO0HxQt9EhuXQjV37+aQrktHPNlneq8 f2dYK6/dz9JhOi+TYCUG0YZy8hrl37z6cFtGSZlg= Date: Wed, 25 May 2022 15:20:06 -0700 From: Andrew Morton To: Jessica Clarke Cc: kernel test robot , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-riscv@lists.infradead.org, linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org, linux-parport@lists.infradead.org, linux-omap@vger.kernel.org, linux-mm@kvack.org, linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, dri-devel@lists.freedesktop.org, bpf@vger.kernel.org, amd-gfx@lists.freedesktop.org, alsa-devel@alsa-project.org Subject: Re: [linux-next:master] BUILD REGRESSION 8cb8311e95e3bb58bd84d6350365f14a718faa6d Message-Id: <20220525152006.e87d3fa50aca58fdc1b43b6a@linux-foundation.org> In-Reply-To: References: <628ea118.wJYf60YnZco0hs9o%lkp@intel.com> <20220525145056.953631743a4c494aabf000dc@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, 25 May 2022 23:07:35 +0100 Jessica Clarke wrote: > This is i386, so an unsigned long is 32-bit, but i_blocks is a blkcnt_t > i.e. a u64, which makes the shift without a cast of the LHS fishy. Ah, of course, thanks. I remember 32 bits ;) --- a/mm/shmem.c~mm-shmemc-suppress-shift-warning +++ a/mm/shmem.c @@ -1945,7 +1945,7 @@ alloc_nohuge: spin_lock_irq(&info->lock); info->alloced += folio_nr_pages(folio); - inode->i_blocks += BLOCKS_PER_PAGE << folio_order(folio); + inode->i_blocks += (blkcnt_t)BLOCKS_PER_PAGE << folio_order(folio); shmem_recalc_inode(inode); spin_unlock_irq(&info->lock); alloced = true; _ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1229C433EF for ; Thu, 26 May 2022 02:07:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5289210E138; Thu, 26 May 2022 02:07:02 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by gabe.freedesktop.org (Postfix) with ESMTPS id 84B2E10F263; Wed, 25 May 2022 22:20:12 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B9A8BB81EAD; Wed, 25 May 2022 22:20:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0633C385B8; Wed, 25 May 2022 22:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1653517207; bh=c7KzToDeUqtD99O2hzHK7o5kCE8vnxm1uZ6cI59st/U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lc5Bswn5/mLgrZUzDGaOfcSNR02Mm/oMMFmAsk3PMUUgwWwgJa8zBW3fhkYeoBrs6 zULKKPi/KMazKRvfEOpIG5mlq58qHM3l4UzEO0HxQt9EhuXQjV37+aQrktHPNlneq8 f2dYK6/dz9JhOi+TYCUG0YZy8hrl37z6cFtGSZlg= Date: Wed, 25 May 2022 15:20:06 -0700 From: Andrew Morton To: Jessica Clarke Subject: Re: [linux-next:master] BUILD REGRESSION 8cb8311e95e3bb58bd84d6350365f14a718faa6d Message-Id: <20220525152006.e87d3fa50aca58fdc1b43b6a@linux-foundation.org> In-Reply-To: References: <628ea118.wJYf60YnZco0hs9o%lkp@intel.com> <20220525145056.953631743a4c494aabf000dc@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Thu, 26 May 2022 02:07:01 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, kernel test robot , kvm@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, linux-staging@lists.linux.dev, alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, amd-gfx@lists.freedesktop.org, linux-pci@vger.kernel.org, linux-riscv@lists.infradead.org, linux-omap@vger.kernel.org, bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parport@lists.infradead.org Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Wed, 25 May 2022 23:07:35 +0100 Jessica Clarke wrote: > This is i386, so an unsigned long is 32-bit, but i_blocks is a blkcnt_t > i.e. a u64, which makes the shift without a cast of the LHS fishy. Ah, of course, thanks. I remember 32 bits ;) --- a/mm/shmem.c~mm-shmemc-suppress-shift-warning +++ a/mm/shmem.c @@ -1945,7 +1945,7 @@ alloc_nohuge: spin_lock_irq(&info->lock); info->alloced += folio_nr_pages(folio); - inode->i_blocks += BLOCKS_PER_PAGE << folio_order(folio); + inode->i_blocks += (blkcnt_t)BLOCKS_PER_PAGE << folio_order(folio); shmem_recalc_inode(inode); spin_unlock_irq(&info->lock); alloced = true; _ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2251DC433EF for ; Wed, 25 May 2022 22:20:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Message-Id:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O1VJZrVsnCNirjoQ80j20JKR+wHUIiNylpjPxP9ab20=; b=gUmnGvpO/WW+hd q7HYxrm1BDJss7QHcW3Q6/WvWzsZrONefbiycj0hkUVopoquDtBVYbAtzr6HnE+105Xxd4nBHyrXP uEXuNtwqSbu8q7Sewbeq3AxMTdJwy2ohnen/Sce327Xx5p3CaJETRTwLaijFTHtOFb6RTLB9wzgnk dpgfxDYYsLhWNoIDRwtwvXzg6houf4LcV+84kQDEQmBOx2xE0I+k6iXfiD6uW9UiGqdRxyVqx4LgI Wxt47uFA7V+9GYhg809fxnpUXatqsgr4Gp96nH7z0GJ0JDAderEFjBEc++W9ZrdMKr89utGvN8JKW bwJXTQ3lPtMVpz3oPvkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntzMb-00Cqyh-5x; Wed, 25 May 2022 22:20:21 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntzMQ-00Cqv6-A2; Wed, 25 May 2022 22:20:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B9A8BB81EAD; Wed, 25 May 2022 22:20:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0633C385B8; Wed, 25 May 2022 22:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1653517207; bh=c7KzToDeUqtD99O2hzHK7o5kCE8vnxm1uZ6cI59st/U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lc5Bswn5/mLgrZUzDGaOfcSNR02Mm/oMMFmAsk3PMUUgwWwgJa8zBW3fhkYeoBrs6 zULKKPi/KMazKRvfEOpIG5mlq58qHM3l4UzEO0HxQt9EhuXQjV37+aQrktHPNlneq8 f2dYK6/dz9JhOi+TYCUG0YZy8hrl37z6cFtGSZlg= Date: Wed, 25 May 2022 15:20:06 -0700 From: Andrew Morton To: Jessica Clarke Cc: kernel test robot , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-riscv@lists.infradead.org, linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org, linux-parport@lists.infradead.org, linux-omap@vger.kernel.org, linux-mm@kvack.org, linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, dri-devel@lists.freedesktop.org, bpf@vger.kernel.org, amd-gfx@lists.freedesktop.org, alsa-devel@alsa-project.org Subject: Re: [linux-next:master] BUILD REGRESSION 8cb8311e95e3bb58bd84d6350365f14a718faa6d Message-Id: <20220525152006.e87d3fa50aca58fdc1b43b6a@linux-foundation.org> In-Reply-To: References: <628ea118.wJYf60YnZco0hs9o%lkp@intel.com> <20220525145056.953631743a4c494aabf000dc@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220525_152010_536111_B4CCD837 X-CRM114-Status: UNSURE ( 9.24 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, 25 May 2022 23:07:35 +0100 Jessica Clarke wrote: > This is i386, so an unsigned long is 32-bit, but i_blocks is a blkcnt_t > i.e. a u64, which makes the shift without a cast of the LHS fishy. Ah, of course, thanks. I remember 32 bits ;) --- a/mm/shmem.c~mm-shmemc-suppress-shift-warning +++ a/mm/shmem.c @@ -1945,7 +1945,7 @@ alloc_nohuge: spin_lock_irq(&info->lock); info->alloced += folio_nr_pages(folio); - inode->i_blocks += BLOCKS_PER_PAGE << folio_order(folio); + inode->i_blocks += (blkcnt_t)BLOCKS_PER_PAGE << folio_order(folio); shmem_recalc_inode(inode); spin_unlock_irq(&info->lock); alloced = true; _ _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16531C43217 for ; Wed, 25 May 2022 22:20:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 9DD7A410C3; Wed, 25 May 2022 22:20:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dEcIozIMTquP; Wed, 25 May 2022 22:20:14 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 46FCC4012D; Wed, 25 May 2022 22:20:14 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 13149C0039; Wed, 25 May 2022 22:20:14 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 40641C002D for ; Wed, 25 May 2022 22:20:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2F5BD8446F for ; Wed, 25 May 2022 22:20:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=linux-foundation.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hWUCRg8H4HsV for ; Wed, 25 May 2022 22:20:12 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by smtp1.osuosl.org (Postfix) with ESMTPS id 72D9A8446D for ; Wed, 25 May 2022 22:20:12 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B9A8BB81EAD; Wed, 25 May 2022 22:20:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0633C385B8; Wed, 25 May 2022 22:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1653517207; bh=c7KzToDeUqtD99O2hzHK7o5kCE8vnxm1uZ6cI59st/U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lc5Bswn5/mLgrZUzDGaOfcSNR02Mm/oMMFmAsk3PMUUgwWwgJa8zBW3fhkYeoBrs6 zULKKPi/KMazKRvfEOpIG5mlq58qHM3l4UzEO0HxQt9EhuXQjV37+aQrktHPNlneq8 f2dYK6/dz9JhOi+TYCUG0YZy8hrl37z6cFtGSZlg= Date: Wed, 25 May 2022 15:20:06 -0700 From: Andrew Morton To: Jessica Clarke Subject: Re: [linux-next:master] BUILD REGRESSION 8cb8311e95e3bb58bd84d6350365f14a718faa6d Message-Id: <20220525152006.e87d3fa50aca58fdc1b43b6a@linux-foundation.org> In-Reply-To: References: <628ea118.wJYf60YnZco0hs9o%lkp@intel.com> <20220525145056.953631743a4c494aabf000dc@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Cc: linux-fbdev@vger.kernel.org, kernel test robot , kvm@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, linux-staging@lists.linux.dev, alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, amd-gfx@lists.freedesktop.org, linux-pci@vger.kernel.org, linux-riscv@lists.infradead.org, linux-omap@vger.kernel.org, bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parport@lists.infradead.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Wed, 25 May 2022 23:07:35 +0100 Jessica Clarke wrote: > This is i386, so an unsigned long is 32-bit, but i_blocks is a blkcnt_t > i.e. a u64, which makes the shift without a cast of the LHS fishy. Ah, of course, thanks. I remember 32 bits ;) --- a/mm/shmem.c~mm-shmemc-suppress-shift-warning +++ a/mm/shmem.c @@ -1945,7 +1945,7 @@ alloc_nohuge: spin_lock_irq(&info->lock); info->alloced += folio_nr_pages(folio); - inode->i_blocks += BLOCKS_PER_PAGE << folio_order(folio); + inode->i_blocks += (blkcnt_t)BLOCKS_PER_PAGE << folio_order(folio); shmem_recalc_inode(inode); spin_unlock_irq(&info->lock); alloced = true; _ _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A4CEC433EF for ; Wed, 25 May 2022 22:21:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Message-Id:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=828NU9qA/3w//gCkmFf0tXELeFJs7vIz7khBlP5+WXM=; b=GExb+llLdEY4Ky U1FNuntOm4ibRS9yFC0RqyRtB1D7GwbwuDaZ7Tx7q0wchkhHbgA1ct5VIVo3aI9kDFjUbgU6S30MI d8n5xFVb0bXfQixfhZJFI5yPTbB58In7QMiCn4F3+bfNRDWEjN4/7jC501vPtqd9IQQLLbh3iD6WW gt3yDiyFSxOdOD3X/lOLae3GLiU68n9znSWwQncLgwO/U4gvL3kpbvsblWABH1R/JEjxLrFCxe9Mb UjxIQV4Lk414vQzHIAE4gNGomjsUIQXM6EdQH2s5ImmRiAY60+UdrXUN36aNp92dDG6SkHpq/tcFo i+1bfOr0x/Sl0sVvECSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntzMS-00Cqvo-SY; Wed, 25 May 2022 22:20:12 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntzMQ-00Cqv6-A2; Wed, 25 May 2022 22:20:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B9A8BB81EAD; Wed, 25 May 2022 22:20:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0633C385B8; Wed, 25 May 2022 22:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1653517207; bh=c7KzToDeUqtD99O2hzHK7o5kCE8vnxm1uZ6cI59st/U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lc5Bswn5/mLgrZUzDGaOfcSNR02Mm/oMMFmAsk3PMUUgwWwgJa8zBW3fhkYeoBrs6 zULKKPi/KMazKRvfEOpIG5mlq58qHM3l4UzEO0HxQt9EhuXQjV37+aQrktHPNlneq8 f2dYK6/dz9JhOi+TYCUG0YZy8hrl37z6cFtGSZlg= Date: Wed, 25 May 2022 15:20:06 -0700 From: Andrew Morton To: Jessica Clarke Cc: kernel test robot , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-riscv@lists.infradead.org, linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org, linux-parport@lists.infradead.org, linux-omap@vger.kernel.org, linux-mm@kvack.org, linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, dri-devel@lists.freedesktop.org, bpf@vger.kernel.org, amd-gfx@lists.freedesktop.org, alsa-devel@alsa-project.org Subject: Re: [linux-next:master] BUILD REGRESSION 8cb8311e95e3bb58bd84d6350365f14a718faa6d Message-Id: <20220525152006.e87d3fa50aca58fdc1b43b6a@linux-foundation.org> In-Reply-To: References: <628ea118.wJYf60YnZco0hs9o%lkp@intel.com> <20220525145056.953631743a4c494aabf000dc@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220525_152010_536111_B4CCD837 X-CRM114-Status: UNSURE ( 9.24 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 25 May 2022 23:07:35 +0100 Jessica Clarke wrote: > This is i386, so an unsigned long is 32-bit, but i_blocks is a blkcnt_t > i.e. a u64, which makes the shift without a cast of the LHS fishy. Ah, of course, thanks. I remember 32 bits ;) --- a/mm/shmem.c~mm-shmemc-suppress-shift-warning +++ a/mm/shmem.c @@ -1945,7 +1945,7 @@ alloc_nohuge: spin_lock_irq(&info->lock); info->alloced += folio_nr_pages(folio); - inode->i_blocks += BLOCKS_PER_PAGE << folio_order(folio); + inode->i_blocks += (blkcnt_t)BLOCKS_PER_PAGE << folio_order(folio); shmem_recalc_inode(inode); spin_unlock_irq(&info->lock); alloced = true; _ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel