All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tan Tee Min <tee.min.tan@linux.intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Voon Wei Feng <weifeng.voon@intel.com>,
	Sit Michael Wei Hong <michael.wei.hong.sit@intel.com>,
	Ling Pei Lee <pei.lee.ling@intel.com>,
	Looi Hong Aun <hong.aun.looi@intel.com>,
	Tan Tee Min <tee.min.tan@intel.com>
Subject: Re: [PATCH net-next 1/1] net: phy: dp83867: retrigger SGMII AN when link change
Date: Thu, 26 May 2022 16:18:39 +0800	[thread overview]
Message-ID: <20220526081839.GA26465@linux.intel.com> (raw)
In-Reply-To: <20220525215629.69af5bf5@kernel.org>

On Wed, May 25, 2022 at 09:56:29PM -0700, Jakub Kicinski wrote:
> On Thu, 26 May 2022 09:37:14 +0800 Tan Tee Min wrote:
> > As suggested by TI, implemented a SW solution here to retrigger SGMII
> > Auto-Neg whenever there is a link change.
> 
> Thanks, sounds like this bug has always been in the driver so we should
> add:
> 
> Fixes: 2a10154abcb7 ("net: phy: dp83867: Add TI dp83867 phy")
> 
> Is that right? Getting a workaround like this into stable eventually
> seems like a good idea so Fixes tag will help.

Thanks for the quick response.

Yes, you are right.
Let me add the Fixes tag and Cc <stable@vger.kernel.org> in v2 patch.

Thanks,
Tee Min


      reply	other threads:[~2022-05-26  8:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26  1:37 [PATCH net-next 1/1] net: phy: dp83867: retrigger SGMII AN when link change Tan Tee Min
2022-05-26  4:56 ` Jakub Kicinski
2022-05-26  8:18   ` Tan Tee Min [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220526081839.GA26465@linux.intel.com \
    --to=tee.min.tan@linux.intel.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=hong.aun.looi@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=michael.wei.hong.sit@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pei.lee.ling@intel.com \
    --cc=tee.min.tan@intel.com \
    --cc=weifeng.voon@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.