From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233900AbiEZNtp (ORCPT ); Thu, 26 May 2022 09:49:45 -0400 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 084032E6BA for ; Thu, 26 May 2022 06:49:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : content-transfer-encoding : in-reply-to : mime-version; s=corp-2021-07-09; bh=UtasTR+LUABMn8hCZwo7apbvGeXobgYtm/N5QonAqds=; b=L9XoIvtTeSvzPqIDS7KmVr9fCLwTgD2a1uzwcOEUlzXxmKgdNR/ewX0FSvOWJsnWAwCX lFMHCcXYATbS1MPp9bBS2Feoi4Y8yriwjQCDJVrmDATTCDY5JMpyC1cL8pfuugLZ1wO9 SnRzphscoLZU/bchEfFTmgSISKrR/ovbQuv24l/MEL+Ro/mIp3jDriDjrDHGUlZJEKfh 39wrTzKCdZSljhjWea8D2KbAKNsxeP9gGGP/OwYAEVJ314y1NIXyn2JSVMM8h2L2Ca3V GVW1YY9beiE/WxBPThWlQY9dManQZsFmpNapJe4pmdgqUWd2FcPuL22WQdwzRwyqvSxO 6Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Gr126Ltn+kOAkVt0qVQsTbqlzDTv2gvB0l8k9HlAKo=; b=vjI01ILcCVyfhCyLOcv1V6ze458B8mXDl/M5rym6FclAilFswkgE+gxURlVTB4/E8xe5eVLAAaEarbkAg5ztn9VY1h9gbEFWQVkWJfw/wbrsHZp+fhVUhQQzCaQ+P6PLhFyBFo+GVGjpw+BZep0W6wR6ciqjxDeBfulS7bbw07k= Date: Thu, 26 May 2022 16:49:23 +0300 From: Dan Carpenter Subject: Re: [RFC PATCH] check_freeing_devm: Also track erroneous usage of kfree when the pointer has been re-assigned Message-ID: <20220526134923.GG2168@kadam> References: <6e88b795e1283cc306f9d009dcec70ff162943e8.1653548169.git.christophe.jaillet@wanadoo.fr> <20220526095154.GD2146@kadam> <58ca2e95-4086-96f4-7c50-8206212b144b@wanadoo.fr> <20220526110702.GD2168@kadam> <20220526120016.GE2168@kadam> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: MIME-Version: 1.0 List-ID: To: Christophe JAILLET Cc: smatch@vger.kernel.org On Thu, May 26, 2022 at 03:37:58PM +0200, Christophe JAILLET wrote: >=20 > Le 26/05/2022 =E0 14:00, Dan Carpenter a =E9crit=A0: > > On Thu, May 26, 2022 at 01:40:51PM +0200, Marion & Christophe JAILLET w= rote: > > > Le 26/05/2022 =E0 13:07, Dan Carpenter a =E9crit=A0: > > > > On Thu, May 26, 2022 at 12:30:05PM +0200, Christophe JAILLET wrote: > > > > > Le 26/05/2022 =E0 11:51, Dan Carpenter a =E9crit=A0: > > > > > > > All I know is that it seams to work for me, even if it has no= t detected any > > > > > > > issue yet :) (compiling takes SO MUCH time on my machine) > > > > > > Yeah. :/ How big is your smatch_db.sqlite file? > > > > > I don't use any up-to-now. > > > > Basically all my changes are targetted at making the smatch_db.sqli= te > > > > file smaller so they won't help you. Are you at least doing a para= llel > > > > build? The smatch_scripts/test_kernel.sh script does a make -j${NR= _CPU}. > > > Yep. > > >=20 > > > I've also tweaked smatch_scripts/kchecker which doesn't have any -j, = IIUC. > > Normally, I only use kchecker on one file... The problem with doing > > parallel builds is that you have to print the warnings to a file instead > > of to stdout. >=20 > smatch.txt: >=20 > You can also build a directory like this: >=20 > =A0=A0 =A0~/progs/smatch/devel/smatch_scripts/kchecker drivers/whatever/ >=20 > and up no now, it is mostly the wayIi use it, :) >=20 I guess -j has no downside if you're building a single file. The only problem is that if you're building a directory and sending everything to stdout then the lines can get smooshed together. Is it better to just let them smoosh or build the whole directory and then find -name \*.c.smatch -exec cat \{\} \;? regards, dan carpenter