All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Auld <pauld@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Valentin Schneider <vschneid@redhat.com>
Subject: [PATCH v2 0/2] cpuhp: fix some st->target issues
Date: Thu, 26 May 2022 12:06:13 -0400	[thread overview]
Message-ID: <20220526160615.7976-1-pauld@redhat.com> (raw)

Several small fixes that clean up some cpuhp inconsistencies.
The first prevents target_store() from calling cpu_down() when
target == state which prevents the cpu being incorrectly marked
as dying.  The second just makes the boot cpu have a valid cpuhp 
target rather than 0 (CPU_OFFLINE) while being in state 
CPU_ONLINE.

A further issue which these two patches don't address is that
the cpuX/online file looks at the device->offline state and can
thus get out of sync with the actual cpuhp state if the cpuhp
target is used to change state.


Cheers,
Phil


Phil Auld (2):
  cpuhp: make target_store() a nop when target == state
  cpuhp: Set cpuhp target for boot cpu

 kernel/cpu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.18.0


             reply	other threads:[~2022-05-26 16:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26 16:06 Phil Auld [this message]
2022-05-26 16:06 ` [PATCH v2 1/2] cpuhp: make target_store() a nop when target == state Phil Auld
2022-05-27  9:38   ` Valentin Schneider
2022-05-27 13:22     ` Phil Auld
2022-05-30 12:27       ` Valentin Schneider
2022-06-01 15:49         ` Phil Auld
2022-06-01 16:39           ` Valentin Schneider
2022-05-26 16:06 ` [PATCH v2 2/2] cpuhp: Set cpuhp target for boot cpu Phil Auld
2022-05-27  9:38   ` Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220526160615.7976-1-pauld@redhat.com \
    --to=pauld@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.