From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nuT94-0006WN-Kd for mharc-grub-devel@gnu.org; Fri, 27 May 2022 02:08:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuT8v-0006TS-Ew for grub-devel@gnu.org; Fri, 27 May 2022 02:08:13 -0400 Received: from de-smtp-delivery-102.mimecast.com ([194.104.109.102]:49673) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuT8j-0003rB-71 for grub-devel@gnu.org; Fri, 27 May 2022 02:08:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653631676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8bB2OEeASZ3WMKJdZQh0DvWAMQaC2amzASaiEmunnqc=; b=OPIv28+WEjNgb6XomKGm49sHFQvXWak60W5p8+njkxXdYb6Kz28yFIynn7/ZYZ7QyargNU gsZWYly7/aIzny37vSjxSRlK3+l1LzpToyJRhN1Wy8uigh4nnfOe3cUvgXONIhOGsss5pW OmiiuuYNR+t+KZpoocH0GE6lvV+bH04= Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2053.outbound.protection.outlook.com [104.47.4.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-23-uq1fCSDWOx2gRSwbsPuHMA-1; Fri, 27 May 2022 08:07:54 +0200 X-MC-Unique: uq1fCSDWOx2gRSwbsPuHMA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pl+h6Lf7F+cDV0IeKylA3jp61sqjTpnPWJXnMXqi/8iW06gcEhON30ri4mmWOZWRBpihRbmtphYIT//UBKYvW5keA3SxrsGpUySYML3k9YxAUVKiVNOkKAB3STks1xiFc4YmGuE99JshFppcNOjq856I2ovV2eQCJszLnOCDXWOl9S0oIOZDTal2/NPcvdM2vYohTPrl0kd/v4V7nf8avlQlPP1O4DOxQvWhoSlJB/SRTdsvXwYHFQS4MNR3G5G0u7btEovi9aIvDMmf7qk1AiWQxLuvc+2XDKN9sD7JJW5+yWvi1oTa6eMTRC8dCnmk01NTA6FFUf6/aMPch2Vn5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8bB2OEeASZ3WMKJdZQh0DvWAMQaC2amzASaiEmunnqc=; b=JnQLr3s1hgX5sUHwPVzDYIzoXoIJfrVe7yBj5Y5GwPxrUHqJ177NxWv2O8sEItW7Y3+xVZsIiiBklNAELjMdOngG4scRe7uRgiONxiG99iznGhJw0Weots0wFWoPbqpkY85jf/C9uCsG2kbeUOnP7JdjDIeIQ5i7aKI6hF86BY8jv7qr6RTpHDTVjZ+XV6Uq0u2vIgHELuuajEpTtTzfU0xQ4g4/60HAMUNBj1AELFiNkBu/FIUMSNMFqwdretKK1SoSTZest+aDIypEyIhDAyHAn3WYA67Av2l9j80siiGrpIeQevjqxjLMBPY3Hw4RWjfVnu/btDb8EJPqJhwrrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB9081.eurprd04.prod.outlook.com (2603:10a6:10:2f0::13) by VI1PR04MB6878.eurprd04.prod.outlook.com (2603:10a6:803:12f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Fri, 27 May 2022 06:07:53 +0000 Received: from DU2PR04MB9081.eurprd04.prod.outlook.com ([fe80::bcf1:779a:12b7:ee7b]) by DU2PR04MB9081.eurprd04.prod.outlook.com ([fe80::bcf1:779a:12b7:ee7b%6]) with mapi id 15.20.5293.013; Fri, 27 May 2022 06:07:53 +0000 Date: Fri, 27 May 2022 14:07:46 +0800 From: Michael Chang To: The development of GNU GRUB Cc: Mathieu Desnoyers Subject: Re: [RFC PATCH v3 5/5] Cleanup: grub-mkconfig_lib: remove unused version comparison functions Message-ID: <20220527060746.GA8033@mazu> References: <20220520143741.217690-1-mathieu.desnoyers@efficios.com> <20220520143741.217690-6-mathieu.desnoyers@efficios.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: HKAPR04CA0017.apcprd04.prod.outlook.com (2603:1096:203:d0::27) To DU2PR04MB9081.eurprd04.prod.outlook.com (2603:10a6:10:2f0::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7692c6a5-6791-4647-cffe-08da3fa73c4e X-MS-TrafficTypeDiagnostic: VI1PR04MB6878:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fsdevtEVnnOOJiPmhnlLDiTuGlB1MXHlF+FCOKv915yOXB1b1fQ8gDWNyq5rS8zYZ+EZb3CgSKUOORieISX1wXQivnSasUJYhFF2mpyJZy2073ZIvIM3c6xvAfd3eGWmCLtClaW1ZDAbErz0ZYz+ysr4uvIBbwEtP2e7JacI4yTzx3nNBj5FmI63PgKSaq9a+JLASSwfK8LOaWSBgMkF2E1WWb9EmfmTss5NWok0q0ojy8HEYMhh0p721mGulHd1EyV2U4BSkdxteOLfFbmaC5WEZAdzjBowI34xc2izfdogQngpl07EDTP+Kp3UqhVl3ldVdh/pGCN5GjQ8XhbSYS4WLFz0cD5IDfvuDyQ+lyxarkm68acTJ//NymjmuAumX3cAd/QgshLgLKerThOQO5yYMuJpZJ7YvDwtgpjJM1gmO/KB+GkFi3NmmCh2VzKV+rFd6HjQIxOLzx+CGC6ZF4YxQAdKvjKSlnbofpC9oQ9KXaU808TDtw72wqPZAIsLpQ2RL59a85eZxDxCZCgiTjlF6/+mEgORxwsK8mexKdR77TOSncbZkyjJDnajIpXYi7+FNm8FsMZqzdrv0dCBWh29GbVsqL/Fn7ImyWkqW9FLMyCpNZSqCgswSKY2JyE1EZHjTf05e0LUi02qJMQW80UqLOI+1hUQOzEYHrDxhy9Q5qWoXirihg52OKbURjhVL7BWJcrpBUWebOX6sWOXXLJm7s8/vLbLNJcYC+WyxISR4WZ6kUkJ6aif8lhuenFc X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB9081.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(7916004)(366004)(33656002)(6666004)(33716001)(5660300002)(186003)(66476007)(6916009)(1076003)(38100700002)(2906002)(316002)(8936002)(86362001)(6506007)(966005)(6486002)(6512007)(508600001)(9686003)(8676002)(66946007)(4326008)(66556008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3EcruiRph0hOw4a3VEI+86NBa16vOhMZkhvNb2kLbjmVV/tG03/hziOB2PJK?= =?us-ascii?Q?9a5j/6+xeN6bbmuoIGMIrdEANNbCowwumps7Tkqxmfp+muAoEWc6J9d2l3af?= =?us-ascii?Q?PnMUqIb593zQ0bmNNpKbmIY3tvT3592QDA+L6LPowB473+Krgg0jmcJQN+Yb?= =?us-ascii?Q?tHTAUHdm0KIfuegezsgthcYt04aIrjMy1XBbuR082arOqLN9uBJfDGt/mEsL?= =?us-ascii?Q?axs+jIqPawpVq1ygFhRnslbcXTxwjDbYJttTXF/eGvh7P3LfgfgKasM9fn/7?= =?us-ascii?Q?bOW3HDTYiYMLgZGwhR71RpPc3FSs3EdMhgllHh0BTFCTcFnw8Dcmso9Focdw?= =?us-ascii?Q?24Q8V+UvnirZG/sx1BZ50hHrmMNwVqxsxSyVhFa3uSgCfsRf5ocxz0kxqP5v?= =?us-ascii?Q?MMCKmlVWC4hGq74P+DSQ6t1sK9h+8GCKhYFdTUcU10GjBWmjSO55V/legdui?= =?us-ascii?Q?JwytzXovF5mf+XauPVm6wsdDsELgGW0yNjs0kjW6vjzhpS4wS2Rx3f6OiYXd?= =?us-ascii?Q?+/e/7UrWvwstsM9PoAMfIvSnomyR+OnYAYFSM8DRyDtS+omkkhVIVoKHhHX7?= =?us-ascii?Q?+zkSF19irUYTCm4shYweNbff/ZZC9vNdiNIj9waDvE+qn+1QlrtNPVa3fX8a?= =?us-ascii?Q?ETb38YYZxDgr93l5N+ckrE9/PpDVcV/gWhUxASya2eUg8Sf84rvCi8dKn6G9?= =?us-ascii?Q?MxuTdQwEwK4VHkCTDsCnL+YAWZ4DCxrV2ZrZOuYbjqzRvGrtzle3q/1ja/1Y?= =?us-ascii?Q?tjcrYjMoJBXjckgvmg/oDAow7cY5rv1Y+0xQDHFIG2YG9c+MuEbhPGxf+aB3?= =?us-ascii?Q?Rb1PZXxE6atktlZGM94YaB0gmj9wFtkqeX3GdSpIrM5nXmFF/GODaUx/+P3A?= =?us-ascii?Q?v2JLjImZs30kiYPQJvgVuVqNzkaZzpRrwBoPIpHH6NmYy3O+9RWhrtroMzOf?= =?us-ascii?Q?3NMYnY5yDh/VV6wSTUxtc2VV9KKN6vvt7yGgKWaNJGWTc3cCXHIYtHWSvWaU?= =?us-ascii?Q?z3SZ12rTynnXdKEbwrpEw9zva6X8+h+qY/uHt4K0xoMtzIJ64wAAnVE7FeZW?= =?us-ascii?Q?Z2CTSZtEgMiCu2AgTETn2mkN0tiWt7vQhJwQKmFFtUswUEildbiJjwCKWTKH?= =?us-ascii?Q?MQUKTEm74V654kBhCgmOw0Epoiqyhui7D7Qg69YVWAVKgsmHfeo7EESgHwhv?= =?us-ascii?Q?wltLvlejVWQHAYGvOcVptSp3IbwfrtddSV9GpMRuBHQ8lpdy2ZVX//ioSv+X?= =?us-ascii?Q?J744t8On8pYuxuEDmv3MbdEDxEMiivTsw94aIHaJIHJOU5ZEplqyluVJFlwX?= =?us-ascii?Q?sBdSvL4GIxy6ZWlj+LqpCWYwCmXeND6B5SYLanGIsLqh+yp+U+/iCVpHVjxg?= =?us-ascii?Q?o5BrrI80xaZqB5ZHw5UNL/RVaruMEJRQCV9M2W2fsFoI5lFkoreK4FodQ07e?= =?us-ascii?Q?BrcQ9qeMoN2KYcskmDsY85ym4y6yn6hO3prFxVlNn9zCRm3wtAshsrGVQT80?= =?us-ascii?Q?YwDHMiyD5N/aue2ZcqaIycJCiUhFxtlinDFOw/1OjfNOdGc5q2gBOtqHyNPK?= =?us-ascii?Q?V65LpIRf9HL3+HQld8S+FFciR603FXQQ+7pht09X2dlW2qC4IIb/Ufn2n3w6?= =?us-ascii?Q?3bwUN4nYyiOxYeM8fazzKLrHB7V+aGx9Xi4ACDYdWISZJErcvJSpuqCeOfYb?= =?us-ascii?Q?wfMm4He9F9l2seHcNyyoMclW9QXvosAkFy+EKO9wmST5qhAR5O3yA2GWRwLf?= =?us-ascii?Q?jja3rdivrb3yvwtkJo3B4nx90TBBhY7DCQ3HIdKAJXWUCHB8BtDT+MFJAPez?= X-MS-Exchange-AntiSpam-MessageData-1: GwZwyq5fMdTA2w== X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7692c6a5-6791-4647-cffe-08da3fa73c4e X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9081.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 06:07:53.4450 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N1ms8cef16NqIoV8QPKUREOP0Ge9aenFV0tjeOxJTbbOQEst8shkIOB3sb2rXtkT X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6878 Received-SPF: pass client-ip=194.104.109.102; envelope-from=mchang@suse.com; helo=de-smtp-delivery-102.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2022 06:08:13 -0000 On Thu, May 26, 2022 at 05:07:11PM -0400, Robbie Harwood wrote: > Mathieu Desnoyers writes: > > > There are no users left of version_find_latest(), version_test_gt(), and > > version_test_numeric(). Remove those unused helper functions. Using > > those helper functions is what caused the quadratic sorting performance > > issues in the first place, so removing them is a net win. > > > > Signed-off-by: Mathieu Desnoyers > > Reviewed-by: Robbie Harwood Hm. This seems to contradict your proposed patch to use distro specific sort by hooking into those functions got removed here. mkconfig: use distro sorts when available https://www.mail-archive.com/grub-devel@gnu.org/msg33357.html I'd like to know more your comments about this as those hooks might still be needed or where to keep distribution's sort ? Thanks, Michael > > Be well, > --Robbie > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel