From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30836C433EF for ; Sat, 28 May 2022 00:02:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355210AbiE1ACV (ORCPT ); Fri, 27 May 2022 20:02:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235955AbiE1ACT (ORCPT ); Fri, 27 May 2022 20:02:19 -0400 Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au [211.29.132.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F0F5F122B46 for ; Fri, 27 May 2022 17:02:18 -0700 (PDT) Received: from dread.disaster.area (pa49-181-2-147.pa.nsw.optusnet.com.au [49.181.2.147]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 0817610E828D; Sat, 28 May 2022 10:02:17 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1nujuK-00HDEL-5e; Sat, 28 May 2022 10:02:16 +1000 Date: Sat, 28 May 2022 10:02:16 +1000 From: Dave Chinner To: "Matthew Wilcox (Oracle)" Cc: jfs-discussion@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, Christoph Hellwig , "Darrick J . Wong" Subject: Re: [RFC PATCH 0/9] Convert JFS to use iomap Message-ID: <20220528000216.GG3923443@dread.disaster.area> References: <20220526192910.357055-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220526192910.357055-1-willy@infradead.org> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=deDjYVbe c=1 sm=1 tr=0 ts=6291668a a=ivVLWpVy4j68lT4lJFbQgw==:117 a=ivVLWpVy4j68lT4lJFbQgw==:17 a=kj9zAlcOel0A:10 a=oZkIemNP1mAA:10 a=7-415B0cAAAA:8 a=4mSRq-6Pa5T9pFwkqfQA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, May 26, 2022 at 08:29:01PM +0100, Matthew Wilcox (Oracle) wrote: > This patchset does not work. It will eat your filesystem. Do not apply. > > The bug starts to show up with the fourth patch ("Convert direct_IO write > support to use iomap"). generic/013 creates a corrupt filesystem and > fsck fails to fix it, which shows all kinds of fun places in xfstests > where we neglect to check that 'mount' actually mounted the filesystem. > set -x or die. > > I'm hoping one of the people who knows iomap better than I do can just > point at the bug and say "Duh, it doesn't work like that". > > It's safe to say that every patch after patch 6 is untested. I'm not > convinced that I really tested patch 6 either. So the question I have to ask here is "why even bother?". JFS is a legacy filesystem, and the risk of breaking stuff or corrupting data and nobody noticing is really quite high. We recently deprecated reiserfs and scheduled it's removal because of the burden of keeping it up to date with VFS changes, what makes JFS any different in this regard? i.e. shouldn't this patchset be an indication that we should be seriously considering deprecating and removing more legacy filesystems rather than taking on the risk and burden associated with updating them to modern internal kernel interfaces? Cheers, Dave. -- Dave Chinner david@fromorbit.com