All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: "Juha Rantanen" <juha@codercoded.com>,
	"Simon Dawson" <spdawson@gmail.com>,
	"Jérôme Pouiller" <jezz@sysmic.org>,
	"Buildroot Mailing List" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1] package/pcsc-lite: needs gcc >= 4.9
Date: Sat, 28 May 2022 22:41:51 +0200	[thread overview]
Message-ID: <20220528204151.GK301044@scaer> (raw)
In-Reply-To: <CAPi7W82QOe-xNgYfUTOe7-RDtUMf=xsH-3cANXDvNRkRVL0LzA@mail.gmail.com>

Fabrice, All,

On 2022-05-28 22:23 +0200, Fabrice Fontaine spake thusly:
> Le sam. 28 mai 2022 à 21:00, Yann E. MORIN <yann.morin.1998@free.fr> a écrit :
> > On 2022-05-27 22:42 +0200, Fabrice Fontaine spake thusly:
> > > gcc >= 4.9 is needed since bump to version 1.9.6 in commit
> > > b02f13cd54912f3dffd0e0863378050104430d77 and
> > > https://github.com/LudovicRousseau/PCSC/commit/d56ed18dbebc4423506ce7f61d3e3bcf4bdc4cb0:
> > >
> > > In file included from winscard_clnt.c:123:0:
> > > readerfactory.h:101:3: error: unknown type name '_Atomic'
> > >    _Atomic DWORD dwEventStatus; /**< Recent event that must be sent */
> > >    ^
> > >
> > > Fixes:
> > >  - http://autobuild.buildroot.org/results/189f030a2252f17abf8b819feec0003815c66e79
> > >
> > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > > ---
> > [--SNIP--]
> > > index ead61e4529..3686f570a9 100644
> > > --- a/package/libnfc/Config.in
> > > +++ b/package/libnfc/Config.in
> > > @@ -13,13 +13,15 @@ config BR2_PACKAGE_LIBNFC_ACR122_PCSC
> > >       depends on BR2_TOOLCHAIN_HAS_THREADS # pcsc-lite
> > >       depends on BR2_USE_MMU # pcsc-lite
> > >       depends on !BR2_STATIC_LIBS # pcsc-lite
> > > +     depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pcsc-lite
> >
> > libnfc in turn is selected by libfreefare, libllcp, libpam-nfc, and
> > mfoc. This new gcc dependency must be propagated to those packages.
> pcsc-lite is only needed by libnfc's acr122_pcsc driver and no package
> is selecting BR2_PACKAGE_LIBNFC_ACR122_PCSC.

Indeed, my bad.

Applied to master, thanks.

Regards,
Yann E. MORIN.

> > Fortunately, none of those packages have reverse dependencies that
> > select them, so it's a one-level-deep chain.
> >
> > Can you respin, please?
> 
> As explained above, IMHO no update is needed on this patch.
> 
> >
> > Regards,
> > Yann E. MORIN.
> >
> > >       select BR2_PACKAGE_PCSC_LITE
> > >       help
> > >         support for acr112_pcsc driver
> > >
> > > -comment "acr122_pcsc driver needs a toolchain w/ threads, dynamic library"
> > > +comment "acr122_pcsc driver needs a toolchain w/ threads, dynamic library, gcc >= 4.9"
> > >       depends on BR2_USE_MMU
> > > -     depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
> > > +     depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \
> > > +             !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> > >
> > >  config BR2_PACKAGE_LIBNFC_ACR122_USB
> > >       bool "acr122_usb driver"
> > > diff --git a/package/pcsc-lite/Config.in b/package/pcsc-lite/Config.in
> > > index 1b4d0f7d18..f4ed5ba2f0 100644
> > > --- a/package/pcsc-lite/Config.in
> > > +++ b/package/pcsc-lite/Config.in
> > > @@ -3,6 +3,7 @@ config BR2_PACKAGE_PCSC_LITE
> > >       depends on BR2_TOOLCHAIN_HAS_THREADS
> > >       depends on BR2_USE_MMU # fork()
> > >       depends on !BR2_STATIC_LIBS
> > > +     depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # _Atomic keyword
> > >       help
> > >         Middleware to access smart card using SCard API (PC/SC).
> > >
> > > @@ -33,6 +34,7 @@ config BR2_PACKAGE_PCSC_LITE_EMBEDDED
> > >
> > >  endif
> > >
> > > -comment "pcsc-lite needs a toolchain w/ threads, dynamic library"
> > > +comment "pcsc-lite needs a toolchain w/ threads, dynamic library, gcc >= 4.9"
> > >       depends on BR2_USE_MMU
> > > -     depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
> > > +     depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \
> > > +             !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> > > diff --git a/package/strongswan/Config.in b/package/strongswan/Config.in
> > > index 430625a102..919ce1f5bc 100644
> > > --- a/package/strongswan/Config.in
> > > +++ b/package/strongswan/Config.in
> > > @@ -108,9 +108,13 @@ config BR2_PACKAGE_STRONGSWAN_EAP_SIM_FILE
> > >  config BR2_PACKAGE_STRONGSWAN_EAP_SIM_PCSC
> > >       bool "Enable EAP-SIM smart card backend"
> > >       depends on !BR2_STATIC_LIBS # pcsc-lite
> > > +     depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pcsc-lite
> > >       select BR2_PACKAGE_PCSC_LITE
> > >       select BR2_PACKAGE_STRONGSWAN_EAP_SIM
> > >
> > > +comment "EAP-SIM smart backend needs a toolchain w/ dynamic library, gcc >= 4.9"
> > > +     depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> > > +
> > >  config BR2_PACKAGE_STRONGSWAN_EAP_AKA
> > >       bool "Enable EAP-AKA"
> > >       default y if BR2_PACKAGE_STRONGSWAN_EAP # legacy
> > > --
> > > 2.35.1
> > >
> > > _______________________________________________
> > > buildroot mailing list
> > > buildroot@buildroot.org
> > > https://lists.buildroot.org/mailman/listinfo/buildroot
> >
> > --
> > .-----------------.--------------------.------------------.--------------------.
> > |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> > | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> > | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> > '------------------------------^-------^------------------^--------------------'
> 
> Best Regards,
> 
> Fabrice
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2022-05-28 20:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-27 20:42 [Buildroot] [PATCH 1/1] package/pcsc-lite: needs gcc >= 4.9 Fabrice Fontaine
2022-05-28 19:00 ` Yann E. MORIN
2022-05-28 20:23   ` Fabrice Fontaine
2022-05-28 20:41     ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220528204151.GK301044@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=jezz@sysmic.org \
    --cc=juha@codercoded.com \
    --cc=spdawson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.