From: Chengguang Xu <cgxu519@mykernel.net>
To: netdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-scsi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-media@vger.kernel.org
Cc: Chengguang Xu <cgxu519@mykernel.net>
Subject: [PATCH 2/6] staging: vt6655: fix missing resource cleanup in error cases
Date: Sun, 29 May 2022 23:34:52 +0800 [thread overview]
Message-ID: <20220529153456.4183738-3-cgxu519@mykernel.net> (raw)
In-Reply-To: <20220529153456.4183738-1-cgxu519@mykernel.net>
Fix missing resource cleanup(when '(--i) == 0') for error cases
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
drivers/staging/vt6655/device_main.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 897d70cf32b8..cf8d92e785e6 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -565,7 +565,7 @@ static int device_init_rd0_ring(struct vnt_private *priv)
kfree(desc->rd_info);
err_free_desc:
- while (--i) {
+ while (--i >= 0) {
desc = &priv->aRD0Ring[i];
device_free_rx_buf(priv, desc);
kfree(desc->rd_info);
@@ -611,7 +611,7 @@ static int device_init_rd1_ring(struct vnt_private *priv)
kfree(desc->rd_info);
err_free_desc:
- while (--i) {
+ while (--i >= 0) {
desc = &priv->aRD1Ring[i];
device_free_rx_buf(priv, desc);
kfree(desc->rd_info);
@@ -676,7 +676,7 @@ static int device_init_td0_ring(struct vnt_private *priv)
return 0;
err_free_desc:
- while (--i) {
+ while (--i >= 0) {
desc = &priv->apTD0Rings[i];
kfree(desc->td_info);
}
@@ -716,7 +716,7 @@ static int device_init_td1_ring(struct vnt_private *priv)
return 0;
err_free_desc:
- while (--i) {
+ while (--i >= 0) {
desc = &priv->apTD1Rings[i];
kfree(desc->td_info);
}
--
2.27.0
next prev parent reply other threads:[~2022-05-29 15:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-29 15:34 [PATCH 0/6] fix a common error of while loop condition in error path Chengguang Xu
2022-05-29 15:34 ` [PATCH 1/6] netlink: fix missing destruction of rhash table in error case Chengguang Xu
2022-05-31 8:43 ` Paolo Abeni
2022-05-31 11:25 ` Dan Carpenter
2022-06-01 7:47 ` Chengguang Xu
2022-05-29 15:34 ` Chengguang Xu [this message]
2022-05-29 15:34 ` [PATCH 3/6] scsi: ipr: fix missing/incorrect resource cleanup " Chengguang Xu
2022-06-01 12:59 ` Brian King
2022-05-29 15:34 ` [PATCH 4/6] drm/exynos: fix missing " Chengguang Xu
2022-05-29 15:34 ` [PATCH 5/6] scsi: pmcraid: " Chengguang Xu
2022-05-29 15:34 ` [PATCH 6/6] media: platform: fix missing/incorrect " Chengguang Xu
2022-05-30 8:20 ` [PATCH 0/6] fix a common error of while loop condition in error path Dan Carpenter
2022-06-08 2:27 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220529153456.4183738-3-cgxu519@mykernel.net \
--to=cgxu519@mykernel.net \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.