From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A7ECC433F5 for ; Mon, 30 May 2022 13:34:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K680/jiV2StzdefBLdi7btDO40Yk9kIX92YE/sff0Ks=; b=f1U6VEpRzocd62 MCD4cVrZoIWZCrJie15QWweYyY/mOuTeFI6TNWwZRMsI1UcZi2WwM3SDsNc83TrR4anRjSmCX7KjG Se7zvlXHU8cLlyu87LLvfVrDvoGjliwrPi3PVSCsia17WmoSx7FGPsVKOtBaBKCELEIT4rWYr3Bpe mSBrnEjry/KA7m1m7spOVwfCth9WZrBOno2+bh79Lgjy4JtDdIxedM7dnixJLgeRKKHj1f0oqUCRW VGwn11qIk7zJMwNpu8zZI/BN6TVMZzeyAbOZHK4818vGQh8l6vtaTpW4/N/BThburiEBVhL2ekiL/ 3Jl9xey/G9/oPfU4j//g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nvfX7-006koy-CA; Mon, 30 May 2022 13:34:09 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nvfT8-006iPC-R1; Mon, 30 May 2022 13:30:04 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 12EA7B80DAD; Mon, 30 May 2022 13:30:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 708C4C385B8; Mon, 30 May 2022 13:29:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653917399; bh=gxsFb/v4AB0XAGjYM+rRf9p/fUvFDHFjqtE2n2EA7VY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dtp2cyHxzOTW7RRYqRW5zKm6djNVQwZ2f+HXsPI1paSCONXgteMdjF9e7RBHs5eAp 1/zeVHB4wxpxsASNDO2CxZkPujwzctgwQ3wrc27sFYTQ+/Q529sW7KJ0nZbWmjcAHA vFPMhLLZ2rpnHeu5oHooqabKK5CBecai3mHZHYgTm1nxZLQ6azdxZrKOM+3birvxhE rUHq9aRlz1Ex2zVU7mBqqXkDHLW+5IIi2ZHWWpfhEsPM5wUAU9LKBO5yuhTCDsWz3w Ck9RyHmdHdY8rxxD1XIuciucX9yzOxzTFPRtplRL7kkg4koiP4HKjk+FhqzgcZuMFQ bkAhiPk4hmXZQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yunfei Dong , =?UTF-8?q?N=C3=ADcolas=20F=20=2E=20R=20=2E=20A=20=2E=20Prado?= , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, matthias.bgg@gmail.com, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH AUTOSEL 5.18 123/159] media: mediatek: vcodec: prevent kernel crash when rmmod mtk-vcodec-dec.ko Date: Mon, 30 May 2022 09:23:48 -0400 Message-Id: <20220530132425.1929512-123-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220530132425.1929512-1-sashal@kernel.org> References: <20220530132425.1929512-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220530_063003_212764_F65EBC0E X-CRM114-Status: GOOD ( 12.93 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org RnJvbTogWXVuZmVpIERvbmcgPHl1bmZlaS5kb25nQG1lZGlhdGVrLmNvbT4KClsgVXBzdHJlYW0g Y29tbWl0IGMxMGMwMDg2ZGI2ODhjOTViYjRlMGUzNzhlNTIzODE4ZGZmMTU1MWQgXQoKSWYgdGhl IGRyaXZlciBzdXBwb3J0IHN1YmRldiBtb2RlLCB0aGUgcGFyYW1ldGVyICJkZXYtPnBtLmRldiIg d2lsbCBiZQpOVUxMIGluIG10a192Y29kZWNfZGVjX3JlbW92ZS4gS2VybmVsIHdpbGwgY3Jhc2gg d2hlbiB0cnkgdG8gcm1tb2QKbXRrLXZjb2RlYy1kZWMua28uCgpbIDQzODAuNzAyNzI2XSBwYyA6 IGRvX3Jhd19zcGluX3RyeWxvY2srMHg0LzB4ODAKWyA0MzgwLjcwNzA3NV0gbHIgOiBfcmF3X3Nw aW5fbG9ja19pcnErMHg5MC8weDE0YwpbIDQzODAuNzExNTA5XSBzcCA6IGZmZmY4MDAwMDgxOWJj MTAKWyA0MzgwLjcxNDgxMV0geDI5OiBmZmZmODAwMDA4MTliYzEwIHgyODogZmZmZjM2MDBjMDNl NDAwMCB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAKWyA0MzgwLjcyMTkzNF0geDI2OiAwMDAwMDAwMDAw MDAwMDAwIHgyNTogMDAwMDAwMDAwMDAwMDAwMCB4MjQ6IDAwMDAwMDAwMDAwMDAwMDAKWyA0Mzgw LjcyOTA1N10geDIzOiBmZmZmMzYwMGMwZjM0OTMwIHgyMjogZmZmZmQ1ZTkyMzU0OTAwMCB4MjE6 IDAwMDAwMDAwMDAwMDAyMjAKWyA0MzgwLjczNjE3OV0geDIwOiAwMDAwMDAwMDAwMDAwMjA4IHgx OTogZmZmZmQ1ZTkyMTNlOGViYyB4MTg6IDAwMDAwMDAwMDAwMDAwMjAKWyA0MzgwLjc0MzI5OF0g eDE3OiAwMDAwMDAyMDAwMDAwMDAwIHgxNjogZmZmZmQ1ZTkyMTNlOGU5MCB4MTU6IDY5NmMzNDZm NjU2NDY5NzYKWyA0MzgwLjc1MDQyMF0geDE0OiAwMDAwMDAwMDAwMDAwMDAwIHgxMzogMDAwMDAw MDAwMDAwMDAwMSB4MTI6IDAwMDAwMDAwMDAwMDAwNDAKWyA0MzgwLjc1NzU0Ml0geDExOiAwMDAw MDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMCB4OSA6IDAwMDAwMDAwMDAwMDAwMDAK WyA0MzgwLjc2NDY2NF0geDggOiAwMDAwMDAwMDAwMDAwMDAwIHg3IDogZmZmZjM2MDBjNzI3M2Fl OCB4NiA6IGZmZmZkNWU5MjEzZThlYmMKWyA0MzgwLjc3MTc4Nl0geDUgOiAwMDAwMDAwMDAwMDAw MDAwIHg0IDogMDAwMDAwMDAwMDAwMDAwMSB4MyA6IDAwMDAwMDAwMDAwMDAwMDAKWyA0MzgwLjc3 ODkwOF0geDIgOiAwMDAwMDAwMDAwMDAwMDAwIHgxIDogZmZmZjM2MDBjMDNlNDAwMCB4MCA6IDAw MDAwMDAwMDAwMDAyMDgKWyA0MzgwLjc4NjAzMV0gQ2FsbCB0cmFjZToKWyA0MzgwLjc4ODQ2NV0g IGRvX3Jhd19zcGluX3RyeWxvY2srMHg0LzB4ODAKWyA0MzgwLjc5MjQ2Ml0gIF9fcG1fcnVudGlt ZV9kaXNhYmxlKzB4MmMvMHgxYjAKWyA0MzgwLjc5NjcyM10gIG10a192Y29kZWNfZGVjX3JlbW92 ZSsweDVjLzB4YTAgW210a192Y29kZWNfZGVjXQpbIDQzODAuODAyNDY2XSAgcGxhdGZvcm1fcmVt b3ZlKzB4MmMvMHg2MApbIDQzODAuODA2MjA0XSAgX19kZXZpY2VfcmVsZWFzZV9kcml2ZXIrMHgx OTQvMHgyNTAKWyA0MzgwLjgxMDgxMF0gIGRyaXZlcl9kZXRhY2grMHhjOC8weDE1YwpbIDQzODAu ODE0NDYyXSAgYnVzX3JlbW92ZV9kcml2ZXIrMHg1Yy8weGIwClsgNDM4MC44MTgzNzVdICBkcml2 ZXJfdW5yZWdpc3RlcisweDM0LzB4NjQKWyA0MzgwLjgyMjI4OF0gIHBsYXRmb3JtX2RyaXZlcl91 bnJlZ2lzdGVyKzB4MTgvMHgyNApbIDQzODAuODI2OTc5XSAgbXRrX3Zjb2RlY19kZWNfZHJpdmVy X2V4aXQrMHgxYy8weDg4OCBbbXRrX3Zjb2RlY19kZWNdClsgNDM4MC44MzMyNDBdICBfX2FybTY0 X3N5c19kZWxldGVfbW9kdWxlKzB4MTkwLzB4MjI0ClsgNDM4MC44MzgwMjBdICBpbnZva2Vfc3lz Y2FsbCsweDQ4LzB4MTE0ClsgNDM4MC44NDE3NjBdICBlbDBfc3ZjX2NvbW1vbi5jb25zdHByb3Au MCsweDYwLzB4MTFjClsgNDM4MC44NDY1NDBdICBkb19lbDBfc3ZjKzB4MjgvMHg5MApbIDQzODAu ODQ5ODQ0XSAgZWwwX3N2YysweDRjLzB4MTAwClsgNDM4MC44NTI5NzVdICBlbDB0XzY0X3N5bmNf aGFuZGxlcisweGVjLzB4ZjAKWyA0MzgwLjg1NzE0OF0gIGVsMHRfNjRfc3luYysweDE5MC8weDE5 NApbIDQzODAuODYwODAxXSBDb2RlOiA5NDQzMTUxNSAxN2ZmZmZjYSBkNTAzMjAxZiBkNTAzMjQ1 ZiAoYjk0MDAwMDQpCgpTaWduZWQtb2ZmLWJ5OiBZdW5mZWkgRG9uZyA8eXVuZmVpLmRvbmdAbWVk aWF0ZWsuY29tPgpUZXN0ZWQtYnk6IE7DrWNvbGFzIEYuIFIuIEEuIFByYWRvIDxuZnJhcHJhZG9A Y29sbGFib3JhLmNvbT4KU2lnbmVkLW9mZi1ieTogSGFucyBWZXJrdWlsIDxodmVya3VpbC1jaXNj b0B4czRhbGwubmw+ClNpZ25lZC1vZmYtYnk6IE1hdXJvIENhcnZhbGhvIENoZWhhYiA8bWNoZWhh YkBrZXJuZWwub3JnPgpTaWduZWQtb2ZmLWJ5OiBTYXNoYSBMZXZpbiA8c2FzaGFsQGtlcm5lbC5v cmc+Ci0tLQogZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9tZWRpYXRlay92Y29kZWMvbXRrX3Zjb2Rl Y19kZWNfZHJ2LmMgfCAzICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbWVkaWF0ZWsv dmNvZGVjL210a192Y29kZWNfZGVjX2Rydi5jIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9tZWRp YXRlay92Y29kZWMvbXRrX3Zjb2RlY19kZWNfZHJ2LmMKaW5kZXggZGY3YjI1ZTljYmM4Li4xMjhl ZGNmNTQxZTEgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbWVkaWF0ZWsvdmNv ZGVjL210a192Y29kZWNfZGVjX2Rydi5jCisrKyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbWVk aWF0ZWsvdmNvZGVjL210a192Y29kZWNfZGVjX2Rydi5jCkBAIC00ODcsNyArNDg3LDggQEAgc3Rh dGljIGludCBtdGtfdmNvZGVjX2RlY19yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRl dikKIAkJdmlkZW9fdW5yZWdpc3Rlcl9kZXZpY2UoZGV2LT52ZmRfZGVjKTsKIAogCXY0bDJfZGV2 aWNlX3VucmVnaXN0ZXIoJmRldi0+djRsMl9kZXYpOwotCXBtX3J1bnRpbWVfZGlzYWJsZShkZXYt PnBtLmRldik7CisJaWYgKCFkZXYtPnZkZWNfcGRhdGEtPmlzX3N1YmRldl9zdXBwb3J0ZWQpCisJ CXBtX3J1bnRpbWVfZGlzYWJsZShkZXYtPnBtLmRldik7CiAJbXRrX3Zjb2RlY19md19yZWxlYXNl KGRldi0+ZndfaGFuZGxlcik7CiAJcmV0dXJuIDA7CiB9Ci0tIAoyLjM1LjEKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1tZWRpYXRlayBtYWls aW5nIGxpc3QKTGludXgtbWVkaWF0ZWtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW1lZGlhdGVrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CC2DC433EF for ; Mon, 30 May 2022 13:39:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237363AbiE3NjQ (ORCPT ); Mon, 30 May 2022 09:39:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237368AbiE3Ngl (ORCPT ); Mon, 30 May 2022 09:36:41 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33D438A310; Mon, 30 May 2022 06:30:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0F51FB80DAC; Mon, 30 May 2022 13:30:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 708C4C385B8; Mon, 30 May 2022 13:29:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653917399; bh=gxsFb/v4AB0XAGjYM+rRf9p/fUvFDHFjqtE2n2EA7VY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dtp2cyHxzOTW7RRYqRW5zKm6djNVQwZ2f+HXsPI1paSCONXgteMdjF9e7RBHs5eAp 1/zeVHB4wxpxsASNDO2CxZkPujwzctgwQ3wrc27sFYTQ+/Q529sW7KJ0nZbWmjcAHA vFPMhLLZ2rpnHeu5oHooqabKK5CBecai3mHZHYgTm1nxZLQ6azdxZrKOM+3birvxhE rUHq9aRlz1Ex2zVU7mBqqXkDHLW+5IIi2ZHWWpfhEsPM5wUAU9LKBO5yuhTCDsWz3w Ck9RyHmdHdY8rxxD1XIuciucX9yzOxzTFPRtplRL7kkg4koiP4HKjk+FhqzgcZuMFQ bkAhiPk4hmXZQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yunfei Dong , =?UTF-8?q?N=C3=ADcolas=20F=20=2E=20R=20=2E=20A=20=2E=20Prado?= , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, matthias.bgg@gmail.com, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH AUTOSEL 5.18 123/159] media: mediatek: vcodec: prevent kernel crash when rmmod mtk-vcodec-dec.ko Date: Mon, 30 May 2022 09:23:48 -0400 Message-Id: <20220530132425.1929512-123-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220530132425.1929512-1-sashal@kernel.org> References: <20220530132425.1929512-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Yunfei Dong [ Upstream commit c10c0086db688c95bb4e0e378e523818dff1551d ] If the driver support subdev mode, the parameter "dev->pm.dev" will be NULL in mtk_vcodec_dec_remove. Kernel will crash when try to rmmod mtk-vcodec-dec.ko. [ 4380.702726] pc : do_raw_spin_trylock+0x4/0x80 [ 4380.707075] lr : _raw_spin_lock_irq+0x90/0x14c [ 4380.711509] sp : ffff80000819bc10 [ 4380.714811] x29: ffff80000819bc10 x28: ffff3600c03e4000 x27: 0000000000000000 [ 4380.721934] x26: 0000000000000000 x25: 0000000000000000 x24: 0000000000000000 [ 4380.729057] x23: ffff3600c0f34930 x22: ffffd5e923549000 x21: 0000000000000220 [ 4380.736179] x20: 0000000000000208 x19: ffffd5e9213e8ebc x18: 0000000000000020 [ 4380.743298] x17: 0000002000000000 x16: ffffd5e9213e8e90 x15: 696c346f65646976 [ 4380.750420] x14: 0000000000000000 x13: 0000000000000001 x12: 0000000000000040 [ 4380.757542] x11: 0000000000000000 x10: 0000000000000000 x9 : 0000000000000000 [ 4380.764664] x8 : 0000000000000000 x7 : ffff3600c7273ae8 x6 : ffffd5e9213e8ebc [ 4380.771786] x5 : 0000000000000000 x4 : 0000000000000001 x3 : 0000000000000000 [ 4380.778908] x2 : 0000000000000000 x1 : ffff3600c03e4000 x0 : 0000000000000208 [ 4380.786031] Call trace: [ 4380.788465] do_raw_spin_trylock+0x4/0x80 [ 4380.792462] __pm_runtime_disable+0x2c/0x1b0 [ 4380.796723] mtk_vcodec_dec_remove+0x5c/0xa0 [mtk_vcodec_dec] [ 4380.802466] platform_remove+0x2c/0x60 [ 4380.806204] __device_release_driver+0x194/0x250 [ 4380.810810] driver_detach+0xc8/0x15c [ 4380.814462] bus_remove_driver+0x5c/0xb0 [ 4380.818375] driver_unregister+0x34/0x64 [ 4380.822288] platform_driver_unregister+0x18/0x24 [ 4380.826979] mtk_vcodec_dec_driver_exit+0x1c/0x888 [mtk_vcodec_dec] [ 4380.833240] __arm64_sys_delete_module+0x190/0x224 [ 4380.838020] invoke_syscall+0x48/0x114 [ 4380.841760] el0_svc_common.constprop.0+0x60/0x11c [ 4380.846540] do_el0_svc+0x28/0x90 [ 4380.849844] el0_svc+0x4c/0x100 [ 4380.852975] el0t_64_sync_handler+0xec/0xf0 [ 4380.857148] el0t_64_sync+0x190/0x194 [ 4380.860801] Code: 94431515 17ffffca d503201f d503245f (b9400004) Signed-off-by: Yunfei Dong Tested-by: Nícolas F. R. A. Prado Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c index df7b25e9cbc8..128edcf541e1 100644 --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c @@ -487,7 +487,8 @@ static int mtk_vcodec_dec_remove(struct platform_device *pdev) video_unregister_device(dev->vfd_dec); v4l2_device_unregister(&dev->v4l2_dev); - pm_runtime_disable(dev->pm.dev); + if (!dev->vdec_pdata->is_subdev_supported) + pm_runtime_disable(dev->pm.dev); mtk_vcodec_fw_release(dev->fw_handler); return 0; } -- 2.35.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67B63C433F5 for ; Mon, 30 May 2022 13:34:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TFYCDVI+RpnIVX2dfNF0TLAY5gmegvH7GBZFaqIRGoA=; b=aQqqsTy3LZ3fLU OM90CLLxgZtKeiTgbDrqamZFfMEVT5JiSI4SIprqsZi5AfmpQZr9oFnc52EoxSWQHqq53UH4dM2Lo fL3gFpvFEo1mD5QGGDoCMhxU3nIhkrkcv1V9hyOf9/NftfrBrdD/GjwuIEm2mFeF/vcKdYFY7dwW6 lfBnpIrRq7UOX3Wf1jQF1kcELRkY6M5ElqbUGYW7QjHnJ6bqhejnFGUbsrOmLHEoSWbODKSSZNFMO BkqF32YdUWLZPz/QrhXmnOWmD3rkGUJzuZs42RvAzUeD048s8Qe9YkOw/I+RJLjuAVjPn3O8BGK9F ZoaNcJbCEhMxtuXoXQhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nvfVv-006k7i-28; Mon, 30 May 2022 13:32:55 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nvfT8-006iPC-R1; Mon, 30 May 2022 13:30:04 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 12EA7B80DAD; Mon, 30 May 2022 13:30:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 708C4C385B8; Mon, 30 May 2022 13:29:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653917399; bh=gxsFb/v4AB0XAGjYM+rRf9p/fUvFDHFjqtE2n2EA7VY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dtp2cyHxzOTW7RRYqRW5zKm6djNVQwZ2f+HXsPI1paSCONXgteMdjF9e7RBHs5eAp 1/zeVHB4wxpxsASNDO2CxZkPujwzctgwQ3wrc27sFYTQ+/Q529sW7KJ0nZbWmjcAHA vFPMhLLZ2rpnHeu5oHooqabKK5CBecai3mHZHYgTm1nxZLQ6azdxZrKOM+3birvxhE rUHq9aRlz1Ex2zVU7mBqqXkDHLW+5IIi2ZHWWpfhEsPM5wUAU9LKBO5yuhTCDsWz3w Ck9RyHmdHdY8rxxD1XIuciucX9yzOxzTFPRtplRL7kkg4koiP4HKjk+FhqzgcZuMFQ bkAhiPk4hmXZQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yunfei Dong , =?UTF-8?q?N=C3=ADcolas=20F=20=2E=20R=20=2E=20A=20=2E=20Prado?= , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, matthias.bgg@gmail.com, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH AUTOSEL 5.18 123/159] media: mediatek: vcodec: prevent kernel crash when rmmod mtk-vcodec-dec.ko Date: Mon, 30 May 2022 09:23:48 -0400 Message-Id: <20220530132425.1929512-123-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220530132425.1929512-1-sashal@kernel.org> References: <20220530132425.1929512-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220530_063003_212764_F65EBC0E X-CRM114-Status: GOOD ( 12.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RnJvbTogWXVuZmVpIERvbmcgPHl1bmZlaS5kb25nQG1lZGlhdGVrLmNvbT4KClsgVXBzdHJlYW0g Y29tbWl0IGMxMGMwMDg2ZGI2ODhjOTViYjRlMGUzNzhlNTIzODE4ZGZmMTU1MWQgXQoKSWYgdGhl IGRyaXZlciBzdXBwb3J0IHN1YmRldiBtb2RlLCB0aGUgcGFyYW1ldGVyICJkZXYtPnBtLmRldiIg d2lsbCBiZQpOVUxMIGluIG10a192Y29kZWNfZGVjX3JlbW92ZS4gS2VybmVsIHdpbGwgY3Jhc2gg d2hlbiB0cnkgdG8gcm1tb2QKbXRrLXZjb2RlYy1kZWMua28uCgpbIDQzODAuNzAyNzI2XSBwYyA6 IGRvX3Jhd19zcGluX3RyeWxvY2srMHg0LzB4ODAKWyA0MzgwLjcwNzA3NV0gbHIgOiBfcmF3X3Nw aW5fbG9ja19pcnErMHg5MC8weDE0YwpbIDQzODAuNzExNTA5XSBzcCA6IGZmZmY4MDAwMDgxOWJj MTAKWyA0MzgwLjcxNDgxMV0geDI5OiBmZmZmODAwMDA4MTliYzEwIHgyODogZmZmZjM2MDBjMDNl NDAwMCB4Mjc6IDAwMDAwMDAwMDAwMDAwMDAKWyA0MzgwLjcyMTkzNF0geDI2OiAwMDAwMDAwMDAw MDAwMDAwIHgyNTogMDAwMDAwMDAwMDAwMDAwMCB4MjQ6IDAwMDAwMDAwMDAwMDAwMDAKWyA0Mzgw LjcyOTA1N10geDIzOiBmZmZmMzYwMGMwZjM0OTMwIHgyMjogZmZmZmQ1ZTkyMzU0OTAwMCB4MjE6 IDAwMDAwMDAwMDAwMDAyMjAKWyA0MzgwLjczNjE3OV0geDIwOiAwMDAwMDAwMDAwMDAwMjA4IHgx OTogZmZmZmQ1ZTkyMTNlOGViYyB4MTg6IDAwMDAwMDAwMDAwMDAwMjAKWyA0MzgwLjc0MzI5OF0g eDE3OiAwMDAwMDAyMDAwMDAwMDAwIHgxNjogZmZmZmQ1ZTkyMTNlOGU5MCB4MTU6IDY5NmMzNDZm NjU2NDY5NzYKWyA0MzgwLjc1MDQyMF0geDE0OiAwMDAwMDAwMDAwMDAwMDAwIHgxMzogMDAwMDAw MDAwMDAwMDAwMSB4MTI6IDAwMDAwMDAwMDAwMDAwNDAKWyA0MzgwLjc1NzU0Ml0geDExOiAwMDAw MDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMCB4OSA6IDAwMDAwMDAwMDAwMDAwMDAK WyA0MzgwLjc2NDY2NF0geDggOiAwMDAwMDAwMDAwMDAwMDAwIHg3IDogZmZmZjM2MDBjNzI3M2Fl OCB4NiA6IGZmZmZkNWU5MjEzZThlYmMKWyA0MzgwLjc3MTc4Nl0geDUgOiAwMDAwMDAwMDAwMDAw MDAwIHg0IDogMDAwMDAwMDAwMDAwMDAwMSB4MyA6IDAwMDAwMDAwMDAwMDAwMDAKWyA0MzgwLjc3 ODkwOF0geDIgOiAwMDAwMDAwMDAwMDAwMDAwIHgxIDogZmZmZjM2MDBjMDNlNDAwMCB4MCA6IDAw MDAwMDAwMDAwMDAyMDgKWyA0MzgwLjc4NjAzMV0gQ2FsbCB0cmFjZToKWyA0MzgwLjc4ODQ2NV0g IGRvX3Jhd19zcGluX3RyeWxvY2srMHg0LzB4ODAKWyA0MzgwLjc5MjQ2Ml0gIF9fcG1fcnVudGlt ZV9kaXNhYmxlKzB4MmMvMHgxYjAKWyA0MzgwLjc5NjcyM10gIG10a192Y29kZWNfZGVjX3JlbW92 ZSsweDVjLzB4YTAgW210a192Y29kZWNfZGVjXQpbIDQzODAuODAyNDY2XSAgcGxhdGZvcm1fcmVt b3ZlKzB4MmMvMHg2MApbIDQzODAuODA2MjA0XSAgX19kZXZpY2VfcmVsZWFzZV9kcml2ZXIrMHgx OTQvMHgyNTAKWyA0MzgwLjgxMDgxMF0gIGRyaXZlcl9kZXRhY2grMHhjOC8weDE1YwpbIDQzODAu ODE0NDYyXSAgYnVzX3JlbW92ZV9kcml2ZXIrMHg1Yy8weGIwClsgNDM4MC44MTgzNzVdICBkcml2 ZXJfdW5yZWdpc3RlcisweDM0LzB4NjQKWyA0MzgwLjgyMjI4OF0gIHBsYXRmb3JtX2RyaXZlcl91 bnJlZ2lzdGVyKzB4MTgvMHgyNApbIDQzODAuODI2OTc5XSAgbXRrX3Zjb2RlY19kZWNfZHJpdmVy X2V4aXQrMHgxYy8weDg4OCBbbXRrX3Zjb2RlY19kZWNdClsgNDM4MC44MzMyNDBdICBfX2FybTY0 X3N5c19kZWxldGVfbW9kdWxlKzB4MTkwLzB4MjI0ClsgNDM4MC44MzgwMjBdICBpbnZva2Vfc3lz Y2FsbCsweDQ4LzB4MTE0ClsgNDM4MC44NDE3NjBdICBlbDBfc3ZjX2NvbW1vbi5jb25zdHByb3Au MCsweDYwLzB4MTFjClsgNDM4MC44NDY1NDBdICBkb19lbDBfc3ZjKzB4MjgvMHg5MApbIDQzODAu ODQ5ODQ0XSAgZWwwX3N2YysweDRjLzB4MTAwClsgNDM4MC44NTI5NzVdICBlbDB0XzY0X3N5bmNf aGFuZGxlcisweGVjLzB4ZjAKWyA0MzgwLjg1NzE0OF0gIGVsMHRfNjRfc3luYysweDE5MC8weDE5 NApbIDQzODAuODYwODAxXSBDb2RlOiA5NDQzMTUxNSAxN2ZmZmZjYSBkNTAzMjAxZiBkNTAzMjQ1 ZiAoYjk0MDAwMDQpCgpTaWduZWQtb2ZmLWJ5OiBZdW5mZWkgRG9uZyA8eXVuZmVpLmRvbmdAbWVk aWF0ZWsuY29tPgpUZXN0ZWQtYnk6IE7DrWNvbGFzIEYuIFIuIEEuIFByYWRvIDxuZnJhcHJhZG9A Y29sbGFib3JhLmNvbT4KU2lnbmVkLW9mZi1ieTogSGFucyBWZXJrdWlsIDxodmVya3VpbC1jaXNj b0B4czRhbGwubmw+ClNpZ25lZC1vZmYtYnk6IE1hdXJvIENhcnZhbGhvIENoZWhhYiA8bWNoZWhh YkBrZXJuZWwub3JnPgpTaWduZWQtb2ZmLWJ5OiBTYXNoYSBMZXZpbiA8c2FzaGFsQGtlcm5lbC5v cmc+Ci0tLQogZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9tZWRpYXRlay92Y29kZWMvbXRrX3Zjb2Rl Y19kZWNfZHJ2LmMgfCAzICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbWVkaWF0ZWsv dmNvZGVjL210a192Y29kZWNfZGVjX2Rydi5jIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9tZWRp YXRlay92Y29kZWMvbXRrX3Zjb2RlY19kZWNfZHJ2LmMKaW5kZXggZGY3YjI1ZTljYmM4Li4xMjhl ZGNmNTQxZTEgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbWVkaWF0ZWsvdmNv ZGVjL210a192Y29kZWNfZGVjX2Rydi5jCisrKyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbWVk aWF0ZWsvdmNvZGVjL210a192Y29kZWNfZGVjX2Rydi5jCkBAIC00ODcsNyArNDg3LDggQEAgc3Rh dGljIGludCBtdGtfdmNvZGVjX2RlY19yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRl dikKIAkJdmlkZW9fdW5yZWdpc3Rlcl9kZXZpY2UoZGV2LT52ZmRfZGVjKTsKIAogCXY0bDJfZGV2 aWNlX3VucmVnaXN0ZXIoJmRldi0+djRsMl9kZXYpOwotCXBtX3J1bnRpbWVfZGlzYWJsZShkZXYt PnBtLmRldik7CisJaWYgKCFkZXYtPnZkZWNfcGRhdGEtPmlzX3N1YmRldl9zdXBwb3J0ZWQpCisJ CXBtX3J1bnRpbWVfZGlzYWJsZShkZXYtPnBtLmRldik7CiAJbXRrX3Zjb2RlY19md19yZWxlYXNl KGRldi0+ZndfaGFuZGxlcik7CiAJcmV0dXJuIDA7CiB9Ci0tIAoyLjM1LjEKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==