All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: dsahern@gmail.com
Cc: netdev@vger.kernel.org, maximmi@nvidia.com,
	stephen@networkplumber.org, tariqt@nvidia.com,
	Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH iproute2-next v2] ss: Shorter display format for TLS zerocopy sendfile
Date: Wed,  1 Jun 2022 16:42:49 -0700	[thread overview]
Message-ID: <20220601234249.244701-1-kuba@kernel.org> (raw)
In-Reply-To: <20220601122343.2451706-1-maximmi@nvidia.com>

Commit 21c07b45688f ("ss: Show zerocopy sendfile status of TLS
sockets") used "key: value" format for the sendfile read-only
optimization. Move to a more appropriate "flag" display format.
Rename the flag to something based on the assumption it allows
the kernel to make. Avoid "salesman speak", the term "zero-copy"
is particularly confusing in TLS where we call decrypt/encrypt
directly from user space a zero-copy as well.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 misc/ss.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/misc/ss.c b/misc/ss.c
index c4434a20bcfe..ac678c296006 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -2988,7 +2988,8 @@ static void tcp_tls_conf(const char *name, struct rtattr *attr)
 
 static void tcp_tls_zc_sendfile(struct rtattr *attr)
 {
-	out(" zerocopy_sendfile: %s", attr ? "active" : "inactive");
+	if (attr)
+		out(" sendfile_ro");
 }
 
 static void mptcp_subflow_info(struct rtattr *tb[])
-- 
2.36.1


  reply	other threads:[~2022-06-01 23:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-01 12:23 [PATCH iproute2-next] ss: Shorter display format for TLS zerocopy sendfile Maxim Mikityanskiy
2022-06-01 23:42 ` Jakub Kicinski [this message]
2022-06-02  9:13   ` [PATCH iproute2-next v2] " Maxim Mikityanskiy
2022-06-02 16:44     ` Jakub Kicinski
2022-06-03 13:47       ` Maxim Mikityanskiy
2022-06-03 15:51         ` Jakub Kicinski
2022-06-06 11:29           ` Maxim Mikityanskiy
2022-06-06 15:45             ` Stephen Hemminger
2022-06-06 17:59             ` Jakub Kicinski
2022-06-07 10:35               ` Maxim Mikityanskiy
2022-06-07 17:30                 ` Jakub Kicinski
2022-06-07 21:08                   ` Stephen Hemminger
2022-06-08 10:04                   ` Maxim Mikityanskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220601234249.244701-1-kuba@kernel.org \
    --to=kuba@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=maximmi@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.