All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>, rafael@kernel.org
Cc: kbuild-all@lists.01.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, quic_manafm@quicinc.com,
	Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH 2/3] thermal/debugfs: Add debugfs information
Date: Thu, 2 Jun 2022 06:55:01 +0800	[thread overview]
Message-ID: <202206020607.DHohHTFP-lkp@intel.com> (raw)
In-Reply-To: <20220601151441.9128-2-daniel.lezcano@linaro.org>

Hi Daniel,

I love your patch! Yet something to improve:

[auto build test ERROR on rafael-pm/thermal]
[also build test ERROR on v5.18 next-20220601]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Daniel-Lezcano/thermal-core-Encapsulate-the-set_cur_state-function/20220601-231733
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
config: x86_64-randconfig-a011 (https://download.01.org/0day-ci/archive/20220602/202206020607.DHohHTFP-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/04c295f7e8b49af742179609949736f6f056b49c
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Daniel-Lezcano/thermal-core-Encapsulate-the-set_cur_state-function/20220601-231733
        git checkout 04c295f7e8b49af742179609949736f6f056b49c
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: drivers/thermal/thermal_core.o: in function `thermal_init':
>> drivers/thermal/thermal_core.c:1496: undefined reference to `thermal_debugfs_init'


vim +1496 drivers/thermal/thermal_core.c

  1470	
  1471	static int __init thermal_init(void)
  1472	{
  1473		int result;
  1474	
  1475		result = thermal_netlink_init();
  1476		if (result)
  1477			goto error;
  1478	
  1479		result = thermal_register_governors();
  1480		if (result)
  1481			goto error;
  1482	
  1483		result = class_register(&thermal_class);
  1484		if (result)
  1485			goto unregister_governors;
  1486	
  1487		result = of_parse_thermal_zones();
  1488		if (result)
  1489			goto unregister_class;
  1490	
  1491		result = register_pm_notifier(&thermal_pm_nb);
  1492		if (result)
  1493			pr_warn("Thermal: Can not register suspend notifier, return %d\n",
  1494				result);
  1495	
> 1496		thermal_debugfs_init();

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

  reply	other threads:[~2022-06-01 22:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-01 15:14 [PATCH 1/3] thermal/core: Encapsulate the set_cur_state function Daniel Lezcano
2022-06-01 15:14 ` [PATCH 2/3] thermal/debugfs: Add debugfs information Daniel Lezcano
2022-06-01 22:55   ` kernel test robot [this message]
2022-06-02  0:39   ` kernel test robot
2022-06-02 20:20   ` kernel test robot
2022-06-01 15:14 ` [PATCH 3/3] thermal/sysfs: Remove cooling device sysfs statistics Daniel Lezcano
2022-06-01 15:33   ` Lukasz Luba
2022-06-02  8:37     ` Daniel Lezcano
2022-06-02  9:16       ` Lukasz Luba
2022-06-02 19:02         ` Todd Kjos
2022-06-03 11:04           ` Daniel Lezcano
2022-06-24  6:02             ` Wei Wang
2022-06-28 15:26               ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202206020607.DHohHTFP-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=amitk@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=quic_manafm@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.