From: Stephen Hemminger <stephen@networkplumber.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] net-sysfs: allow changing sysfs carrier when interface is down
Date: Thu, 2 Jun 2022 11:14:01 -0700 [thread overview]
Message-ID: <20220602111401.31bcbe35@hermes.local> (raw)
In-Reply-To: <20220602105215.12aff895@kernel.org>
On Thu, 2 Jun 2022 10:52:15 -0700
Jakub Kicinski <kuba@kernel.org> wrote:
> On Thu, 2 Jun 2022 17:15:13 +0000 Joakim Tjernlund wrote:
> > > What is "our HW", what kernel driver does it use and why can't the
> > > kernel driver take care of making sure the device is not accessed
> > > when it'd crash the system?
> >
> > It is a custom asic with some homegrown controller. The full config path is too complex for kernel too
> > know and depends on user input.
>
> We have a long standing tradition of not caring about user space
> drivers in netdev land. I see no reason to merge this patch upstream.
>
> > > > Maybe so but it seems to me that this limitation was put in place without much thought.
> > >
> > > Don't make unnecessary disparaging statements about someone else's work.
> > > Whoever that person was.
> >
> > That was not meant the way you read it, sorry for being unclear.
> > The commit from 2012 simply says:
> > net: allow to change carrier via sysfs
> >
> > Make carrier writable
>
> Yeah, IIUC the interface was created for software devices.
If you want to discussion of original patch see:
https://patchwork.ozlabs.org/project/netdev/patch/1314715608-978-2-git-send-email-jpirko@redhat.com/
PS: if you have lots of userspace handling, you should be using netlink not sysfs for management
next prev parent reply other threads:[~2022-06-02 18:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 0:35 [PATCH] net-sysfs: allow changing sysfs carrier when interface is down Joakim Tjernlund
2022-06-02 1:01 ` Jakub Kicinski
2022-06-02 9:22 ` Joakim Tjernlund
2022-06-02 15:56 ` Stephen Hemminger
2022-06-02 16:26 ` Joakim Tjernlund
2022-06-02 16:57 ` Jakub Kicinski
2022-06-02 17:15 ` Joakim Tjernlund
2022-06-02 17:52 ` Jakub Kicinski
2022-06-02 18:01 ` Joakim Tjernlund
2022-06-05 18:50 ` Andrew Lunn
2022-06-07 11:52 ` Joakim Tjernlund
2022-06-02 18:14 ` Stephen Hemminger [this message]
2022-06-02 17:56 ` Stephen Hemminger
2022-06-02 18:09 ` Joakim Tjernlund
2022-06-02 18:38 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220602111401.31bcbe35@hermes.local \
--to=stephen@networkplumber.org \
--cc=Joakim.Tjernlund@infinera.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.