From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68DEEC43334 for ; Thu, 2 Jun 2022 22:06:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id DEB8283E6D; Thu, 2 Jun 2022 22:06:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z0f7Tjrl0Q6p; Thu, 2 Jun 2022 22:06:44 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 60CF883E52; Thu, 2 Jun 2022 22:06:43 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1FFEEC0032; Thu, 2 Jun 2022 22:06:43 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id B5CC7C002D for ; Thu, 2 Jun 2022 22:06:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 9E67F405C1 for ; Thu, 2 Jun 2022 22:06:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=intel.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vsfzwM0eFYXN for ; Thu, 2 Jun 2022 22:06:40 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by smtp2.osuosl.org (Postfix) with ESMTPS id 4378E40120 for ; Thu, 2 Jun 2022 22:06:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654207600; x=1685743600; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=AKU2IG+YtECdmg0JbSDlVYGZXgmDcaF6I/51w4mVsVM=; b=MQJZj00nnrRbudpbWhUFI70RheJtkd/fMqNwstR5BYkZtGvxGN3Hd4y/ Wy21gtVU3GSWi31jxPQbjjs3udmrJb8Q5vuCwC+lWAK0L3UnJt+er9+MB RsqTlxndYFhAxCIHZKKff/lZnRMN+i67GUWXsSKjXiTT2JYwLD2K5hs+i UIXAixRq7YMO/XU6xdW/KrN8JZFDtjprxcpOtmvNL9f4fq76Y0zrIVjOn HNEiTA6GepLCm5BS0JMfSMRmuf/cVx81FL9bPhVUuAOkDplJbwnkeepX0 p1hZ+dxa9qQXHr/6n6GoGDsXIq9DIpCj0+fWwc7ObB3mlJSuf5KowugrY Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10366"; a="273660195" X-IronPort-AV: E=Sophos;i="5.91,272,1647327600"; d="scan'208";a="273660195" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2022 15:05:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,272,1647327600"; d="scan'208";a="553049411" Received: from lkp-server01.sh.intel.com (HELO 60dabacc1df6) ([10.239.97.150]) by orsmga006.jf.intel.com with ESMTP; 02 Jun 2022 15:05:53 -0700 Received: from kbuild by 60dabacc1df6 with local (Exim 4.95) (envelope-from ) id 1nwswy-0005Tw-Fl; Thu, 02 Jun 2022 22:05:52 +0000 Date: Fri, 3 Jun 2022 06:05:15 +0800 From: kernel test robot To: Zack Rusin , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 3/6] drm/qxl: Create mouse hotspot properties on cursor planes Message-ID: <202206030624.TdMaRYS5-lkp@intel.com> References: <20220602154243.1015688-4-zack@kde.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220602154243.1015688-4-zack@kde.org> Cc: kbuild-all@lists.01.org, virtualization@lists.linux-foundation.org, krastevm@vmware.com, Dave Airlie , spice-devel@lists.freedesktop.org, mombasawalam@vmware.com X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" Hi Zack, I love your patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-tip/drm-tip v5.18 next-20220602] [cannot apply to airlied/drm-next tegra-drm/drm/tegra/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Zack-Rusin/drm-Add-mouse-cursor-hotspot-support-to-atomic-KMS/20220602-234633 base: git://anongit.freedesktop.org/drm/drm drm-next config: x86_64-randconfig-a011 (https://download.01.org/0day-ci/archive/20220603/202206030624.TdMaRYS5-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-1) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/0bf2395ee17bd25ae6411c560de883496256195d git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Zack-Rusin/drm-Add-mouse-cursor-hotspot-support-to-atomic-KMS/20220602-234633 git checkout 0bf2395ee17bd25ae6411c560de883496256195d # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/qxl/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/gpu/drm/qxl/qxl_display.c: In function 'qxl_primary_apply_cursor': >> drivers/gpu/drm/qxl/qxl_display.c:486:33: warning: unused variable 'fb' [-Wunused-variable] 486 | struct drm_framebuffer *fb = plane_state->fb; | ^~ drivers/gpu/drm/qxl/qxl_display.c: In function 'qxl_primary_move_cursor': drivers/gpu/drm/qxl/qxl_display.c:532:33: warning: unused variable 'fb' [-Wunused-variable] 532 | struct drm_framebuffer *fb = plane_state->fb; | ^~ vim +/fb +486 drivers/gpu/drm/qxl/qxl_display.c c2ff663260fee3 Gabriel Krisman Bertazi 2017-02-27 482 b4b27f08f9f96d Gerd Hoffmann 2021-02-17 483 static int qxl_primary_apply_cursor(struct qxl_device *qdev, b4b27f08f9f96d Gerd Hoffmann 2021-02-17 484 struct drm_plane_state *plane_state) 9428088c90b6f7 Ray Strode 2017-11-27 485 { b4b27f08f9f96d Gerd Hoffmann 2021-02-17 @486 struct drm_framebuffer *fb = plane_state->fb; b4b27f08f9f96d Gerd Hoffmann 2021-02-17 487 struct qxl_crtc *qcrtc = to_qxl_crtc(plane_state->crtc); 9428088c90b6f7 Ray Strode 2017-11-27 488 struct qxl_cursor_cmd *cmd; 9428088c90b6f7 Ray Strode 2017-11-27 489 struct qxl_release *release; 9428088c90b6f7 Ray Strode 2017-11-27 490 int ret = 0; 9428088c90b6f7 Ray Strode 2017-11-27 491 9428088c90b6f7 Ray Strode 2017-11-27 492 if (!qcrtc->cursor_bo) 9428088c90b6f7 Ray Strode 2017-11-27 493 return 0; 9428088c90b6f7 Ray Strode 2017-11-27 494 9428088c90b6f7 Ray Strode 2017-11-27 495 ret = qxl_alloc_release_reserved(qdev, sizeof(*cmd), 9428088c90b6f7 Ray Strode 2017-11-27 496 QXL_RELEASE_CURSOR_CMD, 9428088c90b6f7 Ray Strode 2017-11-27 497 &release, NULL); 9428088c90b6f7 Ray Strode 2017-11-27 498 if (ret) 9428088c90b6f7 Ray Strode 2017-11-27 499 return ret; 9428088c90b6f7 Ray Strode 2017-11-27 500 9428088c90b6f7 Ray Strode 2017-11-27 501 ret = qxl_release_list_add(release, qcrtc->cursor_bo); 9428088c90b6f7 Ray Strode 2017-11-27 502 if (ret) 9428088c90b6f7 Ray Strode 2017-11-27 503 goto out_free_release; 9428088c90b6f7 Ray Strode 2017-11-27 504 9428088c90b6f7 Ray Strode 2017-11-27 505 ret = qxl_release_reserve_list(release, false); 9428088c90b6f7 Ray Strode 2017-11-27 506 if (ret) 9428088c90b6f7 Ray Strode 2017-11-27 507 goto out_free_release; 9428088c90b6f7 Ray Strode 2017-11-27 508 9428088c90b6f7 Ray Strode 2017-11-27 509 cmd = (struct qxl_cursor_cmd *)qxl_release_map(qdev, release); 9428088c90b6f7 Ray Strode 2017-11-27 510 cmd->type = QXL_CURSOR_SET; 0bf2395ee17bd2 Zack Rusin 2022-06-02 511 cmd->u.set.position.x = plane_state->crtc_x + plane_state->hotspot_x; 0bf2395ee17bd2 Zack Rusin 2022-06-02 512 cmd->u.set.position.y = plane_state->crtc_y + plane_state->hotspot_y; 9428088c90b6f7 Ray Strode 2017-11-27 513 9428088c90b6f7 Ray Strode 2017-11-27 514 cmd->u.set.shape = qxl_bo_physical_address(qdev, qcrtc->cursor_bo, 0); 9428088c90b6f7 Ray Strode 2017-11-27 515 9428088c90b6f7 Ray Strode 2017-11-27 516 cmd->u.set.visible = 1; 9428088c90b6f7 Ray Strode 2017-11-27 517 qxl_release_unmap(qdev, release, &cmd->release_info); 9428088c90b6f7 Ray Strode 2017-11-27 518 9428088c90b6f7 Ray Strode 2017-11-27 519 qxl_release_fence_buffer_objects(release); 933db73351d359 Vasily Averin 2020-04-29 520 qxl_push_cursor_ring_release(qdev, release, QXL_CMD_CURSOR, false); 9428088c90b6f7 Ray Strode 2017-11-27 521 9428088c90b6f7 Ray Strode 2017-11-27 522 return ret; 9428088c90b6f7 Ray Strode 2017-11-27 523 9428088c90b6f7 Ray Strode 2017-11-27 524 out_free_release: 9428088c90b6f7 Ray Strode 2017-11-27 525 qxl_release_free(qdev, release); 9428088c90b6f7 Ray Strode 2017-11-27 526 return ret; 9428088c90b6f7 Ray Strode 2017-11-27 527 } 9428088c90b6f7 Ray Strode 2017-11-27 528 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DCC9C433EF for ; Thu, 2 Jun 2022 22:06:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1AECE10F9BB; Thu, 2 Jun 2022 22:06:05 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7D3BE10F9BB; Thu, 2 Jun 2022 22:06:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654207563; x=1685743563; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=AKU2IG+YtECdmg0JbSDlVYGZXgmDcaF6I/51w4mVsVM=; b=Z9DEdE2adRjxqO52Yf5ivZniSLphLTgH23gw3g020GLPpXJUX5z6qdg7 HXJ21Hn8k01vFX6lzrSnQ4Fn+umWF03fyYkS/HYbZU+/8EiISSaGi5lYT w4kOZlHDNyZtAZSsKZbLweHpwGqxKPOe6AEaP9a+tEpUlCFG0mAgm56+F u7BnY7MNvYATtwUpCsEuZf1+M+7jsgzOvgdatQk0akiQHpg4X7Rcz8HXS TMOOp3nyBSnjp8C7USryPX9CNBxiTUbHOD1NFkPAYTqUT4Z3RZuWNYKv7 aUr8b24Wq4k7xeACi2zd7/ooA20les17QWUw80gj2bWG8DpJAI7v52hDt Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10366"; a="339140038" X-IronPort-AV: E=Sophos;i="5.91,272,1647327600"; d="scan'208";a="339140038" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2022 15:05:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,272,1647327600"; d="scan'208";a="553049411" Received: from lkp-server01.sh.intel.com (HELO 60dabacc1df6) ([10.239.97.150]) by orsmga006.jf.intel.com with ESMTP; 02 Jun 2022 15:05:53 -0700 Received: from kbuild by 60dabacc1df6 with local (Exim 4.95) (envelope-from ) id 1nwswy-0005Tw-Fl; Thu, 02 Jun 2022 22:05:52 +0000 Date: Fri, 3 Jun 2022 06:05:15 +0800 From: kernel test robot To: Zack Rusin , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 3/6] drm/qxl: Create mouse hotspot properties on cursor planes Message-ID: <202206030624.TdMaRYS5-lkp@intel.com> References: <20220602154243.1015688-4-zack@kde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220602154243.1015688-4-zack@kde.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kbuild-all@lists.01.org, virtualization@lists.linux-foundation.org, krastevm@vmware.com, Gerd Hoffmann , Dave Airlie , spice-devel@lists.freedesktop.org, mombasawalam@vmware.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Zack, I love your patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-tip/drm-tip v5.18 next-20220602] [cannot apply to airlied/drm-next tegra-drm/drm/tegra/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Zack-Rusin/drm-Add-mouse-cursor-hotspot-support-to-atomic-KMS/20220602-234633 base: git://anongit.freedesktop.org/drm/drm drm-next config: x86_64-randconfig-a011 (https://download.01.org/0day-ci/archive/20220603/202206030624.TdMaRYS5-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-1) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/0bf2395ee17bd25ae6411c560de883496256195d git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Zack-Rusin/drm-Add-mouse-cursor-hotspot-support-to-atomic-KMS/20220602-234633 git checkout 0bf2395ee17bd25ae6411c560de883496256195d # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/qxl/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/gpu/drm/qxl/qxl_display.c: In function 'qxl_primary_apply_cursor': >> drivers/gpu/drm/qxl/qxl_display.c:486:33: warning: unused variable 'fb' [-Wunused-variable] 486 | struct drm_framebuffer *fb = plane_state->fb; | ^~ drivers/gpu/drm/qxl/qxl_display.c: In function 'qxl_primary_move_cursor': drivers/gpu/drm/qxl/qxl_display.c:532:33: warning: unused variable 'fb' [-Wunused-variable] 532 | struct drm_framebuffer *fb = plane_state->fb; | ^~ vim +/fb +486 drivers/gpu/drm/qxl/qxl_display.c c2ff663260fee3 Gabriel Krisman Bertazi 2017-02-27 482 b4b27f08f9f96d Gerd Hoffmann 2021-02-17 483 static int qxl_primary_apply_cursor(struct qxl_device *qdev, b4b27f08f9f96d Gerd Hoffmann 2021-02-17 484 struct drm_plane_state *plane_state) 9428088c90b6f7 Ray Strode 2017-11-27 485 { b4b27f08f9f96d Gerd Hoffmann 2021-02-17 @486 struct drm_framebuffer *fb = plane_state->fb; b4b27f08f9f96d Gerd Hoffmann 2021-02-17 487 struct qxl_crtc *qcrtc = to_qxl_crtc(plane_state->crtc); 9428088c90b6f7 Ray Strode 2017-11-27 488 struct qxl_cursor_cmd *cmd; 9428088c90b6f7 Ray Strode 2017-11-27 489 struct qxl_release *release; 9428088c90b6f7 Ray Strode 2017-11-27 490 int ret = 0; 9428088c90b6f7 Ray Strode 2017-11-27 491 9428088c90b6f7 Ray Strode 2017-11-27 492 if (!qcrtc->cursor_bo) 9428088c90b6f7 Ray Strode 2017-11-27 493 return 0; 9428088c90b6f7 Ray Strode 2017-11-27 494 9428088c90b6f7 Ray Strode 2017-11-27 495 ret = qxl_alloc_release_reserved(qdev, sizeof(*cmd), 9428088c90b6f7 Ray Strode 2017-11-27 496 QXL_RELEASE_CURSOR_CMD, 9428088c90b6f7 Ray Strode 2017-11-27 497 &release, NULL); 9428088c90b6f7 Ray Strode 2017-11-27 498 if (ret) 9428088c90b6f7 Ray Strode 2017-11-27 499 return ret; 9428088c90b6f7 Ray Strode 2017-11-27 500 9428088c90b6f7 Ray Strode 2017-11-27 501 ret = qxl_release_list_add(release, qcrtc->cursor_bo); 9428088c90b6f7 Ray Strode 2017-11-27 502 if (ret) 9428088c90b6f7 Ray Strode 2017-11-27 503 goto out_free_release; 9428088c90b6f7 Ray Strode 2017-11-27 504 9428088c90b6f7 Ray Strode 2017-11-27 505 ret = qxl_release_reserve_list(release, false); 9428088c90b6f7 Ray Strode 2017-11-27 506 if (ret) 9428088c90b6f7 Ray Strode 2017-11-27 507 goto out_free_release; 9428088c90b6f7 Ray Strode 2017-11-27 508 9428088c90b6f7 Ray Strode 2017-11-27 509 cmd = (struct qxl_cursor_cmd *)qxl_release_map(qdev, release); 9428088c90b6f7 Ray Strode 2017-11-27 510 cmd->type = QXL_CURSOR_SET; 0bf2395ee17bd2 Zack Rusin 2022-06-02 511 cmd->u.set.position.x = plane_state->crtc_x + plane_state->hotspot_x; 0bf2395ee17bd2 Zack Rusin 2022-06-02 512 cmd->u.set.position.y = plane_state->crtc_y + plane_state->hotspot_y; 9428088c90b6f7 Ray Strode 2017-11-27 513 9428088c90b6f7 Ray Strode 2017-11-27 514 cmd->u.set.shape = qxl_bo_physical_address(qdev, qcrtc->cursor_bo, 0); 9428088c90b6f7 Ray Strode 2017-11-27 515 9428088c90b6f7 Ray Strode 2017-11-27 516 cmd->u.set.visible = 1; 9428088c90b6f7 Ray Strode 2017-11-27 517 qxl_release_unmap(qdev, release, &cmd->release_info); 9428088c90b6f7 Ray Strode 2017-11-27 518 9428088c90b6f7 Ray Strode 2017-11-27 519 qxl_release_fence_buffer_objects(release); 933db73351d359 Vasily Averin 2020-04-29 520 qxl_push_cursor_ring_release(qdev, release, QXL_CMD_CURSOR, false); 9428088c90b6f7 Ray Strode 2017-11-27 521 9428088c90b6f7 Ray Strode 2017-11-27 522 return ret; 9428088c90b6f7 Ray Strode 2017-11-27 523 9428088c90b6f7 Ray Strode 2017-11-27 524 out_free_release: 9428088c90b6f7 Ray Strode 2017-11-27 525 qxl_release_free(qdev, release); 9428088c90b6f7 Ray Strode 2017-11-27 526 return ret; 9428088c90b6f7 Ray Strode 2017-11-27 527 } 9428088c90b6f7 Ray Strode 2017-11-27 528 -- 0-DAY CI Kernel Test Service https://01.org/lkp