All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Julien Grall <julien.grall@arm.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	Marc Zyngier <maz@kernel.org>,
	Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Subject: arch/arm64/kvm/vmid.c:62 flush_context() warn: inconsistent indenting
Date: Sat, 4 Jun 2022 23:20:39 +0800	[thread overview]
Message-ID: <202206042312.ffdERGjt-lkp@intel.com> (raw)

Hi Julien,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   032dcf09e2bf7c822be25b4abef7a6c913870d98
commit: 3248136b3637e1671e4fa46e32e2122f9ec4bc3d KVM: arm64: Align the VMID allocation with the arm64 ASID
date:   4 months ago
config: arm64-randconfig-m031-20220530 (https://download.01.org/0day-ci/archive/20220604/202206042312.ffdERGjt-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

smatch warnings:
arch/arm64/kvm/vmid.c:62 flush_context() warn: inconsistent indenting

vim +62 arch/arm64/kvm/vmid.c

417838392f2e65 Shameer Kolothum 2021-11-22  34  
417838392f2e65 Shameer Kolothum 2021-11-22  35  #define vmid_gen_match(vmid) \
417838392f2e65 Shameer Kolothum 2021-11-22  36  	(!(((vmid) ^ atomic64_read(&vmid_generation)) >> kvm_arm_vmid_bits))
417838392f2e65 Shameer Kolothum 2021-11-22  37  
417838392f2e65 Shameer Kolothum 2021-11-22  38  static void flush_context(void)
417838392f2e65 Shameer Kolothum 2021-11-22  39  {
417838392f2e65 Shameer Kolothum 2021-11-22  40  	int cpu;
417838392f2e65 Shameer Kolothum 2021-11-22  41  	u64 vmid;
417838392f2e65 Shameer Kolothum 2021-11-22  42  
417838392f2e65 Shameer Kolothum 2021-11-22  43  	bitmap_clear(vmid_map, 0, NUM_USER_VMIDS);
417838392f2e65 Shameer Kolothum 2021-11-22  44  
417838392f2e65 Shameer Kolothum 2021-11-22  45  	for_each_possible_cpu(cpu) {
417838392f2e65 Shameer Kolothum 2021-11-22  46  		vmid = atomic64_xchg_relaxed(&per_cpu(active_vmids, cpu), 0);
417838392f2e65 Shameer Kolothum 2021-11-22  47  
417838392f2e65 Shameer Kolothum 2021-11-22  48  		/* Preserve reserved VMID */
417838392f2e65 Shameer Kolothum 2021-11-22  49  		if (vmid == 0)
417838392f2e65 Shameer Kolothum 2021-11-22  50  			vmid = per_cpu(reserved_vmids, cpu);
417838392f2e65 Shameer Kolothum 2021-11-22  51  		__set_bit(vmid2idx(vmid), vmid_map);
417838392f2e65 Shameer Kolothum 2021-11-22  52  		per_cpu(reserved_vmids, cpu) = vmid;
417838392f2e65 Shameer Kolothum 2021-11-22  53  	}
417838392f2e65 Shameer Kolothum 2021-11-22  54  
417838392f2e65 Shameer Kolothum 2021-11-22  55  	/*
417838392f2e65 Shameer Kolothum 2021-11-22  56  	 * Unlike ASID allocator, we expect less frequent rollover in
417838392f2e65 Shameer Kolothum 2021-11-22  57  	 * case of VMIDs. Hence, instead of marking the CPU as
417838392f2e65 Shameer Kolothum 2021-11-22  58  	 * flush_pending and issuing a local context invalidation on
417838392f2e65 Shameer Kolothum 2021-11-22  59  	 * the next context-switch, we broadcast TLB flush + I-cache
417838392f2e65 Shameer Kolothum 2021-11-22  60  	 * invalidation over the inner shareable domain on rollover.
417838392f2e65 Shameer Kolothum 2021-11-22  61  	 */
417838392f2e65 Shameer Kolothum 2021-11-22 @62  	 kvm_call_hyp(__kvm_flush_vm_context);
417838392f2e65 Shameer Kolothum 2021-11-22  63  }
417838392f2e65 Shameer Kolothum 2021-11-22  64  

:::::: The code at line 62 was first introduced by commit
:::::: 417838392f2e657ee25cc30e373ff4c35a0faa90 KVM: arm64: Introduce a new VMID allocator for KVM

:::::: TO: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
:::::: CC: Marc Zyngier <maz@kernel.org>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

             reply	other threads:[~2022-06-04 15:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-04 15:20 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-06-02  0:18 arch/arm64/kvm/vmid.c:62 flush_context() warn: inconsistent indenting kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202206042312.ffdERGjt-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=julien.grall@arm.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=shameerali.kolothum.thodi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.