From: Baoquan He <bhe@redhat.com>
To: akpm@linux-foundation.org
Cc: npiggin@gmail.com, urezki@gmail.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Baoquan He <bhe@redhat.com>
Subject: [PATCH 2/5] mm/vmalloc: remove the redundant boundary check
Date: Mon, 6 Jun 2022 16:39:06 +0800 [thread overview]
Message-ID: <20220606083909.363350-3-bhe@redhat.com> (raw)
In-Reply-To: <20220606083909.363350-1-bhe@redhat.com>
In function find_va_links(), when traversing the vmap_area tree, the
comparing to check if the passed in 'va' is above or below 'tmp_va'
is redundant, assuming both 'va' and 'tmp_va' has ->va_start <= ->va_end.
Here, to simplify the checking as code change.
Signed-off-by: Baoquan He <bhe@redhat.com>
---
mm/vmalloc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index b7a138ab7b79..c7e1634ff2b9 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -874,11 +874,9 @@ find_va_links(struct vmap_area *va,
* Trigger the BUG() if there are sides(left/right)
* or full overlaps.
*/
- if (va->va_start < tmp_va->va_end &&
- va->va_end <= tmp_va->va_start)
+ if (va->va_end <= tmp_va->va_start)
link = &(*link)->rb_left;
- else if (va->va_end > tmp_va->va_start &&
- va->va_start >= tmp_va->va_end)
+ else if (va->va_start >= tmp_va->va_end)
link = &(*link)->rb_right;
else {
WARN(1, "vmalloc bug: 0x%lx-0x%lx overlaps with 0x%lx-0x%lx\n",
--
2.34.1
next prev parent reply other threads:[~2022-06-06 8:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 8:39 [PATCH 0/5] Cleanup patches of vmalloc Baoquan He
2022-06-06 8:39 ` [PATCH 1/5] mm/vmalloc: remove the unnecessary type check Baoquan He
2022-06-06 20:36 ` Uladzislau Rezki
2022-06-06 23:34 ` Baoquan He
2022-06-06 8:39 ` Baoquan He [this message]
2022-06-06 20:46 ` [PATCH 2/5] mm/vmalloc: remove the redundant boundary check Uladzislau Rezki
2022-06-06 8:39 ` [PATCH 3/5] mm/vmalloc: fix typo in local variable name Baoquan He
2022-06-06 20:47 ` Uladzislau Rezki
2022-06-06 8:39 ` [PATCH 4/5] mm/vmalloc: Add code comment for find_vmap_area_exceed_addr() Baoquan He
2022-06-06 20:50 ` Uladzislau Rezki
2022-06-06 8:39 ` [PATCH 5/5] mm: ioremap: rename ioremap_page_range() to ioremap_range() Baoquan He
2022-06-07 5:27 ` Christoph Hellwig
2022-06-07 7:53 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220606083909.363350-3-bhe@redhat.com \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@gmail.com \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.