From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68A22CCA47F for ; Mon, 6 Jun 2022 20:31:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229618AbiFFUbh (ORCPT ); Mon, 6 Jun 2022 16:31:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233736AbiFFUbQ (ORCPT ); Mon, 6 Jun 2022 16:31:16 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3E0712D09 for ; Mon, 6 Jun 2022 13:30:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id D9EBFCE1C6F for ; Mon, 6 Jun 2022 20:30:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DAD9C34119; Mon, 6 Jun 2022 20:30:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1654547423; bh=zr9GiFUFw2FZlrZ+VROSNUToxyI+n07Isc6CiM4UNjk=; h=Date:To:From:Subject:From; b=FBz5pu8doMyASOGAzWQGPPb8xcn6MOJB+m8/xiFmguFG6Gl9Bfx4xN6ModjdKp6qg 9gHUETmENuhsC420NCexme+LpsETZ3Mu+Svz4xXlEY+JwR7LdcdK4X6usR8DhNs0cc fyIjDq1LA9bqnPglYKsS4qMU3dODdOaeM7XFBNkU= Date: Mon, 06 Jun 2022 13:30:22 -0700 To: mm-commits@vger.kernel.org, vbabka@suse.cz, roman.gushchin@linux.dev, rientjes@google.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, daniel.vetter@intel.com, cl@linux.com, daniel.vetter@ffwll.ch, akpm@linux-foundation.org From: Andrew Morton Subject: + mm-slab-delete-cache_alloc_debugcheck_before.patch added to mm-unstable branch Message-Id: <20220606203023.0DAD9C34119@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The patch titled Subject: mm/slab: delete cache_alloc_debugcheck_before() has been added to the -mm mm-unstable branch. Its filename is mm-slab-delete-cache_alloc_debugcheck_before.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-slab-delete-cache_alloc_debugcheck_before.patch This patch will later appear in the mm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Daniel Vetter Subject: mm/slab: delete cache_alloc_debugcheck_before() Date: Sun, 5 Jun 2022 17:25:38 +0200 It only does a might_sleep_if(GFP_RECLAIM) check, which is already covered by the might_alloc() in slab_pre_alloc_hook(). And all callers of cache_alloc_debugcheck_before() call that beforehand already. Link: https://lkml.kernel.org/r/20220605152539.3196045-2-daniel.vetter@ffwll.ch Signed-off-by: Daniel Vetter Cc: Christoph Lameter Cc: Pekka Enberg Cc: David Rientjes Cc: Joonsoo Kim Cc: Vlastimil Babka Cc: Roman Gushchin Signed-off-by: Andrew Morton --- mm/slab.c | 10 ---------- 1 file changed, 10 deletions(-) --- a/mm/slab.c~mm-slab-delete-cache_alloc_debugcheck_before +++ a/mm/slab.c @@ -2958,12 +2958,6 @@ direct_grow: return ac->entry[--ac->avail]; } -static inline void cache_alloc_debugcheck_before(struct kmem_cache *cachep, - gfp_t flags) -{ - might_sleep_if(gfpflags_allow_blocking(flags)); -} - #if DEBUG static void *cache_alloc_debugcheck_after(struct kmem_cache *cachep, gfp_t flags, void *objp, unsigned long caller) @@ -3205,7 +3199,6 @@ slab_alloc_node(struct kmem_cache *cache if (unlikely(ptr)) goto out_hooks; - cache_alloc_debugcheck_before(cachep, flags); local_irq_save(save_flags); if (nodeid == NUMA_NO_NODE) @@ -3290,7 +3283,6 @@ slab_alloc(struct kmem_cache *cachep, st if (unlikely(objp)) goto out; - cache_alloc_debugcheck_before(cachep, flags); local_irq_save(save_flags); objp = __do_cache_alloc(cachep, flags); local_irq_restore(save_flags); @@ -3527,8 +3519,6 @@ int kmem_cache_alloc_bulk(struct kmem_ca if (!s) return 0; - cache_alloc_debugcheck_before(s, flags); - local_irq_disable(); for (i = 0; i < size; i++) { void *objp = kfence_alloc(s, s->object_size, flags) ?: __do_cache_alloc(s, flags); _ Patches currently in -mm which might be from daniel.vetter@ffwll.ch are mm-page_alloc-use-might_alloc.patch mm-slab-delete-cache_alloc_debugcheck_before.patch mm-mempool-use-might_alloc.patch