Re: [Buildroot] [PATCH 1/1] package/openssl: libopenssl needs atomic

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Arnout Vandecappelle <arnout@mind.be>
Cc: "Aleksandr Makarov" <aleksandr.o.makarov@gmail.com>,
	"Gustavo Heinz" <gustavo@gsthnz.com>,
	"Sven Haardiek" <sven.haardiek@iotec-gmbh.de>,
	"Yair Ben Avraham" <yairba@protonmail.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org, "Mauro Condarelli" <mc5686@mclink.it>,
	"Matt Weber" <matthew.weber@collins.com>,
	"Bernd Kuhls" <bernd.kuhls@t-online.de>,
	"Raphaël Mélotte" <raphael.melotte@mind.be>,
	"Sergey Matyukevich" <geomatsi@gmail.com>,
	"Gwenhael Goavec-Merou" <gwenhael.goavec-merou@trabucayre.com>,
	"Fabrice Fontaine" <fontaine.fabrice@gmail.com>,
	"Peter Seiderer" <ps.report@gmx.net>,
	"Norbert Lange" <nolange79@gmail.com>,
	"Joseph Kogut" <joseph.kogut@gmail.com>,
	"José Pekkarinen" <jose.pekkarinen@unikie.com>,
	"Manuel Vögele" <develop@manuel-voegele.de>,
	"Pierre-Jean Texier" <texier.pj2@gmail.com>,
	"Giulio Benetti" <giulio.benetti@benettiengineering.com>,
	"Philippe Reynes" <philippe.reynes@softathome.com>,
	"Asaf Kahlon" <asafka7@gmail.com>,
	"Lionel Flandrin" <lionel@svkt.org>
Subject: Re: [Buildroot] [PATCH 1/1] package/openssl: libopenssl needs atomic
Date: Mon, 6 Jun 2022 23:13:15 +0200	[thread overview]
Message-ID: <20220606211315.GA427639@scaer> (raw)
In-Reply-To: <55581997-b9da-7187-204c-3a47b32d6350@mind.be>

Fabrice, Arnout, All,

On 2022-06-06 21:06 +0200, Arnout Vandecappelle spake thusly:
> On 06/06/2022 16:21, Fabrice Fontaine wrote:
> >libopenssl needs atomic or the build will fail (e.g. on sparcv8 without
> >libatomic):
> 
>  I don't understand how it's possible that this error happens only with
> James' fully random configs, and not with e.g. bootlin-m68k-5208-uclibc
> (which I double checked does still have autobuilder results, and does not
> have libatomic). In fact, there are successful builds of libopenssl without
> libatomic, e.g. [1]. I found this with the autobuild query [2] (there's no
> way to search for the absence of a symbol in the advanced search, but
> m68k_cf5208 can't have atomic so it's a good way to search it).

I did some test, and indeed, sparc v8 fails to build. But leon builds
successfully.

For sparc v8, there are indeed references to __atomic_fetch_sub_4 and
__atomic_fetch_add_4. But for leon, none.

> >${LDCMD:-/nvmedata/autobuild/instance-7/output-1/host/bin/sparc-buildroot-linux-uclibc-gcc}  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -O0 -g2  -g2  -L.   \
> >	-o apps/openssl apps/asn1pars.o apps/ca.o apps/ciphers.o apps/cms.o apps/crl.o apps/crl2p7.o apps/dgst.o apps/dhparam.o apps/dsa.o apps/dsaparam.o apps/ec.o apps/ecparam.o apps/enc.o apps/engine.o apps/errstr.o apps/gendsa.o apps/genpkey.o apps/genrsa.o apps/nseq.o apps/ocsp.o apps/openssl.o apps/passwd.o apps/pkcs12.o apps/pkcs7.o apps/pkcs8.o apps/pkey.o apps/pkeyparam.o apps/pkeyutl.o apps/prime.o apps/rand.o apps/rehash.o apps/req.o apps/rsa.o apps/rsautl.o apps/s_client.o apps/s_server.o apps/s_time.o apps/sess_id.o apps/smime.o apps/speed.o apps/spkac.o apps/srp.o apps/storeutl.o apps/ts.o apps/verify.o apps/version.o apps/x509.o \
> >	 apps/libapps.a -lssl -lcrypto -ldl
> >/nvmedata/autobuild/instance-7/output-1/host/lib/gcc/sparc-buildroot-linux-uclibc/10.3.0/../../../../sparc-buildroot-linux-uclibc/bin/ld: ./libssl.so: undefined reference to `__atomic_fetch_sub_4'
> >
> >It should be noted that openssl3 has added OPENSSL_DEV_NO_ATOMICS but
> >"this is intended for internal development only, to check the
> >refcounting is properly coded.  It should never become a configuration
> >option, hence the name of the macro.":
> >https://github.com/openssl/openssl/commit/503d4745a115b82db01c1fb22baaddb153d27cdb
> >
> >Fixes:
> >  - http://autobuild.buildroot.org/results/bce526d538f43a541fdfbc0c9b4a7cecebbbc539
> >
> >Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> 
> [snip]
> >diff --git a/package/openssl/Config.in b/package/openssl/Config.in
> >index 7bf49b05f6..ed165569f0 100644
> >--- a/package/openssl/Config.in
> >+++ b/package/openssl/Config.in
> >@@ -16,6 +16,7 @@ choice
> >  config BR2_PACKAGE_LIBOPENSSL
> >  	bool "openssl"
> >+	depends on BR2_TOOLCHAIN_HAS_ATOMIC
> 
>  Unfortunately, this is not enough (and it is already a huge patch...).
> 
>  The result of this new dependency is that openssl is only available if
> BR2_TOOLCHAIN_HAS_ATOMIC (libopenssl) ||
> (!BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL && BR2_TOOLCHAIN_HAS_THREADS &&
>  !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU))
> 
>  So, in addition to the packages that select
> BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL, all the packages that select
> BR2_PACKAGE_OPENSSL have to be updated as well...

This is going to be a huge change...

Can we maybe instead add an exception in the autobuilders, so that
"fringe" architectures or variants just get excluded?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot