From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@fb.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvme: add bug report info for global duplicate id
Date: Tue, 7 Jun 2022 12:15:26 +0200 [thread overview]
Message-ID: <20220607101526.GA23753@lst.de> (raw)
In-Reply-To: <20220606164047.2549647-1-kbusch@fb.com>
On Mon, Jun 06, 2022 at 09:40:47AM -0700, Keith Busch wrote:
> if (ret) {
> + struct nvme_subsystem *subsys = ctrl->subsys;
> +
> dev_err(ctrl->device,
> "globally duplicate IDs for nsid %d\n", nsid);
> + dev_err(ctrl->device,
> + "bug report info: VID:%04x model:%.*s firmware:%.*s\n",
> + subsys->vendor_id,
> + nvme_str_len(subsys->model, sizeof(subsys->model)),
> + subsys->model,
> + nvme_str_len(subsys->firmware_rev,
> + sizeof(subsys->firmware_rev)),
> + subsys->firmware_rev);
So I like the idea here, but this won't give us the PCI device id
that we usually need for quirks.
next prev parent reply other threads:[~2022-06-07 10:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 16:40 [PATCH] nvme: add bug report info for global duplicate id Keith Busch
2022-06-06 17:15 ` Chaitanya Kulkarni
2022-06-07 10:15 ` Christoph Hellwig [this message]
2022-06-07 14:23 ` Keith Busch
2022-06-07 14:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607101526.GA23753@lst.de \
--to=hch@lst.de \
--cc=kbusch@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.