From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 4/9] nvme: Implement In-Band authentication
Date: Tue, 7 Jun 2022 12:49:41 +0200 [thread overview]
Message-ID: <20220607104941.GA26223@lst.de> (raw)
In-Reply-To: <20220527080457.90855-5-hare@suse.de>
On Fri, May 27, 2022 at 10:04:52AM +0200, Hannes Reinecke wrote:
> +config NVME_AUTH
> + bool "NVM Express over Fabrics In-Band Authentication"
> + depends on NVME_CORE
Does this actually depend on NVME_CORE? As that would suck when pulling
this code into the target driver as well. Also in addition to the header
location already mentioned by Max, this should probably go into
drivers/nvme/common/ if used by the host and target code.
> + This provides support for NVMe over Fabrics In-Band Authentication.
This should probably mention that the support can be used both by the
host and target code.
next prev parent reply other threads:[~2022-06-07 10:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 8:04 [PATCHv13 0/9] nvme: In-band authentication support Hannes Reinecke
2022-05-27 8:04 ` [PATCH 1/9] lib/base64: RFC4648-compliant base64 encoding Hannes Reinecke
2022-05-27 8:04 ` [PATCH 2/9] nvme: add definitions for NVMe In-Band authentication Hannes Reinecke
2022-05-27 8:04 ` [PATCH 3/9] nvme-fabrics: decode 'authentication required' connect error Hannes Reinecke
2022-05-27 8:04 ` [PATCH 4/9] nvme: Implement In-Band authentication Hannes Reinecke
2022-06-07 10:49 ` Christoph Hellwig [this message]
2022-06-08 6:01 ` Hannes Reinecke
2022-06-08 6:07 ` Christoph Hellwig
2022-05-27 8:04 ` [PATCH 5/9] nvme-auth: Diffie-Hellman key exchange support Hannes Reinecke
2022-05-27 8:04 ` [PATCH 6/9] nvmet: parse fabrics commands on io queues Hannes Reinecke
2022-05-27 8:04 ` [PATCH 7/9] nvmet: Implement basic In-Band Authentication Hannes Reinecke
2022-05-27 8:04 ` [PATCH 8/9] nvmet-auth: Diffie-Hellman key exchange support Hannes Reinecke
2022-05-27 8:04 ` [PATCH 9/9] nvmet-auth: expire authentication sessions Hannes Reinecke
2022-06-02 1:13 ` [PATCHv13 0/9] nvme: In-band authentication support Chaitanya Kulkarni
2022-06-02 1:46 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607104941.GA26223@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.