From: Jakub Kicinski <kuba@kernel.org>
To: Ronak Doshi <doshir@vmware.com>
Cc: <netdev@vger.kernel.org>,
VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 net-next 5/8] vmxnet3: add command to set ring buffer sizes
Date: Tue, 7 Jun 2022 17:28:12 -0700 [thread overview]
Message-ID: <20220607172812.489814b9@kernel.org> (raw)
In-Reply-To: <20220607084518.30316-6-doshir@vmware.com>
On Tue, 7 Jun 2022 01:45:15 -0700 Ronak Doshi wrote:
> + adapter->ringBufSize.ring1BufSizeType0 = adapter->skb_buf_size;
> + adapter->ringBufSize.ring1BufSizeType1 = 0;
> + adapter->ringBufSize.ring2BufSizeType1 = PAGE_SIZE;
These need to use correct byte ordering helpers, since the fields are
__le16 probably cpu_to_le16().
next prev parent reply other threads:[~2022-06-08 3:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 8:45 [PATCH v2 net-next 0/8] vmxnet3: upgrade to version 7 Ronak Doshi
2022-06-07 8:45 ` [PATCH v2 net-next 1/8] vmxnet3: prepare for version 7 changes Ronak Doshi
2022-06-07 8:45 ` [PATCH v2 net-next 2/8] vmxnet3: add support for capability registers Ronak Doshi
2022-06-07 8:45 ` [PATCH v2 net-next 3/8] vmxnet3: add support for large passthrough BAR register Ronak Doshi
2022-06-07 8:45 ` [PATCH v2 net-next 4/8] vmxnet3: add support for out of order rx completion Ronak Doshi
2022-06-07 8:45 ` [PATCH v2 net-next 5/8] vmxnet3: add command to set ring buffer sizes Ronak Doshi
2022-06-08 0:28 ` Jakub Kicinski [this message]
2022-06-08 23:08 ` Ronak Doshi
2022-06-07 8:45 ` [PATCH v2 net-next 6/8] vmxnet3: limit number of TXDs used for TSO packet Ronak Doshi
2022-06-07 8:45 ` [PATCH v2 net-next 7/8] vmxnet3: use ext1 field to indicate encapsulated packet Ronak Doshi
2022-06-07 8:45 ` [PATCH v2 net-next 8/8] vmxnet3: update to version 7 Ronak Doshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607172812.489814b9@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=doshir@vmware.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pv-drivers@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.