From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>,
Romain Naour <romain.naour@gmail.com>,
Buildroot List <buildroot@buildroot.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: [Buildroot] [PATCH v2 10/14] support/scripts/gen-bootlin-toolchains: check that toolchains exists for a certain arch
Date: Wed, 8 Jun 2022 09:10:22 +0200 [thread overview]
Message-ID: <20220608071027.3384469-11-thomas.petazzoni@bootlin.com> (raw)
In-Reply-To: <20220608071027.3384469-1-thomas.petazzoni@bootlin.com>
The "arches" dict lists the architectures for which Bootlin toolchains
are available, along with the corresponding Buildroot conditions for
those architecture variants.
However, there is nothing that checks that such architectures really
have Bootlin toolchains available. Even if no toolchain is available,
the architecture is considered as support, and will be listed in the
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_ARCH_SUPPORTS option, making menuconfig
believe that some Bootlin toolchain is available for the selected
architecture variant.
This is currently the case with the "mips64" architecture (as
identified by the Bootlin toolchains project). Such toolchains have
been made obsolete in toolchains.bootlin.com and replaced by the
mips64-n32 toolchains. But "mips64" is still listed in "arches",
causing this architecture to be considered as having Bootlin
toolchains available.
To avoid this to happen in the future, this commit adds a check that
verifies that an architecture listed in "arches" really has at least
one toolchain available.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
support/scripts/gen-bootlin-toolchains | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/support/scripts/gen-bootlin-toolchains b/support/scripts/gen-bootlin-toolchains
index ad65f9fe5e..36727c8fea 100755
--- a/support/scripts/gen-bootlin-toolchains
+++ b/support/scripts/gen-bootlin-toolchains
@@ -4,6 +4,7 @@ import os.path
import re
import requests
import textwrap
+import sys
BASE_URL = "https://toolchains.bootlin.com/downloads/releases/toolchains"
@@ -483,6 +484,10 @@ def get_toolchains():
version = parts[2][len("bleeding-edge-"):]
tmp[(arch, libc, variant)] = version
+ if len(tmp) == 0:
+ print("ERROR: no toolchains found for architecture %s" % arch)
+ sys.exit(1)
+
toolchains += [Toolchain(k[0], k[1], k[2], v) for k, v in tmp.items()]
return toolchains
--
2.35.3
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-06-08 7:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 7:10 [Buildroot] [PATCH v2 00/14] Another set of Bootlin toolchain integration improvements Thomas Petazzoni via buildroot
2022-06-08 7:10 ` [Buildroot] [PATCH v2 01/14] support/scripts/gen-bootlin-toolchains: fix RISC-V 64-bit toolchain description Thomas Petazzoni via buildroot
2022-06-08 7:10 ` [Buildroot] [PATCH v2 02/14] support/testing, toolchain/toolchain-external/toolchain-external-bootlin: regenerate with latest gen-bootlin-toolchains script Thomas Petazzoni via buildroot
2022-06-08 7:10 ` [Buildroot] [PATCH v2 03/14] support/scripts/gen-bootlin-toolchains: improve dependencies of ARM toolchains Thomas Petazzoni via buildroot
2022-06-08 7:10 ` [Buildroot] [PATCH v2 04/14] toolchain/toolchain-external/toolchain-external-bootlin: regenerate with BR2_ARM dependency Thomas Petazzoni via buildroot
2022-06-08 7:10 ` [Buildroot] [PATCH v2 05/14] support/scripts/gen-bootlin-toolchains: adjust dependencies of i686 toolchains Thomas Petazzoni via buildroot
2022-06-08 7:10 ` [Buildroot] [PATCH v2 06/14] toolchain/toolchain-external/toolchain-external-bootlin: regenerate after i686 toolchain dependency fixes Thomas Petazzoni via buildroot
2022-06-08 7:10 ` [Buildroot] [PATCH v2 07/14] toolchain/toolchain-external: add BR2_TOOLCHAIN_EXTERNAL_HAS_NO_GDBSERVER option Thomas Petazzoni via buildroot
2022-06-14 15:34 ` Arnout Vandecappelle
2022-06-14 15:58 ` Thomas Petazzoni via buildroot
2022-06-14 16:56 ` Arnout Vandecappelle
2022-06-14 21:41 ` Thomas Petazzoni via buildroot
2022-06-08 7:10 ` [Buildroot] [PATCH v2 08/14] support/scripts/gen-bootlin-toolchains: make use of BR2_TOOLCHAIN_EXTERNAL_HAS_NO_GDBSERVER Thomas Petazzoni via buildroot
2022-06-08 7:10 ` [Buildroot] [PATCH v2 09/14] toolchain/toolchain-external/toolchain-external-bootlin: regenerate with BR2_TOOLCHAIN_EXTERNAL_HAS_NO_GDBSERVER Thomas Petazzoni via buildroot
2022-06-08 7:10 ` Thomas Petazzoni via buildroot [this message]
2022-06-08 7:10 ` [Buildroot] [PATCH v2 11/14] support/scripts/gen-bootlin-toolchains: drop "mips64" architecture variant Thomas Petazzoni via buildroot
2022-06-08 7:10 ` [Buildroot] [PATCH v2 12/14] toolchain/toolchain-external/toolchain-external-bootlin: regenerate after mips64 toolchain removal Thomas Petazzoni via buildroot
2022-06-08 7:10 ` [Buildroot] [PATCH v2 13/14] support/scripts/gen-bootlin-toolchains: add support for ARMv7 big endian toolchain Thomas Petazzoni via buildroot
2022-06-08 7:10 ` [Buildroot] [PATCH v2 14/14] support/testing, toolchain/toolchain-external/toolchain-external-bootlin: regenerate with " Thomas Petazzoni via buildroot
2022-06-14 15:43 ` [Buildroot] [PATCH v2 00/14] Another set of Bootlin toolchain integration improvements Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220608071027.3384469-11-thomas.petazzoni@bootlin.com \
--to=buildroot@buildroot.org \
--cc=romain.naour@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.