Re: [PATCH v2] ARM: dts: aspeed: Add a palmetto board (AST2400)

[Zev Weiss <zweiss@equinix.com>]

On Wed, Jun 08, 2022 at 01:22:21AM PDT, Cédric Le Goater wrote:
>Palmettos were the first OpenPOWER systems built by Tyan with the
>product name: GN70-BP010. They contained an IBM POWER8 Turismo SCM
>processor and an Aspeed AST2400 SoC.
>
>The ast2400_openbmc_defconfig defconfig is based on the evb-ast2400
>defconfig, plus these extras :
>
>  CONFIG_BOOTCOMMAND="bootm 20080000"
>  CONFIG_DEFAULT_DEVICE_TREE="ast2400-palmetto"
>  CONFIG_PHY_NCSI=y
>
>Cc: Joel Stanley <joel@jms.id.au>
>Signed-off-by: Cédric Le Goater <clg@kaod.org>
>---
>
> Changes in v2 :
>
> - device tree cleanups to match HW
> - renamed defconfig to ast2400_openbmc_defconfig
>
> arch/arm/dts/Makefile             |  1 +
> arch/arm/dts/ast2400-palmetto.dts | 74 +++++++++++++++++++++++++++++++
> configs/ast2400_openbmc_defconfig | 72 ++++++++++++++++++++++++++++++
> 3 files changed, 147 insertions(+)
> create mode 100644 arch/arm/dts/ast2400-palmetto.dts
> create mode 100644 configs/ast2400_openbmc_defconfig
>
>diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
>index 8f876a0aa0d7..1d523c5d5da0 100755
>--- a/arch/arm/dts/Makefile
>+++ b/arch/arm/dts/Makefile
>@@ -676,6 +676,7 @@ dtb-$(CONFIG_ARCH_BCM6858) += \
>
> dtb-$(CONFIG_ARCH_ASPEED) += \
> 	ast2400-evb.dtb \
>+	ast2400-palmetto.dtb \
> 	ast2400-ahe-50dc.dtb \

Sort?  (palmetto after ahe-50dc)

> 	ast2500-evb.dtb \
> 	ast2600a0-evb.dtb \
>diff --git a/arch/arm/dts/ast2400-palmetto.dts b/arch/arm/dts/ast2400-palmetto.dts
>new file mode 100644
>index 000000000000..2a49ded27b43
>--- /dev/null
>+++ b/arch/arm/dts/ast2400-palmetto.dts
>@@ -0,0 +1,74 @@
>+// SPDX-License-Identifier: GPL-2.0+
>+/dts-v1/;
>+
>+#include "ast2400-u-boot.dtsi"
>+
>+/ {
>+	model = "Palmetto BMC";
>+	compatible = "tyan,palmetto-bmc", "aspeed,ast2400";
>+
>+	memory@40000000 {
>+		device_type = "memory";
>+		reg = <0x40000000 0x10000000>;
>+	};
>+
>+	chosen {
>+		stdout-path = &uart5;
>+		bootargs = "console=ttyS4,115200 earlyprintk";

Does bootargs serve a particular purpose here?  (The other ast2x00
device-trees don't appear to include it.)

>+	};
>+
>+	aliases {
>+		spi0 = &fmc;
>+		spi1 = &spi1;
>+		ethernet0 = &mac0;
>+	};
>+};
>+
>+&uart5 {
>+	u-boot,dm-pre-reloc;
>+	status = "okay";
>+};
>+
>+&sdrammc {
>+	clock-frequency = <200000000>;
>+};
>+
>+&wdt1 {
>+	u-boot,dm-pre-reloc;
>+	status = "okay";
>+};
>+
>+&wdt2 {
>+	u-boot,dm-pre-reloc;
>+	status = "okay";
>+};
>+
>+&mac0 {
>+	status = "okay";
>+	phy-mode = "rgmii";
>+
>+	pinctrl-names = "default";
>+	pinctrl-0 = <&pinctrl_mac1link_default &pinctrl_mdio1_default>;
>+};
>+
>+&fmc {
>+	status = "okay";
>+	flash@0 {
>+		status = "okay";
>+		spi-max-frequency = <50000000>;
>+		spi-tx-bus-width = <2>;
>+		spi-rx-bus-width = <2>;
>+	};
>+};
>+
>+&spi1 {
>+	status = "okay";
>+	flash@0 {
>+		pinctrl-names = "default";
>+		pinctrl-0 = <&pinctrl_spi1_default>;
>+		status = "okay";
>+		spi-max-frequency = <50000000>;
>+		spi-tx-bus-width = <2>;
>+		spi-rx-bus-width = <2>;
>+	};
>+};
>diff --git a/configs/ast2400_openbmc_defconfig b/configs/ast2400_openbmc_defconfig
>new file mode 100644
>index 000000000000..d09358777304
>--- /dev/null
>+++ b/configs/ast2400_openbmc_defconfig

Is the implication here that the testing discussed in the v1 thread
(using the existing evb defconfig instead of an entirely new one) didn't
work out?

>@@ -0,0 +1,72 @@
>+CONFIG_ARM=y
>+CONFIG_ARCH_ASPEED=y
>+CONFIG_SYS_TEXT_BASE=0x0
>+CONFIG_ASPEED_AST2400=y
>+CONFIG_SYS_MALLOC_F_LEN=0x2000
>+CONFIG_ENV_SIZE=0x10000
>+CONFIG_ENV_OFFSET=0xF0000
>+CONFIG_NR_DRAM_BANKS=1
>+CONFIG_FIT=y
>+CONFIG_USE_BOOTARGS=y
>+CONFIG_BOOTARGS="console=ttyS4,115200n8 root=/dev/ram rw"
>+CONFIG_USE_BOOTCOMMAND=y
>+CONFIG_BOOTCOMMAND="bootm 20080000"
>+CONFIG_PRE_CONSOLE_BUFFER=y
>+CONFIG_PRE_CON_BUF_ADDR=0x1e720000
>+CONFIG_SYS_CONSOLE_ENV_OVERWRITE=y
>+CONFIG_HUSH_PARSER=y
>+# CONFIG_AUTO_COMPLETE is not set
>+CONFIG_SYS_PROMPT="ast# "
>+# CONFIG_CMD_IMI is not set
>+# CONFIG_CMD_XIMG is not set
>+CONFIG_CMD_MEMTEST=y
>+CONFIG_SYS_ALT_MEMTEST=y
>+CONFIG_CMD_CLK=y
>+CONFIG_CMD_GPIO=y
>+CONFIG_CMD_I2C=y
>+CONFIG_CMD_MMC=y
>+CONFIG_CMD_SF=y
>+CONFIG_CMD_DHCP=y
>+CONFIG_CMD_MII=y
>+CONFIG_CMD_PING=y
>+CONFIG_DEFAULT_DEVICE_TREE="ast2400-palmetto"
>+CONFIG_ENV_IS_IN_SPI_FLASH=y
>+CONFIG_USE_ENV_SPI_BUS=y
>+CONFIG_ENV_SPI_BUS=0
>+CONFIG_USE_ENV_SPI_CS=y
>+CONFIG_ENV_SPI_CS=0
>+CONFIG_USE_ENV_SPI_MAX_HZ=y
>+CONFIG_ENV_SPI_MAX_HZ=100000000
>+CONFIG_NET_RANDOM_ETHADDR=y
>+CONFIG_REGMAP=y
>+CONFIG_CLK=y
>+CONFIG_DM_GPIO=y
>+CONFIG_ASPEED_GPIO=y
>+CONFIG_DM_I2C=y
>+CONFIG_SYS_I2C_ASPEED=y
>+CONFIG_MISC=y
>+CONFIG_DM_MMC=y
>+# CONFIG_MMC_HW_PARTITIONING is not set
>+CONFIG_MMC_SDHCI=y
>+CONFIG_MMC_SDHCI_ASPEED=y
>+CONFIG_DM_SPI_FLASH=y
>+CONFIG_SPI_FLASH=y
>+CONFIG_SPI_FLASH_MACRONIX=y
>+CONFIG_SPI_FLASH_SPANSION=y
>+CONFIG_SPI_FLASH_STMICRO=y
>+CONFIG_SPI_FLASH_WINBOND=y
>+CONFIG_PHY_REALTEK=y
>+CONFIG_PHY_NCSI=y
>+CONFIG_DM_ETH=y
>+CONFIG_PHY_GIGE=y
>+CONFIG_FTGMAC100=y
>+CONFIG_PHY=y
>+CONFIG_PINCTRL=y
>+CONFIG_DM_SERIAL=y
>+CONFIG_SYS_NS16550=y
>+CONFIG_SPI=y
>+CONFIG_DM_SPI=y
>+CONFIG_SYSRESET=y
>+CONFIG_TIMER=y
>+CONFIG_WDT=y
>+# CONFIG_EFI_LOADER is not set
>-- 
>2.35.3
>