From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Subject: Re: Possibly dangerous interpretation of address/prefix pair in -s option Date: Wed, 8 Jun 2022 13:21:35 +0200 Message-ID: <20220608112135.GC11923@breakpoint.cc> References: <010201812a0fb624-e64464be-4c31-4d01-afb6-1cbfab70e333-000000@eu-west-1.amazonses.com> <60e26dbd-93a8-1c2a-5204-66bbdffb1291@thelounge.net> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Chris Hall Cc: netfilter@vger.kernel.org, Reindl Harald Chris Hall wrote: > For input such as "-s 10.0.0.2/24", the 10.0.0.2 simply isn't a valid > network address for a /24 network. > > I agree: the parser should detect invalid input and reject it. I can see no > good reason for being sloppy here. It breaks current behaviour; we cannot change this 20 years later. Its as simple as that.