From: Jakub Kicinski <kuba@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jonathan Lemon <jonathan.lemon@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH net-next v1 1/5] ptp_ocp: use dev_err_probe()
Date: Thu, 9 Jun 2022 22:45:23 -0700 [thread overview]
Message-ID: <20220609224523.78b6a6e6@kernel.org> (raw)
In-Reply-To: <20220608120358.81147-2-andriy.shevchenko@linux.intel.com>
On Wed, 8 Jun 2022 15:03:54 +0300 Andy Shevchenko wrote:
> Simplify the error path in ->probe() and unify message format a bit
> by using dev_err_probe().
Let's not do this. I get that using dev_err_probe() even without
possibility of -EPROBE_DEFER is acceptable, but converting
existing drivers is too much IMO. Acceptable < best practice.
next prev parent reply other threads:[~2022-06-10 5:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 12:03 [PATCH net-next v1 0/5] ptp_ocp: set of small cleanups Andy Shevchenko
2022-06-08 12:03 ` [PATCH net-next v1 1/5] ptp_ocp: use dev_err_probe() Andy Shevchenko
2022-06-08 21:37 ` Vadim Fedorenko
2022-06-08 22:20 ` Jonathan Lemon
2022-06-10 5:45 ` Jakub Kicinski [this message]
2022-06-10 11:09 ` Andy Shevchenko
2022-06-10 15:39 ` Jakub Kicinski
2022-06-10 15:46 ` Jonathan Lemon
2022-06-10 16:04 ` Andy Shevchenko
2022-06-08 12:03 ` [PATCH v1 net-next 2/5] ptp_ocp: use bits.h macros for all masks Andy Shevchenko
2022-06-08 21:41 ` Vadim Fedorenko
2022-06-08 12:03 ` [PATCH v1 net-next 3/5] ptp_ocp: drop duplicate NULL check in ptp_ocp_detach() Andy Shevchenko
2022-06-08 21:42 ` Vadim Fedorenko
2022-06-08 12:03 ` [PATCH v1 net-next 4/5] ptp_ocp: do not call pci_set_drvdata(pdev, NULL) Andy Shevchenko
2022-06-08 21:47 ` Vadim Fedorenko
2022-06-09 10:43 ` Andy Shevchenko
2022-06-08 12:03 ` [PATCH v1 net-next 5/5] ptp_ocp: replace kzalloc(x*y) by kcalloc(y, x) Andy Shevchenko
2022-06-08 21:48 ` Vadim Fedorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220609224523.78b6a6e6@kernel.org \
--to=kuba@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jonathan.lemon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.