From: Herve Codina <herve.codina@bootlin.com>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Cc: Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org
Subject: Re: [PATCH] dmaengine: dw-edma: remove a macro conditional with similar branches
Date: Fri, 10 Jun 2022 12:55:02 +0200 [thread overview]
Message-ID: <20220610125502.103d1258@bootlin.com> (raw)
In-Reply-To: <20220610100700.2295522-1-vladimir.zapolskiy@linaro.org>
On Fri, 10 Jun 2022 13:07:00 +0300
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> wrote:
> After adding commit 8fc5133d6d4d ("dmaengine: dw-edma: Fix unaligned
> 64bit access") two branches under macro conditional become identical,
> thus the code can be simplified without any functional change.
>
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---
> drivers/dma/dw-edma/dw-edma-v0-core.c | 8 --------
> 1 file changed, 8 deletions(-)
Sure,
My first thought was to clearly identify the 64bit case but
I am fully agree, on this simple piece of code, it is not
necessary.
Acked-by: Herve Codina <herve.codina@bootlin.com>
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2022-06-10 10:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 10:07 [PATCH] dmaengine: dw-edma: remove a macro conditional with similar branches Vladimir Zapolskiy
2022-06-10 10:55 ` Herve Codina [this message]
2022-06-10 12:19 ` Vinod Koul
2022-06-15 13:36 ` Frank Li
2022-06-16 13:56 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220610125502.103d1258@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=dmaengine@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=vkoul@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.