From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BF8A7A for ; Sat, 11 Jun 2022 14:13:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A775DC34116; Sat, 11 Jun 2022 14:13:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654956804; bh=nyZvL91oFCb9bthQSadgYmYYNFgPdHqKzIod7PSvXoE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C2tuo46TtbrdY2D19m2dgc8qWZXkB9kD9XOOUf+g2P6r7or/YShlN3zfieoRbi1Vk mRI7PO6xQMBBZDFZ33JtIn/6IVQn/VTxVQXaJO1ADbDwlQfv3ugfoK+SZ2wWPnkBEe NQN0YnkPwxplxSwb5TPXK7nCa4EcaM5XEQsCru/WIGnRxSEQ5MOC6fJr8zRFIfBTyu tLwN+T41I7UHRhABICFeESgCC5Pk7w7sag45jDCofg7ENDt7w2JsMMV2UnrL0YRNvo 0EPVDiII3hAp7sPmFQsLP0zYudeuY2ortQ78I2x55E+QAmRNr9FxfNDMWR9mLxN2JJ ED2zAMUfpL0uQ== Date: Sat, 11 Jun 2022 15:22:22 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Nuno =?UTF-8?B?U8Oh?= , dl-linux-imx , Linux-Renesas , "open list:BROADCOM NVRAM DRIVER" , linux-arm Mailing List , chrome-platform@lists.linux.dev, Lad Prabhakar , "moderated list:ARM/Mediatek SoC support" , linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm , linux-iio , OpenBMC Maillist , Cai Huoqing , Benjamin Fair , Jishnu Prakash , Linus Walleij , Lars-Peter Clausen , Alexandre Torgue , Amit Kucheria , Andy Gross , Michael Hennerich , Haibo Chen , Benson Leung , "Rafael J. Wysocki" , Alexandre Belloni , Christophe Branchereau , Patrick Venture , Arnd Bergmann , Nancy Yuen , Sascha Hauer , Daniel Lezcano , Gwendal Grignou , Saravanan Sekar , Tali Perry , Maxime Coquelin , Paul Cercueil , Thara Gopinath , Avi Fishman , Lorenzo Bianconi , Claudiu Beznea , Pengutronix Kernel Team , Fabrice Gasnier , Matthias Brugger , Tomer Maimon , Bjorn Andersson , Nicolas Ferre , Zhang Rui , Shawn Guo , Guenter Roeck , Fabio Estevam , Olivier Moysan , Eugen Hristev , Miquel Raynal Subject: Re: [PATCH 15/34] iio: humidity: hts221_buffer: explicitly add proper header files Message-ID: <20220611152222.43ab685e@jic23-huawei> In-Reply-To: References: <20220610084545.547700-1-nuno.sa@analog.com> <20220610084545.547700-16-nuno.sa@analog.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 10 Jun 2022 16:47:16 +0200 Andy Shevchenko wrote: > On Fri, Jun 10, 2022 at 10:47 AM Nuno S=C3=A1 wrote: > > > > Do not trust the fact that iio.h includes of.h which in turn includes > > all the headers we are relying on. > > > > The ultimate goal is to actually drop of.h from iio.h. =20 >=20 > ... >=20 > > #include > > #include > > #include > > +#include =20 >=20 > Yes, I see, but you can make life easier if you try to squeeze to the > most sorted part. I do not see full context, but here I would put it > before regmap.h. >=20 With full context it's clear the list is way off sorted, but meh putting it above regmap probably reduces the follow up diff a tiny bit and I doubt Nuno feels strongly about this so I went with what Andy suggested as a tweak whilst applying. Applied Thanks, Jonathan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21541C43334 for ; Sat, 11 Jun 2022 14:13:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/HOHDNeKXQqVAAuY0JbeaEWFdtwx/iblv2cVOje8qtU=; b=PuKkIj6O6rIERo BmLh8xI9Aphf0ably4jaSaMX931Ddc+SosFDCdd0quU13Ff35JC0ygpTTJlJvD7sWIOV9Vuq7Cdqs G3PNs4k8VtF0sz/xgzjY6Cwjr5bXodRk8jR2gno2Wt/LTyygR5RZicj2JtvctWzYIfI7rp1Seo8sg V7BQgaBMdI6Wcot7pUCHC3vtTGbYVqXA8J3XsnkrVKZL88m1fgZtcLvtxjzKhHCn9Lfr+5zxd+3z6 j61mxTPyRGcPRgC8fccUA+Cz+Gpl6CQXnmtOpx+eha/LgBorIgbiLrGUBvJYjtxBQG1lR98MCsOoh rQczG88AlqyKmjs6JrAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o01ru-00DELS-Hu; Sat, 11 Jun 2022 14:13:38 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o01ri-00DEFu-N0; Sat, 11 Jun 2022 14:13:28 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 54048B816AD; Sat, 11 Jun 2022 14:13:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A775DC34116; Sat, 11 Jun 2022 14:13:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654956804; bh=nyZvL91oFCb9bthQSadgYmYYNFgPdHqKzIod7PSvXoE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C2tuo46TtbrdY2D19m2dgc8qWZXkB9kD9XOOUf+g2P6r7or/YShlN3zfieoRbi1Vk mRI7PO6xQMBBZDFZ33JtIn/6IVQn/VTxVQXaJO1ADbDwlQfv3ugfoK+SZ2wWPnkBEe NQN0YnkPwxplxSwb5TPXK7nCa4EcaM5XEQsCru/WIGnRxSEQ5MOC6fJr8zRFIfBTyu tLwN+T41I7UHRhABICFeESgCC5Pk7w7sag45jDCofg7ENDt7w2JsMMV2UnrL0YRNvo 0EPVDiII3hAp7sPmFQsLP0zYudeuY2ortQ78I2x55E+QAmRNr9FxfNDMWR9mLxN2JJ ED2zAMUfpL0uQ== Date: Sat, 11 Jun 2022 15:22:22 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Nuno =?UTF-8?B?U8Oh?= , dl-linux-imx , Linux-Renesas , "open list:BROADCOM NVRAM DRIVER" , linux-arm Mailing List , chrome-platform@lists.linux.dev, Lad Prabhakar , "moderated list:ARM/Mediatek SoC support" , linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm , linux-iio , OpenBMC Maillist , Cai Huoqing , Benjamin Fair , Jishnu Prakash , Linus Walleij , Lars-Peter Clausen , Alexandre Torgue , Amit Kucheria , Andy Gross , Michael Hennerich , Haibo Chen , Benson Leung , "Rafael J. Wysocki" , Alexandre Belloni , Christophe Branchereau , Patrick Venture , Arnd Bergmann , Nancy Yuen , Sascha Hauer , Daniel Lezcano , Gwendal Grignou , Saravanan Sekar , Tali Perry , Maxime Coquelin , Paul Cercueil , Thara Gopinath , Avi Fishman , Lorenzo Bianconi , Claudiu Beznea , Pengutronix Kernel Team , Fabrice Gasnier , Matthias Brugger , Tomer Maimon , Bjorn Andersson , Nicolas Ferre , Zhang Rui , Shawn Guo , Guenter Roeck , Fabio Estevam , Olivier Moysan , Eugen Hristev , Miquel Raynal Subject: Re: [PATCH 15/34] iio: humidity: hts221_buffer: explicitly add proper header files Message-ID: <20220611152222.43ab685e@jic23-huawei> In-Reply-To: References: <20220610084545.547700-1-nuno.sa@analog.com> <20220610084545.547700-16-nuno.sa@analog.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220611_071327_104244_147872C1 X-CRM114-Status: GOOD ( 15.81 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org T24gRnJpLCAxMCBKdW4gMjAyMiAxNjo0NzoxNiArMDIwMApBbmR5IFNoZXZjaGVua28gPGFuZHku c2hldmNoZW5rb0BnbWFpbC5jb20+IHdyb3RlOgoKPiBPbiBGcmksIEp1biAxMCwgMjAyMiBhdCAx MDo0NyBBTSBOdW5vIFPDoSA8bnVuby5zYUBhbmFsb2cuY29tPiB3cm90ZToKPiA+Cj4gPiBEbyBu b3QgdHJ1c3QgdGhlIGZhY3QgdGhhdCBpaW8uaCBpbmNsdWRlcyBvZi5oIHdoaWNoIGluIHR1cm4g aW5jbHVkZXMKPiA+IGFsbCB0aGUgaGVhZGVycyB3ZSBhcmUgcmVseWluZyBvbi4KPiA+Cj4gPiBU aGUgdWx0aW1hdGUgZ29hbCBpcyB0byBhY3R1YWxseSBkcm9wIG9mLmggZnJvbSBpaW8uaC4gIAo+ IAo+IC4uLgo+IAo+ID4gICNpbmNsdWRlIDxsaW51eC9pcnFyZXR1cm4uaD4KPiA+ICAjaW5jbHVk ZSA8bGludXgvcmVnbWFwLmg+Cj4gPiAgI2luY2x1ZGUgPGxpbnV4L2JpdGZpZWxkLmg+Cj4gPiAr I2luY2x1ZGUgPGxpbnV4L3Byb3BlcnR5Lmg+ICAKPiAKPiBZZXMsIEkgc2VlLCBidXQgeW91IGNh biBtYWtlIGxpZmUgZWFzaWVyIGlmIHlvdSB0cnkgdG8gc3F1ZWV6ZSB0byB0aGUKPiBtb3N0IHNv cnRlZCBwYXJ0LiBJIGRvIG5vdCBzZWUgZnVsbCBjb250ZXh0LCBidXQgaGVyZSBJIHdvdWxkIHB1 dCBpdAo+IGJlZm9yZSByZWdtYXAuaC4KPiAKV2l0aCBmdWxsIGNvbnRleHQgaXQncyBjbGVhciB0 aGUgbGlzdCBpcyB3YXkgb2ZmIHNvcnRlZCwgYnV0IG1laApwdXR0aW5nIGl0IGFib3ZlIHJlZ21h cCBwcm9iYWJseSByZWR1Y2VzIHRoZSBmb2xsb3cgdXAgZGlmZiBhIHRpbnkKYml0IGFuZCBJIGRv dWJ0IE51bm8gZmVlbHMgc3Ryb25nbHkgYWJvdXQgdGhpcyBzbyBJIHdlbnQgd2l0aAp3aGF0IEFu ZHkgc3VnZ2VzdGVkIGFzIGEgdHdlYWsgd2hpbHN0IGFwcGx5aW5nLgoKQXBwbGllZAoKVGhhbmtz LAoKSm9uYXRoYW4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpMaW51eC1tZWRpYXRlayBtYWlsaW5nIGxpc3QKTGludXgtbWVkaWF0ZWtAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LW1lZGlhdGVrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 288B7C43334 for ; Thu, 16 Jun 2022 02:36:05 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LNmWR63X6z3dy9 for ; Thu, 16 Jun 2022 12:36:03 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=C2tuo46T; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4601:e00::1; helo=ams.source.kernel.org; envelope-from=jic23@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=C2tuo46T; dkim-atps=neutral Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LL0DS1YkCz3by1 for ; Sun, 12 Jun 2022 00:13:28 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 54048B816AD; Sat, 11 Jun 2022 14:13:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A775DC34116; Sat, 11 Jun 2022 14:13:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654956804; bh=nyZvL91oFCb9bthQSadgYmYYNFgPdHqKzIod7PSvXoE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C2tuo46TtbrdY2D19m2dgc8qWZXkB9kD9XOOUf+g2P6r7or/YShlN3zfieoRbi1Vk mRI7PO6xQMBBZDFZ33JtIn/6IVQn/VTxVQXaJO1ADbDwlQfv3ugfoK+SZ2wWPnkBEe NQN0YnkPwxplxSwb5TPXK7nCa4EcaM5XEQsCru/WIGnRxSEQ5MOC6fJr8zRFIfBTyu tLwN+T41I7UHRhABICFeESgCC5Pk7w7sag45jDCofg7ENDt7w2JsMMV2UnrL0YRNvo 0EPVDiII3hAp7sPmFQsLP0zYudeuY2ortQ78I2x55E+QAmRNr9FxfNDMWR9mLxN2JJ ED2zAMUfpL0uQ== Date: Sat, 11 Jun 2022 15:22:22 +0100 From: Jonathan Cameron To: Andy Shevchenko Subject: Re: [PATCH 15/34] iio: humidity: hts221_buffer: explicitly add proper header files Message-ID: <20220611152222.43ab685e@jic23-huawei> In-Reply-To: References: <20220610084545.547700-1-nuno.sa@analog.com> <20220610084545.547700-16-nuno.sa@analog.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Thu, 16 Jun 2022 12:05:37 +1000 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Daniel Lezcano , Tomer Maimon , "Rafael J. Wysocki" , linux-iio , Linus Walleij , Amit Kucheria , Alexandre Torgue , Nuno =?UTF-8?B?U8Oh?= , Paul Cercueil , Miquel Raynal , Guenter Roeck , Fabio Estevam , linux-stm32@st-md-mailman.stormreply.com, chrome-platform@lists.linux.dev, Lars-Peter Clausen , Benjamin Fair , OpenBMC Maillist , Jishnu Prakash , Haibo Chen , Andy Gross , dl-linux-imx , Olivier Moysan , Zhang Rui , Christophe Branchereau , Bjorn Andersson , Saravanan Sekar , Michael Hennerich , linux-arm-msm , Sascha Hauer , Nicolas Ferre , Lad Prabhakar , Fabrice Gasnier , "moderated list:ARM/Mediatek SoC support" , Eugen Hristev , Matthias Brugger , Gwendal Grignou , Tali Perry , Benson Leung , Pengutronix Kernel Team , linux-arm Mailing List , Lorenzo Bianconi , Avi Fishman , Patrick Venture , "open list:BROADCOM NVRAM DRIVER" , Thara Gopinath , Linux-Renesas , Arnd Bergmann , Maxime Coquelin , Cai Huoqing , Shawn Guo , Claudiu Beznea Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Fri, 10 Jun 2022 16:47:16 +0200 Andy Shevchenko wrote: > On Fri, Jun 10, 2022 at 10:47 AM Nuno S=C3=A1 wrote: > > > > Do not trust the fact that iio.h includes of.h which in turn includes > > all the headers we are relying on. > > > > The ultimate goal is to actually drop of.h from iio.h. =20 >=20 > ... >=20 > > #include > > #include > > #include > > +#include =20 >=20 > Yes, I see, but you can make life easier if you try to squeeze to the > most sorted part. I do not see full context, but here I would put it > before regmap.h. >=20 With full context it's clear the list is way off sorted, but meh putting it above regmap probably reduces the follow up diff a tiny bit and I doubt Nuno feels strongly about this so I went with what Andy suggested as a tweak whilst applying. Applied Thanks, Jonathan