From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C0E37A for ; Sat, 11 Jun 2022 14:21:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 454F6C34116; Sat, 11 Jun 2022 14:21:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654957277; bh=lfyWxTdm+9DA2o5Gv4TMOK79YAUDNtuhApIhJjT70sc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oCVbMFgyFX6oFH9u3+7f5Hm4+q5RYHvp3rgC4dsE0IEQZXvrtnPlXfQnAAnejz0xR lkmxE/CIR1fCuZZ1eU3ZYl5amkKuaOVsuPrh6pXb2TtzM4ufNY7k1LT1YVEAZ0QUc9 8kFKGWJz6+JPx7xwmpXMHQ0suVKcRhwqQiando1XDqH+x4ErQgXo+eWTv7qOtiS2Kk 7sEjS2O1A+ImNtfVji8lSkOMnMR/LIKBCWMg10V5/81/grKwvV8ar0Y3R0FBH7igf4 Hx1sU60YSsy+PE4LPbaCFaBA840/DS4NcKtTAOlTrHnPRvu+fg3VnT5Fr7aAFuXBk8 iv+MSeL9C6Jnw== Date: Sat, 11 Jun 2022 15:30:15 +0100 From: Jonathan Cameron To: Nuno =?UTF-8?B?U8Oh?= Cc: , , , , , Lad Prabhakar , , , , , , Cai Huoqing , Benjamin Fair , Jishnu Prakash , "Linus Walleij" , Lars-Peter Clausen , Alexandre Torgue , Amit Kucheria , Andy Gross , Michael Hennerich , Haibo Chen , Benson Leung , "Rafael J. Wysocki" , "Alexandre Belloni" , Christophe Branchereau , Patrick Venture , Arnd Bergmann , Nancy Yuen , Sascha Hauer , Daniel Lezcano , "Gwendal Grignou" , Saravanan Sekar , "Tali Perry" , Maxime Coquelin , Paul Cercueil , Thara Gopinath , Avi Fishman , "Lorenzo Bianconi" , Claudiu Beznea , Pengutronix Kernel Team , Andy Shevchenko , Fabrice Gasnier , Matthias Brugger , Tomer Maimon , Bjorn Andersson , "Nicolas Ferre" , Zhang Rui , Shawn Guo , "Guenter Roeck" , Fabio Estevam , "Olivier Moysan" , Eugen Hristev , Miquel Raynal Subject: Re: [PATCH 19/34] iio: core: drop of.h from iio.h Message-ID: <20220611153016.2f91d7e5@jic23-huawei> In-Reply-To: <20220610084545.547700-20-nuno.sa@analog.com> References: <20220610084545.547700-1-nuno.sa@analog.com> <20220610084545.547700-20-nuno.sa@analog.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 10 Jun 2022 10:45:30 +0200 Nuno S=C3=A1 wrote: > There is no reason to include OF as we only need to forward declare > 'of_phandle_args'. Previously, some drivers were actually relying on > this for some headers (those were already fixed). >=20 > Signed-off-by: Nuno S=C3=A1 This one deserves a 'woot' :) I would have guessed we were much further off being able to do this than the 18 patches earlier in this series. Good work from Andy and yourself to get to the point where this was possible. Applied to the togreg branch of iio.git and pushed out as testing for 0-day to take a look. I'm probably going to review the remainder, but leave on list a bit longer as they are more complex/controversial than this includes cleanup. Thanks, Jonathan > --- > include/linux/iio/iio.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h > index 4e21a82b3756..d9b4a9ca9a0f 100644 > --- a/include/linux/iio/iio.h > +++ b/include/linux/iio/iio.h > @@ -11,13 +11,14 @@ > #include > #include > #include > -#include > /* IIO TODO LIST */ > /* > * Provide means of adjusting timer accuracy. > * Currently assumes nano seconds. > */ > =20 > +struct of_phandle_args; > + > enum iio_shared_by { > IIO_SEPARATE, > IIO_SHARED_BY_TYPE, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3AA6C433EF for ; Sat, 11 Jun 2022 14:21:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u6Tt/YrGgVV6wxhPW/+xHUORmEH34kE8cOZAKQXZmtg=; b=FvIjfjcIbcG2Qy OGfyveTjFoRZt0BpEupW1XgJ+3Nt/+lX3DQ9vDUsRaIwHaWDiy3++PxypRfwdz0Xvm/g3nim5tbT9 ASnC5Ho2zdVT7T8fvmKmuj+3Atxk/yLOzq3TkMnoWcwRXnO4DLczTRSsxSH5wESo+w7Epfq7sCQxq O2qE4Vo7gDxw1WcmoGZtjYPqZl8FMnklbnsrMyw1WXmpxMvY+IT29dGBYMmOJBWX2e1kJAKrHFx08 fSw7X21+Y+EBqIHX0npPscUoP0KWlIGe4vXwZGgnkhxuY6TURuFrRqIuVdoYaGRP+XdzHJjzq2EK/ jQpgGNRAm80MRo4bd/pQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o01zQ-00DHXc-Na; Sat, 11 Jun 2022 14:21:24 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o01zN-00DHW3-01; Sat, 11 Jun 2022 14:21:22 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 54E41B816A6; Sat, 11 Jun 2022 14:21:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 454F6C34116; Sat, 11 Jun 2022 14:21:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654957277; bh=lfyWxTdm+9DA2o5Gv4TMOK79YAUDNtuhApIhJjT70sc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oCVbMFgyFX6oFH9u3+7f5Hm4+q5RYHvp3rgC4dsE0IEQZXvrtnPlXfQnAAnejz0xR lkmxE/CIR1fCuZZ1eU3ZYl5amkKuaOVsuPrh6pXb2TtzM4ufNY7k1LT1YVEAZ0QUc9 8kFKGWJz6+JPx7xwmpXMHQ0suVKcRhwqQiando1XDqH+x4ErQgXo+eWTv7qOtiS2Kk 7sEjS2O1A+ImNtfVji8lSkOMnMR/LIKBCWMg10V5/81/grKwvV8ar0Y3R0FBH7igf4 Hx1sU60YSsy+PE4LPbaCFaBA840/DS4NcKtTAOlTrHnPRvu+fg3VnT5Fr7aAFuXBk8 iv+MSeL9C6Jnw== Date: Sat, 11 Jun 2022 15:30:15 +0100 From: Jonathan Cameron To: Nuno =?UTF-8?B?U8Oh?= Cc: , , , , , Lad Prabhakar , , , , , , Cai Huoqing , Benjamin Fair , Jishnu Prakash , "Linus Walleij" , Lars-Peter Clausen , Alexandre Torgue , Amit Kucheria , Andy Gross , Michael Hennerich , Haibo Chen , Benson Leung , "Rafael J. Wysocki" , "Alexandre Belloni" , Christophe Branchereau , Patrick Venture , Arnd Bergmann , Nancy Yuen , Sascha Hauer , Daniel Lezcano , "Gwendal Grignou" , Saravanan Sekar , "Tali Perry" , Maxime Coquelin , Paul Cercueil , Thara Gopinath , Avi Fishman , "Lorenzo Bianconi" , Claudiu Beznea , Pengutronix Kernel Team , Andy Shevchenko , Fabrice Gasnier , Matthias Brugger , Tomer Maimon , Bjorn Andersson , "Nicolas Ferre" , Zhang Rui , Shawn Guo , "Guenter Roeck" , Fabio Estevam , "Olivier Moysan" , Eugen Hristev , Miquel Raynal Subject: Re: [PATCH 19/34] iio: core: drop of.h from iio.h Message-ID: <20220611153016.2f91d7e5@jic23-huawei> In-Reply-To: <20220610084545.547700-20-nuno.sa@analog.com> References: <20220610084545.547700-1-nuno.sa@analog.com> <20220610084545.547700-20-nuno.sa@analog.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220611_072121_575265_2B52B575 X-CRM114-Status: GOOD ( 18.29 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org T24gRnJpLCAxMCBKdW4gMjAyMiAxMDo0NTozMCArMDIwMApOdW5vIFPDoSA8bnVuby5zYUBhbmFs b2cuY29tPiB3cm90ZToKCj4gVGhlcmUgaXMgbm8gcmVhc29uIHRvIGluY2x1ZGUgT0YgYXMgd2Ug b25seSBuZWVkIHRvIGZvcndhcmQgZGVjbGFyZQo+ICdvZl9waGFuZGxlX2FyZ3MnLiBQcmV2aW91 c2x5LCBzb21lIGRyaXZlcnMgd2VyZSBhY3R1YWxseSByZWx5aW5nIG9uCj4gdGhpcyBmb3Igc29t ZSBoZWFkZXJzICh0aG9zZSB3ZXJlIGFscmVhZHkgZml4ZWQpLgo+IAo+IFNpZ25lZC1vZmYtYnk6 IE51bm8gU8OhIDxudW5vLnNhQGFuYWxvZy5jb20+ClRoaXMgb25lIGRlc2VydmVzIGEgJ3dvb3Qn IDopCgpJIHdvdWxkIGhhdmUgZ3Vlc3NlZCB3ZSB3ZXJlIG11Y2ggZnVydGhlciBvZmYgYmVpbmcg YWJsZSB0byBkbyB0aGlzCnRoYW4gdGhlIDE4IHBhdGNoZXMgZWFybGllciBpbiB0aGlzIHNlcmll cy4gR29vZCB3b3JrIGZyb20gQW5keQphbmQgeW91cnNlbGYgdG8gZ2V0IHRvIHRoZSBwb2ludCB3 aGVyZSB0aGlzIHdhcyBwb3NzaWJsZS4KCkFwcGxpZWQgdG8gdGhlIHRvZ3JlZyBicmFuY2ggb2Yg aWlvLmdpdCBhbmQgcHVzaGVkIG91dCBhcyB0ZXN0aW5nIGZvcgowLWRheSB0byB0YWtlIGEgbG9v ay4gIEknbSBwcm9iYWJseSBnb2luZyB0byByZXZpZXcgdGhlIHJlbWFpbmRlciwgYnV0CmxlYXZl IG9uIGxpc3QgYSBiaXQgbG9uZ2VyIGFzIHRoZXkgYXJlIG1vcmUgY29tcGxleC9jb250cm92ZXJz aWFsIHRoYW4KdGhpcyBpbmNsdWRlcyBjbGVhbnVwLgoKVGhhbmtzLAoKSm9uYXRoYW4KCj4gLS0t Cj4gIGluY2x1ZGUvbGludXgvaWlvL2lpby5oIHwgMyArKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDIg aW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xp bnV4L2lpby9paW8uaCBiL2luY2x1ZGUvbGludXgvaWlvL2lpby5oCj4gaW5kZXggNGUyMWE4MmIz NzU2Li5kOWI0YTljYTlhMGYgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51eC9paW8vaWlvLmgK PiArKysgYi9pbmNsdWRlL2xpbnV4L2lpby9paW8uaAo+IEBAIC0xMSwxMyArMTEsMTQgQEAKPiAg I2luY2x1ZGUgPGxpbnV4L2NkZXYuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4KPiAgI2lu Y2x1ZGUgPGxpbnV4L2lpby90eXBlcy5oPgo+IC0jaW5jbHVkZSA8bGludXgvb2YuaD4KPiAgLyog SUlPIFRPRE8gTElTVCAqLwo+ICAvKgo+ICAgKiBQcm92aWRlIG1lYW5zIG9mIGFkanVzdGluZyB0 aW1lciBhY2N1cmFjeS4KPiAgICogQ3VycmVudGx5IGFzc3VtZXMgbmFubyBzZWNvbmRzLgo+ICAg Ki8KPiAgCj4gK3N0cnVjdCBvZl9waGFuZGxlX2FyZ3M7Cj4gKwo+ICBlbnVtIGlpb19zaGFyZWRf Ynkgewo+ICAJSUlPX1NFUEFSQVRFLAo+ICAJSUlPX1NIQVJFRF9CWV9UWVBFLAoKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LW1lZGlhdGVrIG1h aWxpbmcgbGlzdApMaW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbWVkaWF0ZWsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BBA0C433EF for ; Thu, 16 Jun 2022 02:37:16 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LNmXp6Pqwz3fCp for ; Thu, 16 Jun 2022 12:37:14 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=oCVbMFgy; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4601:e00::1; helo=ams.source.kernel.org; envelope-from=jic23@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=oCVbMFgy; dkim-atps=neutral Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LL0PY1Bbmz3byT for ; Sun, 12 Jun 2022 00:21:21 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 54E41B816A6; Sat, 11 Jun 2022 14:21:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 454F6C34116; Sat, 11 Jun 2022 14:21:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654957277; bh=lfyWxTdm+9DA2o5Gv4TMOK79YAUDNtuhApIhJjT70sc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oCVbMFgyFX6oFH9u3+7f5Hm4+q5RYHvp3rgC4dsE0IEQZXvrtnPlXfQnAAnejz0xR lkmxE/CIR1fCuZZ1eU3ZYl5amkKuaOVsuPrh6pXb2TtzM4ufNY7k1LT1YVEAZ0QUc9 8kFKGWJz6+JPx7xwmpXMHQ0suVKcRhwqQiando1XDqH+x4ErQgXo+eWTv7qOtiS2Kk 7sEjS2O1A+ImNtfVji8lSkOMnMR/LIKBCWMg10V5/81/grKwvV8ar0Y3R0FBH7igf4 Hx1sU60YSsy+PE4LPbaCFaBA840/DS4NcKtTAOlTrHnPRvu+fg3VnT5Fr7aAFuXBk8 iv+MSeL9C6Jnw== Date: Sat, 11 Jun 2022 15:30:15 +0100 From: Jonathan Cameron To: Nuno =?UTF-8?B?U8Oh?= Subject: Re: [PATCH 19/34] iio: core: drop of.h from iio.h Message-ID: <20220611153016.2f91d7e5@jic23-huawei> In-Reply-To: <20220610084545.547700-20-nuno.sa@analog.com> References: <20220610084545.547700-1-nuno.sa@analog.com> <20220610084545.547700-20-nuno.sa@analog.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Thu, 16 Jun 2022 12:05:37 +1000 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Daniel Lezcano , Tomer Maimon , "Rafael J. Wysocki" , linux-iio@vger.kernel.org, Linus Walleij , Amit Kucheria , Alexandre Torgue , Tali Perry , Paul Cercueil , Miquel Raynal , Guenter Roeck , Fabio Estevam , linux-stm32@st-md-mailman.stormreply.com, chrome-platform@lists.linux.dev, Lars-Peter Clausen , Benjamin Fair , openbmc@lists.ozlabs.org, Jishnu Prakash , Haibo Chen , Andy Shevchenko , Andy Gross , linux-imx@nxp.com, Olivier Moysan , Zhang Rui , Christophe Branchereau , Saravanan Sekar , Michael Hennerich , linux-arm-msm@vger.kernel.org, Sascha Hauer , Nicolas Ferre , Lad Prabhakar , Fabrice Gasnier , linux-mediatek@lists.infradead.org, Eugen Hristev , Matthias Brugger , Gwendal Grignou , Bjorn Andersson , Benson Leung , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org, Lorenzo Bianconi , Avi Fishman , Patrick Venture , linux-mips@vger.kernel.org, Thara Gopinath , linux-renesas-soc@vger.kernel.org, Arnd Bergmann , Maxime Coquelin , Cai Huoqing , Shawn Guo , Claudiu Beznea Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Fri, 10 Jun 2022 10:45:30 +0200 Nuno S=C3=A1 wrote: > There is no reason to include OF as we only need to forward declare > 'of_phandle_args'. Previously, some drivers were actually relying on > this for some headers (those were already fixed). >=20 > Signed-off-by: Nuno S=C3=A1 This one deserves a 'woot' :) I would have guessed we were much further off being able to do this than the 18 patches earlier in this series. Good work from Andy and yourself to get to the point where this was possible. Applied to the togreg branch of iio.git and pushed out as testing for 0-day to take a look. I'm probably going to review the remainder, but leave on list a bit longer as they are more complex/controversial than this includes cleanup. Thanks, Jonathan > --- > include/linux/iio/iio.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h > index 4e21a82b3756..d9b4a9ca9a0f 100644 > --- a/include/linux/iio/iio.h > +++ b/include/linux/iio/iio.h > @@ -11,13 +11,14 @@ > #include > #include > #include > -#include > /* IIO TODO LIST */ > /* > * Provide means of adjusting timer accuracy. > * Currently assumes nano seconds. > */ > =20 > +struct of_phandle_args; > + > enum iio_shared_by { > IIO_SEPARATE, > IIO_SHARED_BY_TYPE,