Re: [Buildroot] [PATCH 1/1] package/libnetconf2: doesn't build with libressl

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Fabrice, All,

On 2022-06-11 16:57 +0200, Fabrice Fontaine spake thusly:
> libnetconf2 doesn't build with libressl which doesn't provide
> X509_STORE_CTX_get1_certs resulting in the following build failure with
> netopeer2:
> 
> [100%] Linking C executable netopeer2-server
> /home/buildroot/autobuild/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/microblaze-buildroot-linux-gnu/11.2.0/../../../../microblaze-buildroot-linux-gnu/bin/ld: /home/buildroot/autobuild/instance-3/output-1/host/microblaze-buildroot-linux-gnu/sysroot/usr/lib/libnetconf2.so: undefined reference to `X509_STORE_CTX_get1_certs'
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/7f9a114a477e859dfbc62a53ab66c58eddb2318b
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libnetconf2/libnetconf2.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libnetconf2/libnetconf2.mk b/package/libnetconf2/libnetconf2.mk
> index 11a1995ea1..00d2c08f63 100644
> --- a/package/libnetconf2/libnetconf2.mk
> +++ b/package/libnetconf2/libnetconf2.mk
> @@ -23,7 +23,7 @@ else
>  LIBNETCONF2_CONF_OPTS += -DENABLE_SSH=OFF
>  endif
>  
> -ifeq ($(BR2_PACKAGE_OPENSSL), y)
> +ifeq ($(BR2_PACKAGE_LIBOPENSSL), y)

I was wondering if libnetconf2 should instead just select
BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL so that it is obvious in the
menuconfig.

I mena, by selecting BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL, a user who
enables openssl will see that libressl is not availble, while with your
solution, openssl is enabled with libressl, yet libnetconf2 is not built
with ssl support, which can be a bit confusing to some.

Yet, I am not sure what the proper solution is, and I cold not find a
precedent either way. So, applied to master, thanks.

Regards,
Yann E. MORIN.

>  LIBNETCONF2_CONF_OPTS += -DENABLE_TLS=ON
>  LIBNETCONF2_DEPENDENCIES += openssl
>  else
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot