From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
Buildroot Mailing List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v3, 1/1] package/zstd: fix build without threads
Date: Sun, 12 Jun 2022 20:47:42 +0200 [thread overview]
Message-ID: <20220612184742.GJ427639@scaer> (raw)
In-Reply-To: <CAPi7W82dd-8u-c45xe8yBJRkw9nLY68yB9HTSANXPhxWMF=vvA@mail.gmail.com>
Fabrice, All,
On 2022-06-12 20:13 +0200, Fabrice Fontaine spake thusly:
> Le dim. 12 juin 2022 à 19:13, Yann E. MORIN <yann.morin.1998@free.fr> a écrit :
> > On 2022-06-12 18:02 +0200, Fabrice Fontaine spake thusly:
> > > Move libzstd.pc in ZSTD_BUILD_LIBS so it will be suffixed by -nomt
> > > without threads. As a result, libzstd.pc will not contain -pthread in
> > > Libs.Private which will avoid the following static build failure with
> > > zchunk) raised since commit 0f0e913f10caf21f23c2e46f210519a7a3bc0b32:
> > >
> > > /home/buildroot/autobuild/instance-2/output-1/host/bin/aarch64_be-buildroot-linux-uclibc-gcc -o src/unzck src/unzck.p/unzck.c.o src/unzck.p/util_common.c.o -Wl,--as-needed -Wl,--no-undefined -static -Wl,--start-group src/lib/libzck.a -largp /home/buildroot/autobuild/instance-2/output-1/host/aarch64_be-buildroot-linux-uclibc/sysroot/usr/lib/libzstd.a -pthread /home/buildroot/autobuild/instance-2/output-1/host/aarch64_be-buildroot-linux-uclibc/sysroot/usr/lib/libssl.a /home/buildroot/autobuild/instance-2/output-1/host/aarch64_be-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.a -Wl,--end-group
> > > /home/buildroot/autobuild/instance-2/output-1/host/lib/gcc/aarch64_be-buildroot-linux-uclibc/10.3.0/../../../../aarch64_be-buildroot-linux-uclibc/bin/ld: cannot find -lpthread
> > >
> > > Fixes:
> > > - http://autobuild.buildroot.org/results/481d1979920daaecac48dec763151e124651740f
> > So, I was very curious how the weird buildsystem for zstd would cope,
> > and I am afraid it does not cope well:
> >
> > $ wget -O .config 'http://autobuild.buildroot.org/results/481d1979920daaecac48dec763151e124651740f/config'
> > $ make menuconfig
> > -> switch to a bootlin toolchain (uClibc only, similar to the
> > failing build)
> Why are you switching to a different toolchain instead of using the
> same defconfig?
To speed up the build...
> Indeed, to my understanding of
> toolchain/toolchain-external/toolchain-external-bootlin/Config.in.options,
> all uclibc bootlin toolchains have thread support ...
Good point. Lemme retry that, then.
> If needed, I can send a v4 that applies cleanly on master.
That will no be necessary, I can fix it up when applying.
However, do you have local changes on zstd, that you will be sending
next?
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-06-12 18:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-12 16:02 [Buildroot] [PATCH v3, 1/1] package/zstd: fix build without threads Fabrice Fontaine
2022-06-12 17:13 ` Yann E. MORIN
2022-06-12 17:40 ` Yann E. MORIN
2022-06-12 18:13 ` Fabrice Fontaine
2022-06-12 18:47 ` Yann E. MORIN [this message]
2022-06-12 19:36 ` Yann E. MORIN
2022-06-19 13:40 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220612184742.GJ427639@scaer \
--to=yann.morin.1998@free.fr \
--cc=andrew.smirnov@gmail.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.