From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDC51C433EF for ; Mon, 13 Jun 2022 05:54:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a/lURRdV6vMamJioV2KSQtezguqQLgzzsSZPVq2yxp8=; b=yLqvXeN19UpCJL sOb9sVAFcpO+v7T2mxPpuuBbXDjnmWAjqb17S9Seiwa9dza6ha1Br0tcGgV6M/QS/Tavh7M1TktMj WZwJkmMShJCGeqUAp+c6A8YsS7rguCzOXkYcHgRGcI19snMLI0d+p33Rma/GgyVozV+yBSB925f/x 5PD/iF6mOq5hxKRYLKcFJIMcJOGTimgnGGK+23kffXdsu39nubIQW/02EeFoQWCARq+ZjKm5LctD+ QserI3jQayXC88UdHuKmPobJWaUKxQFU0ETQyE7el8ULAfpZGa2x1Tl6ZwtoSaw3WQSbIQAb5JJ4W hm8i4TRRRBMVVlegEMCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0d1K-001Z2r-Io; Mon, 13 Jun 2022 05:53:50 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0d1H-001Z1x-3B for linux-arm-kernel@lists.infradead.org; Mon, 13 Jun 2022 05:53:48 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 6CA0568AA6; Mon, 13 Jun 2022 07:53:43 +0200 (CEST) Date: Mon, 13 Jun 2022 07:53:43 +0200 From: Christoph Hellwig To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, Ard Biesheuvel , Christoph Hellwig , Catalin Marinas , Robin Murphy , Russell King Subject: Re: [PATCH 2/2] arm64: mm: Remove assembly DMA cache maintenance wrappers Message-ID: <20220613055343.GA32221@lst.de> References: <20220610151228.4562-1-will@kernel.org> <20220610151228.4562-3-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220610151228.4562-3-will@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220612_225347_321314_49BCEBA1 X-CRM114-Status: GOOD ( 12.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 10, 2022 at 04:12:28PM +0100, Will Deacon wrote: > Remove the __dma_{flush,map,unmap}_area assembly wrappers and call the > appropriate cache maintenance functions directly from the DMA mapping > callbacks. Thanks, this looks so much nicer. Is there any good reason why the C prototypes for the assembly function take an unsigned long instead of a void *, though? It seems like all or almost all of the callers have a pointer at hand an do silly casts for the assembly code that could work perfectly fine with a pointer and length. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel