From: "Michael S. Tsirkin" <mst@redhat.com>
To: 黄杰 <huangjie.albert@bytedance.com>
Cc: yuanzhu@bytedance.com, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_ring : fix vring_packed_desc memory out of bounds bug
Date: Mon, 13 Jun 2022 10:20:07 -0400 [thread overview]
Message-ID: <20220613101918-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CABKxMyOXuqSLZs71UVRK+_=ehpBwpo1Ft_20V_Go8aN8zX+b9Q@mail.gmail.com>
On Mon, Jun 13, 2022 at 10:17:58PM +0800, 黄杰 wrote:
> OK, thank you for the explanation, I get it. By the way, if we could
> fix the the OOB access first, it seems that even if we do this, the
> OOB access also exists.
> > I think we can do this since 16bit/32bit operations are guaranteed to be atomic.
>
> BR
Presumably as we are reworking the code we'll make sure any value
written into last_used_idx is within bounds.
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-06-13 14:20 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220610103314.61577-1-huangjie.albert@bytedance.com>
2022-06-10 14:50 ` [PATCH] virtio_ring : fix vring_packed_desc memory out of bounds bug Michael S. Tsirkin
[not found] ` <CABKxMyPTLJ0bbxb23C_aeucVEP8MYNiFz1y9d8eGA4Bvdyey3g@mail.gmail.com>
2022-06-11 0:35 ` [External] " Michael S. Tsirkin
[not found] ` <CABKxMyOYrjUDvWggK=rnBZcRuaO9x=wHWq15MgAQz5_Fbtypxg@mail.gmail.com>
2022-06-12 14:13 ` Michael S. Tsirkin
[not found] ` <CABKxMyMiOhRSp5_VOZ2Sh8q7Ef3+hnZmALHazwii0hR3SfRZWg@mail.gmail.com>
2022-06-13 8:55 ` Michael S. Tsirkin
[not found] ` <CABKxMyM5fvH6pGzPxqz1aRHbv8BX+xFfwyJi4zqqTA89RULs5w@mail.gmail.com>
2022-06-13 14:07 ` Michael S. Tsirkin
[not found] ` <CABKxMyOXuqSLZs71UVRK+_=ehpBwpo1Ft_20V_Go8aN8zX+b9Q@mail.gmail.com>
2022-06-13 14:20 ` Michael S. Tsirkin [this message]
2022-06-13 6:56 ` Jason Wang
2022-06-13 14:04 ` Michael S. Tsirkin
2022-06-14 5:37 ` [PATCH] virtio_ring : keep used_wrap_counter in vq->last_used_idx Albert Huang
2022-06-14 7:45 ` Jason Wang
2022-06-14 7:45 ` Jason Wang
2022-06-14 8:16 ` 黄杰
2022-06-14 8:21 ` Jason Wang
2022-06-14 8:21 ` Jason Wang
2022-06-15 3:25 ` 黄杰
2022-06-15 3:40 ` Jason Wang
2022-06-15 3:40 ` Jason Wang
2022-06-16 5:12 ` [PATCH v2] " Albert Huang
2022-06-16 6:07 ` Michael S. Tsirkin
2022-06-16 6:07 ` Michael S. Tsirkin
2022-06-16 6:42 ` Michael S. Tsirkin
2022-06-16 6:42 ` Michael S. Tsirkin
2022-06-16 7:39 ` [External] " 黄杰
2022-06-16 9:37 ` [PATCH v3] " Albert Huang
2022-06-16 9:48 ` 黄杰
2022-06-16 9:54 ` Albert Huang
2022-06-16 12:21 ` Michael S. Tsirkin
2022-06-16 12:21 ` Michael S. Tsirkin
2022-06-16 12:57 ` [PATCH v4] " Albert Huang
2022-06-16 14:19 ` Michael S. Tsirkin
2022-06-16 14:19 ` Michael S. Tsirkin
2022-06-17 2:04 ` Albert Huang
2022-06-22 8:51 ` Jason Wang
2022-06-22 8:51 ` Jason Wang
2022-06-22 12:16 ` Michael S. Tsirkin
2022-06-22 12:16 ` Michael S. Tsirkin
2022-06-23 1:30 ` Jason Wang
2022-06-23 1:30 ` Jason Wang
2022-06-24 6:23 ` Michael S. Tsirkin
2022-06-24 6:23 ` Michael S. Tsirkin
2022-06-27 2:33 ` Jason Wang
2022-06-27 2:33 ` Jason Wang
2022-06-16 6:41 ` [PATCH v2] " Michael S. Tsirkin
2022-06-16 6:41 ` Michael S. Tsirkin
2022-06-16 7:36 ` [External] " 黄杰
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220613101918-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=huangjie.albert@bytedance.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=yuanzhu@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.