All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hao Xu <hao.xu@linux.dev>
To: io-uring@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>, Pavel Begunkov <asml.silence@gmail.com>
Subject: [PATCH] io_uring: remove duplicate cqe skip check
Date: Mon, 13 Jun 2022 19:22:31 +0800	[thread overview]
Message-ID: <20220613112231.998738-1-hao.xu@linux.dev> (raw)

From: Hao Xu <howeyxu@tencent.com>

Remove duplicate cqe skip check in __io_fill_cqe32_req()

Signed-off-by: Hao Xu <howeyxu@tencent.com>
---
 io_uring/io_uring.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index 1572ebe3cff1..6a94d1682aaf 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -1194,8 +1194,6 @@ static inline void __io_fill_cqe32_req(struct io_kiocb *req, u64 extra1,
 
 	if (WARN_ON_ONCE(!(ctx->flags & IORING_SETUP_CQE32)))
 		return;
-	if (req->flags & REQ_F_CQE_SKIP)
-		return;
 
 	trace_io_uring_complete(ctx, req, req->cqe.user_data, req->cqe.res,
 				req->cqe.flags, extra1, extra2);

base-commit: d8271bf021438f468dab3cd84fe5279b5bbcead8
-- 
2.25.1


             reply	other threads:[~2022-06-13 13:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-13 11:22 Hao Xu [this message]
2022-06-13 21:23 ` [PATCH] io_uring: remove duplicate cqe skip check Jens Axboe
2022-06-14 17:02 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220613112231.998738-1-hao.xu@linux.dev \
    --to=hao.xu@linux.dev \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.