From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D893A1364 for ; Mon, 13 Jun 2022 11:17:42 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CD648D6E; Mon, 13 Jun 2022 04:17:35 -0700 (PDT) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 332CE3F73B; Mon, 13 Jun 2022 04:17:33 -0700 (PDT) Date: Mon, 13 Jun 2022 12:17:29 +0100 From: Andre Przywara To: Samuel Holland Cc: Jernej =?UTF-8?B?xaBrcmFiZWM=?= , Chen-Yu Tsai , Russell King , Bartosz Dudziak , Bjorn Andersson , Krzysztof Kozlowski , Lorenzo Pieralisi , Luca Weiss , Maxime Ripard , Rob Herring , Robin Murphy , Stephan Gerhold , Thierry Reding , Vinod Koul , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 0/3] ARM: sunxi: Remove A31 and A23/A33 platform SMP code Message-ID: <20220613121729.46233a75@donnerap.cambridge.arm.com> In-Reply-To: <2833034.e9J7NaK4W3@kista> References: <20220531045038.42230-1-samuel@sholland.org> <2833034.e9J7NaK4W3@kista> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 12 Jun 2022 23:09:07 +0200 Jernej =C5=A0krabec wrote: Hi Samuel, > Dne torek, 31. maj 2022 ob 06:50:35 CEST je Samuel Holland napisal(a): > > This series is preparation for converting the PRCM MFD and legacy clock > > drivers to a CCU clock driver. May I ask what the purpose of this exercise is? So if I understand correctly, then it's about to convert the sun8i-a23-prcm MFD driver and its children to a single "modern style" CCU clock driver, with its opaque DT node? If that changes the compatible strings or the references to the clock providers (and I guess it would need to?), then this would mean an incompatible change. Which also means we would need to keep the old code around, to maintain compatibility with "old" DTs? So what is the win then? Now we have *two* clock drivers, for the same device, which need maintenance and testing. So can you confirm that this will be a breaking change? > The platform SMP code references the PRCM > > node to map its MMIO space, which will break when the PRCM node is > > removed/replaced. =20 >=20 > Why can't we just leave old platform code? If older dtb file is used, it = would=20 > still work. Actually, isn't trivial to support new CCU binding too, just = by=20 > including new CCU compatible string? IIUC new CCU node will have same add= ress=20 > as current PRCM node. This aims for a similar direction, though in this case the alternative (PSCI) predates the sunxi specific method in the kernel support. Can we just deprecate this code, maybe issue a warning, with the hint to update the bootloader (which might not be possible for some devices)? Cheers, Andre > Best regards, > Jernej >=20 > >=20 > > Since PSCI has been available for 7+ years, instead of trying to deal > > with the migration, I think it's safe to just delete this code. > >=20 > >=20 > > Samuel Holland (3): > > ARM: sunxi: Remove A31 and A23/A33 platform SMP code > > ARM: dts: sunxi: Remove obsolete CPU enable methods > > dt-bindings: arm: Remove obsolete CPU enable methods > >=20 > > .../devicetree/bindings/arm/cpus.yaml | 2 - > > arch/arm/boot/dts/sun6i-a31.dtsi | 1 - > > arch/arm/boot/dts/sun8i-a23-a33.dtsi | 1 - > > arch/arm/mach-sunxi/Makefile | 1 - > > arch/arm/mach-sunxi/platsmp.c | 194 ------------------ > > 5 files changed, 199 deletions(-) > > delete mode 100644 arch/arm/mach-sunxi/platsmp.c > >=20 > > --=20 > > 2.35.1 > >=20 > > =20 >=20 >=20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 314ECC433EF for ; Mon, 13 Jun 2022 11:25:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sIeeLMr1UNTee/0n/sTJasNcUGCa72OVRI+zmbv02Ic=; b=b8J3zgbwGHDd/a aRTKWmyj5p6uiqWdMnWxj2AoIj/+L2nRejShPGiUnYCpdQ1G797h2eKWdgOmcuYepwN3y9phdZ24B NAGCUqtL2xntJOm74L+o5M9N/0aRUnoBgLgwrObVmf2XbyHulaZG+KCo3vGwZxG+mGchNEZ3G3HoR 3PC7MDCp4+cqpdN83ctHcEtJdN7SniB/kG0Pw4UqZiVF0ufTZKzDw9iWFz/FnUa79az6rTd5xU6Ck hgrYBhhM6QfPBi+S0pswQydUKT3SqhvKfvPpphjjLwSy1COUrgv0MM7Yvtqn+5zW3GqaeqFayEWyM 0/afLtLB7J+sloKmOfCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0iBS-003CJO-B9; Mon, 13 Jun 2022 11:24:39 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0i4n-0038lG-RT for linux-arm-kernel@lists.infradead.org; Mon, 13 Jun 2022 11:17:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CD648D6E; Mon, 13 Jun 2022 04:17:35 -0700 (PDT) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 332CE3F73B; Mon, 13 Jun 2022 04:17:33 -0700 (PDT) Date: Mon, 13 Jun 2022 12:17:29 +0100 From: Andre Przywara To: Samuel Holland Cc: Jernej =?UTF-8?B?xaBrcmFiZWM=?= , Chen-Yu Tsai , Russell King , Bartosz Dudziak , Bjorn Andersson , Krzysztof Kozlowski , Lorenzo Pieralisi , Luca Weiss , Maxime Ripard , Rob Herring , Robin Murphy , Stephan Gerhold , Thierry Reding , Vinod Koul , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 0/3] ARM: sunxi: Remove A31 and A23/A33 platform SMP code Message-ID: <20220613121729.46233a75@donnerap.cambridge.arm.com> In-Reply-To: <2833034.e9J7NaK4W3@kista> References: <20220531045038.42230-1-samuel@sholland.org> <2833034.e9J7NaK4W3@kista> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220613_041746_020179_D2D0895A X-CRM114-Status: GOOD ( 26.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCAxMiBKdW4gMjAyMiAyMzowOTowNyArMDIwMApKZXJuZWogxaBrcmFiZWMgPGplcm5l ai5za3JhYmVjQGdtYWlsLmNvbT4gd3JvdGU6CgpIaSBTYW11ZWwsCgo+IERuZSB0b3JlaywgMzEu IG1haiAyMDIyIG9iIDA2OjUwOjM1IENFU1QgamUgU2FtdWVsIEhvbGxhbmQgbmFwaXNhbChhKToK PiA+IFRoaXMgc2VyaWVzIGlzIHByZXBhcmF0aW9uIGZvciBjb252ZXJ0aW5nIHRoZSBQUkNNIE1G RCBhbmQgbGVnYWN5IGNsb2NrCj4gPiBkcml2ZXJzIHRvIGEgQ0NVIGNsb2NrIGRyaXZlci4KCk1h eSBJIGFzayB3aGF0IHRoZSBwdXJwb3NlIG9mIHRoaXMgZXhlcmNpc2UgaXM/IFNvIGlmIEkgdW5k ZXJzdGFuZApjb3JyZWN0bHksIHRoZW4gaXQncyBhYm91dCB0byBjb252ZXJ0IHRoZSBzdW44aS1h MjMtcHJjbSBNRkQgZHJpdmVyIGFuZAppdHMgY2hpbGRyZW4gdG8gYSBzaW5nbGUgIm1vZGVybiBz dHlsZSIgQ0NVIGNsb2NrIGRyaXZlciwgd2l0aCBpdHMgb3BhcXVlCkRUIG5vZGU/CklmIHRoYXQg Y2hhbmdlcyB0aGUgY29tcGF0aWJsZSBzdHJpbmdzIG9yIHRoZSByZWZlcmVuY2VzIHRvIHRoZSBj bG9jawpwcm92aWRlcnMgKGFuZCBJIGd1ZXNzIGl0IHdvdWxkIG5lZWQgdG8/KSwgdGhlbiB0aGlz IHdvdWxkIG1lYW4gYW4KaW5jb21wYXRpYmxlIGNoYW5nZS4gV2hpY2ggYWxzbyBtZWFucyB3ZSB3 b3VsZCBuZWVkIHRvIGtlZXAgdGhlIG9sZCBjb2RlCmFyb3VuZCwgdG8gbWFpbnRhaW4gY29tcGF0 aWJpbGl0eSB3aXRoICJvbGQiIERUcz8gU28gd2hhdCBpcyB0aGUgd2luIHRoZW4/Ck5vdyB3ZSBo YXZlICp0d28qIGNsb2NrIGRyaXZlcnMsIGZvciB0aGUgc2FtZSBkZXZpY2UsIHdoaWNoIG5lZWQK bWFpbnRlbmFuY2UgYW5kIHRlc3RpbmcuCgpTbyBjYW4geW91IGNvbmZpcm0gdGhhdCB0aGlzIHdp bGwgYmUgYSBicmVha2luZyBjaGFuZ2U/Cgo+IFRoZSBwbGF0Zm9ybSBTTVAgY29kZSByZWZlcmVu Y2VzIHRoZSBQUkNNCj4gPiBub2RlIHRvIG1hcCBpdHMgTU1JTyBzcGFjZSwgd2hpY2ggd2lsbCBi cmVhayB3aGVuIHRoZSBQUkNNIG5vZGUgaXMKPiA+IHJlbW92ZWQvcmVwbGFjZWQuICAKPiAKPiBX aHkgY2FuJ3Qgd2UganVzdCBsZWF2ZSBvbGQgcGxhdGZvcm0gY29kZT8gSWYgb2xkZXIgZHRiIGZp bGUgaXMgdXNlZCwgaXQgd291bGQgCj4gc3RpbGwgd29yay4gQWN0dWFsbHksIGlzbid0IHRyaXZp YWwgdG8gc3VwcG9ydCBuZXcgQ0NVIGJpbmRpbmcgdG9vLCBqdXN0IGJ5IAo+IGluY2x1ZGluZyBu ZXcgQ0NVIGNvbXBhdGlibGUgc3RyaW5nPyBJSVVDIG5ldyBDQ1Ugbm9kZSB3aWxsIGhhdmUgc2Ft ZSBhZGRyZXNzIAo+IGFzIGN1cnJlbnQgUFJDTSBub2RlLgoKVGhpcyBhaW1zIGZvciBhIHNpbWls YXIgZGlyZWN0aW9uLCB0aG91Z2ggaW4gdGhpcyBjYXNlIHRoZSBhbHRlcm5hdGl2ZQooUFNDSSkg cHJlZGF0ZXMgdGhlIHN1bnhpIHNwZWNpZmljIG1ldGhvZCBpbiB0aGUga2VybmVsIHN1cHBvcnQu IENhbiB3ZQpqdXN0IGRlcHJlY2F0ZSB0aGlzIGNvZGUsIG1heWJlIGlzc3VlIGEgd2FybmluZywg d2l0aCB0aGUgaGludCB0byB1cGRhdGUKdGhlIGJvb3Rsb2FkZXIgKHdoaWNoIG1pZ2h0IG5vdCBi ZSBwb3NzaWJsZSBmb3Igc29tZSBkZXZpY2VzKT8KCkNoZWVycywKQW5kcmUKCj4gQmVzdCByZWdh cmRzLAo+IEplcm5lago+IAo+ID4gCj4gPiBTaW5jZSBQU0NJIGhhcyBiZWVuIGF2YWlsYWJsZSBm b3IgNysgeWVhcnMsIGluc3RlYWQgb2YgdHJ5aW5nIHRvIGRlYWwKPiA+IHdpdGggdGhlIG1pZ3Jh dGlvbiwgSSB0aGluayBpdCdzIHNhZmUgdG8ganVzdCBkZWxldGUgdGhpcyBjb2RlLgo+ID4gCj4g PiAKPiA+IFNhbXVlbCBIb2xsYW5kICgzKToKPiA+ICAgQVJNOiBzdW54aTogUmVtb3ZlIEEzMSBh bmQgQTIzL0EzMyBwbGF0Zm9ybSBTTVAgY29kZQo+ID4gICBBUk06IGR0czogc3VueGk6IFJlbW92 ZSBvYnNvbGV0ZSBDUFUgZW5hYmxlIG1ldGhvZHMKPiA+ICAgZHQtYmluZGluZ3M6IGFybTogUmVt b3ZlIG9ic29sZXRlIENQVSBlbmFibGUgbWV0aG9kcwo+ID4gCj4gPiAgLi4uL2RldmljZXRyZWUv YmluZGluZ3MvYXJtL2NwdXMueWFtbCAgICAgICAgIHwgICAyIC0KPiA+ICBhcmNoL2FybS9ib290 L2R0cy9zdW42aS1hMzEuZHRzaSAgICAgICAgICAgICAgfCAgIDEgLQo+ID4gIGFyY2gvYXJtL2Jv b3QvZHRzL3N1bjhpLWEyMy1hMzMuZHRzaSAgICAgICAgICB8ICAgMSAtCj4gPiAgYXJjaC9hcm0v bWFjaC1zdW54aS9NYWtlZmlsZSAgICAgICAgICAgICAgICAgIHwgICAxIC0KPiA+ICBhcmNoL2Fy bS9tYWNoLXN1bnhpL3BsYXRzbXAuYyAgICAgICAgICAgICAgICAgfCAxOTQgLS0tLS0tLS0tLS0t LS0tLS0tCj4gPiAgNSBmaWxlcyBjaGFuZ2VkLCAxOTkgZGVsZXRpb25zKC0pCj4gPiAgZGVsZXRl IG1vZGUgMTAwNjQ0IGFyY2gvYXJtL21hY2gtc3VueGkvcGxhdHNtcC5jCj4gPiAKPiA+IC0tIAo+ ID4gMi4zNS4xCj4gPiAKPiA+ICAgCj4gCj4gCj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=