From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A824C433EF for ; Mon, 13 Jun 2022 20:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=40SVBtXnGfrC3ENbgOhTBVY6NsZ6lgtuqKzJhtfcca4=; b=zGWnV+K6k8y6rB vdavuKaa9Js8G+fYzZCHirzqDuhojzyk0fMwiNa91OhEarpH1XMWBvWPcnejPh7saYCMkJ/Rwbk2q aofTtxLx7Nwbr/9siqqktQvBj+8FEtN4W4RId1kWGoGcANQOpmfevS/+dilAhhZIKnXAYXZmhpuBR N8g4XsxLH9AcTaGsZRmo6T/qGtn0Hj77E+yiT+aosHeetZfZBjgifUydimKZKh/PIL1lo20Fcu8Nk NguvZ/0MlTlme3XuCuI4eM0T2wttpYp55zfQERa8PbSKrE2Te5nfNZOmxGoOX5sx99nKK/zOgh1Nk Xk8yoDEPyDmAx83Ns4rA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0qys-005mu2-7T; Mon, 13 Jun 2022 20:48:14 +0000 Received: from mail-il1-f176.google.com ([209.85.166.176]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0qyn-005msr-Tj; Mon, 13 Jun 2022 20:48:11 +0000 Received: by mail-il1-f176.google.com with SMTP id z11so5164530ilq.6; Mon, 13 Jun 2022 13:48:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/dzRBMIn98y05EN99Sgq5WDsEwo7wpH66xTE6XCo/M4=; b=QlOoUzlj+BGDjIMX98sYZ07evySSX16e7LY1VRIZ3qklSw3h4XypJR3aQKI6peUzzD 3b0q9Uu+rrHPaPacV7QuuBzXa1qj4lFjJGo7mLVbD2dMQh+DemmoHxIjWTQKgDnVAZRC ZTc2l+v8mVOvfape2KyHKd2jJX4cPaSy6Nst/etKqsW26fjiJyJLiF6V3wf53WOaxN5L VjzcAozlZkVRdCb9ZHubwvLKK4TVo7HIbYZmmC+VlSOGBUZNO4hT8scDmiuodicyf3qK ToX/J0R61/C2VSGyPy9rJGijyjt8m5dmdkVCUtyAxpwLTD9G4ZeLMFrSWBs/ds+GoKNH cauw== X-Gm-Message-State: AJIora/48RGaxuNvh8zh03NXHXsqHGc1pvifcGIlFPeQX8Dyvee2+EdH iDIoot/Jb31LJeloXOzKkw== X-Google-Smtp-Source: AGRyM1uVO/KYjaDwGOXreGf4KGdEqy/t353ouqbFZgp5s/y6kuWD2fxXl3ut4zPLn500QHJwX/rd6w== X-Received: by 2002:a92:ca45:0:b0:2d1:b7cf:26a9 with SMTP id q5-20020a92ca45000000b002d1b7cf26a9mr962751ilo.52.1655153288816; Mon, 13 Jun 2022 13:48:08 -0700 (PDT) Received: from robh.at.kernel.org ([69.39.28.171]) by smtp.gmail.com with ESMTPSA id c2-20020a92c8c2000000b002d11397f4f9sm4380280ilq.74.2022.06.13.13.48.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 13:48:08 -0700 (PDT) Received: (nullmailer pid 56167 invoked by uid 1000); Mon, 13 Jun 2022 20:48:06 -0000 Date: Mon, 13 Jun 2022 14:48:06 -0600 From: Rob Herring To: Serge Semin Cc: Bjorn Helgaas , Lorenzo Pieralisi , Kishon Vijay Abraham I , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Jingoo Han , Krzysztof Kozlowski , Alim Akhtar , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Yue Wang , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Chocron , Thomas Petazzoni , Jesper Nilsson , Gustavo Pimentel , Heiko Stuebner , Paul Walmsley , Greentime Hu , Rahul Tanwar , Srikanth Thokala , Xiaowei Song , Binghui Wang , Stanimir Varbanov , Andy Gross , Bjorn Andersson , Pratyush Anand , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Nobuhiro Iwamatsu , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Frank Li , Manivannan Sadhasivam , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@axis.com, linux-rockchip@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v4 15/18] PCI: dwc: Add dw_ prefix to the pcie_port structure name Message-ID: <20220613204806.GA55629-robh@kernel.org> References: <20220610082535.12802-1-Sergey.Semin@baikalelectronics.ru> <20220610082535.12802-16-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220610082535.12802-16-Sergey.Semin@baikalelectronics.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220613_134810_003118_67378BA3 X-CRM114-Status: GOOD ( 16.44 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Fri, Jun 10, 2022 at 11:25:31AM +0300, Serge Semin wrote: > All of the DW PCIe core driver entities have names with the dw_ prefix in > order to easily distinguish local and common PCIe name spaces. All except > the pcie_port structure which contains the DW PCIe Root Port descriptor. > For historical reason the structure has retained the original name since > commit 340cba6092c2 ("pci: Add PCIe driver for Samsung Exynos") when > the DW PCIe IP-core support was added to the kernel. Let's finally fix > that by adding the dw_ prefix to the structure name and by adding the _rp > suffix to be similar to the EP counterpart. Thus the name will be coherent > with the common driver naming policy. It shall make the driver code more > readable eliminating visual confusion between the local and generic PCI > name spaces. > > Signed-off-by: Serge Semin > > --- > > Changelog v4: > - This is a new patch created on the v4 lap of the series. > --- > drivers/pci/controller/dwc/pci-dra7xx.c | 12 +++---- > drivers/pci/controller/dwc/pci-exynos.c | 6 ++-- > drivers/pci/controller/dwc/pci-imx6.c | 6 ++-- > drivers/pci/controller/dwc/pci-keystone.c | 20 +++++------ > drivers/pci/controller/dwc/pci-layerscape.c | 2 +- > drivers/pci/controller/dwc/pci-meson.c | 2 +- > drivers/pci/controller/dwc/pcie-al.c | 6 ++-- > drivers/pci/controller/dwc/pcie-armada8k.c | 4 +-- > drivers/pci/controller/dwc/pcie-artpec6.c | 4 +-- > .../pci/controller/dwc/pcie-designware-host.c | 36 +++++++++---------- > .../pci/controller/dwc/pcie-designware-plat.c | 2 +- > drivers/pci/controller/dwc/pcie-designware.h | 30 ++++++++-------- > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 4 +-- > drivers/pci/controller/dwc/pcie-fu740.c | 2 +- > drivers/pci/controller/dwc/pcie-histb.c | 10 +++--- > drivers/pci/controller/dwc/pcie-intel-gw.c | 6 ++-- > drivers/pci/controller/dwc/pcie-keembay.c | 4 +-- > drivers/pci/controller/dwc/pcie-kirin.c | 2 +- > drivers/pci/controller/dwc/pcie-qcom.c | 4 +-- > drivers/pci/controller/dwc/pcie-spear13xx.c | 6 ++-- > drivers/pci/controller/dwc/pcie-tegra194.c | 22 ++++++------ > drivers/pci/controller/dwc/pcie-uniphier.c | 10 +++--- > drivers/pci/controller/dwc/pcie-visconti.c | 6 ++-- > 23 files changed, 103 insertions(+), 103 deletions(-) Reviewed-by: Rob Herring _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3EB4CCA480 for ; Mon, 13 Jun 2022 21:10:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351959AbiFMVKh (ORCPT ); Mon, 13 Jun 2022 17:10:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238619AbiFMVKR (ORCPT ); Mon, 13 Jun 2022 17:10:17 -0400 Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B7BC2F3A4; Mon, 13 Jun 2022 13:48:09 -0700 (PDT) Received: by mail-il1-f172.google.com with SMTP id y16so5137583ili.13; Mon, 13 Jun 2022 13:48:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/dzRBMIn98y05EN99Sgq5WDsEwo7wpH66xTE6XCo/M4=; b=DK0uhSJYtjiyjLQvTvTq2iUHAujLGBGBiyoTPN+vCrum3bibAC+WLkJ9pTP1QCph3N 0MbMWb3j0SpOpgQKxnMDEs/p9N4WJ7tH4moYqsCTez94Qk67ATaGGLekMJnzDBgYVWsE q9i4sJtScHtQJc6fsEP8fzedyvntjY/xTCMYm9Os8uE/1lGfJDAHoC2GkMHt2UPmf1GL Px4osl3EhxDeLmoY+qTnRtrSD/6zLqH8OoVDAaLfJ8zoYSR5kIwV/hwFrwv7LpNqMTkq 3a0B6WnFYkP2TXGiU3lijF3kogM8nabC/En/c6MqfDLHQTEH64SwE0qMFMG39OIBuS/D AkpA== X-Gm-Message-State: AJIora+1KepHiNcoL+CpPjUXWWIPuT+VEg/BCqu+zMT+QjxiDzXctdpq 6IU1aFCUuWzbfUbZMF6DIA== X-Google-Smtp-Source: AGRyM1uVO/KYjaDwGOXreGf4KGdEqy/t353ouqbFZgp5s/y6kuWD2fxXl3ut4zPLn500QHJwX/rd6w== X-Received: by 2002:a92:ca45:0:b0:2d1:b7cf:26a9 with SMTP id q5-20020a92ca45000000b002d1b7cf26a9mr962751ilo.52.1655153288816; Mon, 13 Jun 2022 13:48:08 -0700 (PDT) Received: from robh.at.kernel.org ([69.39.28.171]) by smtp.gmail.com with ESMTPSA id c2-20020a92c8c2000000b002d11397f4f9sm4380280ilq.74.2022.06.13.13.48.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 13:48:08 -0700 (PDT) Received: (nullmailer pid 56167 invoked by uid 1000); Mon, 13 Jun 2022 20:48:06 -0000 Date: Mon, 13 Jun 2022 14:48:06 -0600 From: Rob Herring To: Serge Semin Cc: Bjorn Helgaas , Lorenzo Pieralisi , Kishon Vijay Abraham I , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Jingoo Han , Krzysztof Kozlowski , Alim Akhtar , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Yue Wang , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Chocron , Thomas Petazzoni , Jesper Nilsson , Gustavo Pimentel , Heiko Stuebner , Paul Walmsley , Greentime Hu , Rahul Tanwar , Srikanth Thokala , Xiaowei Song , Binghui Wang , Stanimir Varbanov , Andy Gross , Bjorn Andersson , Pratyush Anand , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Nobuhiro Iwamatsu , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Frank Li , Manivannan Sadhasivam , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@axis.com, linux-rockchip@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v4 15/18] PCI: dwc: Add dw_ prefix to the pcie_port structure name Message-ID: <20220613204806.GA55629-robh@kernel.org> References: <20220610082535.12802-1-Sergey.Semin@baikalelectronics.ru> <20220610082535.12802-16-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220610082535.12802-16-Sergey.Semin@baikalelectronics.ru> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Jun 10, 2022 at 11:25:31AM +0300, Serge Semin wrote: > All of the DW PCIe core driver entities have names with the dw_ prefix in > order to easily distinguish local and common PCIe name spaces. All except > the pcie_port structure which contains the DW PCIe Root Port descriptor. > For historical reason the structure has retained the original name since > commit 340cba6092c2 ("pci: Add PCIe driver for Samsung Exynos") when > the DW PCIe IP-core support was added to the kernel. Let's finally fix > that by adding the dw_ prefix to the structure name and by adding the _rp > suffix to be similar to the EP counterpart. Thus the name will be coherent > with the common driver naming policy. It shall make the driver code more > readable eliminating visual confusion between the local and generic PCI > name spaces. > > Signed-off-by: Serge Semin > > --- > > Changelog v4: > - This is a new patch created on the v4 lap of the series. > --- > drivers/pci/controller/dwc/pci-dra7xx.c | 12 +++---- > drivers/pci/controller/dwc/pci-exynos.c | 6 ++-- > drivers/pci/controller/dwc/pci-imx6.c | 6 ++-- > drivers/pci/controller/dwc/pci-keystone.c | 20 +++++------ > drivers/pci/controller/dwc/pci-layerscape.c | 2 +- > drivers/pci/controller/dwc/pci-meson.c | 2 +- > drivers/pci/controller/dwc/pcie-al.c | 6 ++-- > drivers/pci/controller/dwc/pcie-armada8k.c | 4 +-- > drivers/pci/controller/dwc/pcie-artpec6.c | 4 +-- > .../pci/controller/dwc/pcie-designware-host.c | 36 +++++++++---------- > .../pci/controller/dwc/pcie-designware-plat.c | 2 +- > drivers/pci/controller/dwc/pcie-designware.h | 30 ++++++++-------- > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 4 +-- > drivers/pci/controller/dwc/pcie-fu740.c | 2 +- > drivers/pci/controller/dwc/pcie-histb.c | 10 +++--- > drivers/pci/controller/dwc/pcie-intel-gw.c | 6 ++-- > drivers/pci/controller/dwc/pcie-keembay.c | 4 +-- > drivers/pci/controller/dwc/pcie-kirin.c | 2 +- > drivers/pci/controller/dwc/pcie-qcom.c | 4 +-- > drivers/pci/controller/dwc/pcie-spear13xx.c | 6 ++-- > drivers/pci/controller/dwc/pcie-tegra194.c | 22 ++++++------ > drivers/pci/controller/dwc/pcie-uniphier.c | 10 +++--- > drivers/pci/controller/dwc/pcie-visconti.c | 6 ++-- > 23 files changed, 103 insertions(+), 103 deletions(-) Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B435EC43334 for ; Mon, 13 Jun 2022 20:48:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0VrLFl/QrXbFMv7DZiTIiLv5BZ7Cb4RNWcXVxMXZn6o=; b=Tnr/SFmuB/hLoh uHRB10ewtGEJ917oKRGE/dwG0fS7Tgsm7eoldLZA3dQkv1o8Wu6HhgGLYCbtVuJbzNkB9oYrkNDTR bg5N3B+P1hKBLhPVOV/noIh74J1+HTJq3GUB8VNF0Ge3dpjo0TvkLJVlsW8w1wbm+LZnK0Ii/+jK0 /meZZteir2hRMAXVREvko6tDv+3bDMJSQPO0zK3Oj4zstirIAxQfIaXcTYIcJPNKPDXdv5XsIsAbo /Hbr+NMnaPMzs4fimdGJGKRQW9EjIW9JXRWWKtLxQ+8VpyUq1UHhTRhQiqNKGxHwSg24G4oeSsC5l iTxDdFs3OEuk6BhgC3rA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0qys-005mu9-Lu; Mon, 13 Jun 2022 20:48:14 +0000 Received: from mail-il1-f176.google.com ([209.85.166.176]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0qyn-005msr-Tj; Mon, 13 Jun 2022 20:48:11 +0000 Received: by mail-il1-f176.google.com with SMTP id z11so5164530ilq.6; Mon, 13 Jun 2022 13:48:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/dzRBMIn98y05EN99Sgq5WDsEwo7wpH66xTE6XCo/M4=; b=QlOoUzlj+BGDjIMX98sYZ07evySSX16e7LY1VRIZ3qklSw3h4XypJR3aQKI6peUzzD 3b0q9Uu+rrHPaPacV7QuuBzXa1qj4lFjJGo7mLVbD2dMQh+DemmoHxIjWTQKgDnVAZRC ZTc2l+v8mVOvfape2KyHKd2jJX4cPaSy6Nst/etKqsW26fjiJyJLiF6V3wf53WOaxN5L VjzcAozlZkVRdCb9ZHubwvLKK4TVo7HIbYZmmC+VlSOGBUZNO4hT8scDmiuodicyf3qK ToX/J0R61/C2VSGyPy9rJGijyjt8m5dmdkVCUtyAxpwLTD9G4ZeLMFrSWBs/ds+GoKNH cauw== X-Gm-Message-State: AJIora/48RGaxuNvh8zh03NXHXsqHGc1pvifcGIlFPeQX8Dyvee2+EdH iDIoot/Jb31LJeloXOzKkw== X-Google-Smtp-Source: AGRyM1uVO/KYjaDwGOXreGf4KGdEqy/t353ouqbFZgp5s/y6kuWD2fxXl3ut4zPLn500QHJwX/rd6w== X-Received: by 2002:a92:ca45:0:b0:2d1:b7cf:26a9 with SMTP id q5-20020a92ca45000000b002d1b7cf26a9mr962751ilo.52.1655153288816; Mon, 13 Jun 2022 13:48:08 -0700 (PDT) Received: from robh.at.kernel.org ([69.39.28.171]) by smtp.gmail.com with ESMTPSA id c2-20020a92c8c2000000b002d11397f4f9sm4380280ilq.74.2022.06.13.13.48.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 13:48:08 -0700 (PDT) Received: (nullmailer pid 56167 invoked by uid 1000); Mon, 13 Jun 2022 20:48:06 -0000 Date: Mon, 13 Jun 2022 14:48:06 -0600 From: Rob Herring To: Serge Semin Cc: Bjorn Helgaas , Lorenzo Pieralisi , Kishon Vijay Abraham I , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Jingoo Han , Krzysztof Kozlowski , Alim Akhtar , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Yue Wang , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Chocron , Thomas Petazzoni , Jesper Nilsson , Gustavo Pimentel , Heiko Stuebner , Paul Walmsley , Greentime Hu , Rahul Tanwar , Srikanth Thokala , Xiaowei Song , Binghui Wang , Stanimir Varbanov , Andy Gross , Bjorn Andersson , Pratyush Anand , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Nobuhiro Iwamatsu , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Frank Li , Manivannan Sadhasivam , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@axis.com, linux-rockchip@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v4 15/18] PCI: dwc: Add dw_ prefix to the pcie_port structure name Message-ID: <20220613204806.GA55629-robh@kernel.org> References: <20220610082535.12802-1-Sergey.Semin@baikalelectronics.ru> <20220610082535.12802-16-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220610082535.12802-16-Sergey.Semin@baikalelectronics.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220613_134810_003118_67378BA3 X-CRM114-Status: GOOD ( 16.44 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Fri, Jun 10, 2022 at 11:25:31AM +0300, Serge Semin wrote: > All of the DW PCIe core driver entities have names with the dw_ prefix in > order to easily distinguish local and common PCIe name spaces. All except > the pcie_port structure which contains the DW PCIe Root Port descriptor. > For historical reason the structure has retained the original name since > commit 340cba6092c2 ("pci: Add PCIe driver for Samsung Exynos") when > the DW PCIe IP-core support was added to the kernel. Let's finally fix > that by adding the dw_ prefix to the structure name and by adding the _rp > suffix to be similar to the EP counterpart. Thus the name will be coherent > with the common driver naming policy. It shall make the driver code more > readable eliminating visual confusion between the local and generic PCI > name spaces. > > Signed-off-by: Serge Semin > > --- > > Changelog v4: > - This is a new patch created on the v4 lap of the series. > --- > drivers/pci/controller/dwc/pci-dra7xx.c | 12 +++---- > drivers/pci/controller/dwc/pci-exynos.c | 6 ++-- > drivers/pci/controller/dwc/pci-imx6.c | 6 ++-- > drivers/pci/controller/dwc/pci-keystone.c | 20 +++++------ > drivers/pci/controller/dwc/pci-layerscape.c | 2 +- > drivers/pci/controller/dwc/pci-meson.c | 2 +- > drivers/pci/controller/dwc/pcie-al.c | 6 ++-- > drivers/pci/controller/dwc/pcie-armada8k.c | 4 +-- > drivers/pci/controller/dwc/pcie-artpec6.c | 4 +-- > .../pci/controller/dwc/pcie-designware-host.c | 36 +++++++++---------- > .../pci/controller/dwc/pcie-designware-plat.c | 2 +- > drivers/pci/controller/dwc/pcie-designware.h | 30 ++++++++-------- > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 4 +-- > drivers/pci/controller/dwc/pcie-fu740.c | 2 +- > drivers/pci/controller/dwc/pcie-histb.c | 10 +++--- > drivers/pci/controller/dwc/pcie-intel-gw.c | 6 ++-- > drivers/pci/controller/dwc/pcie-keembay.c | 4 +-- > drivers/pci/controller/dwc/pcie-kirin.c | 2 +- > drivers/pci/controller/dwc/pcie-qcom.c | 4 +-- > drivers/pci/controller/dwc/pcie-spear13xx.c | 6 ++-- > drivers/pci/controller/dwc/pcie-tegra194.c | 22 ++++++------ > drivers/pci/controller/dwc/pcie-uniphier.c | 10 +++--- > drivers/pci/controller/dwc/pcie-visconti.c | 6 ++-- > 23 files changed, 103 insertions(+), 103 deletions(-) Reviewed-by: Rob Herring _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7E74C43334 for ; Mon, 13 Jun 2022 20:48:36 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LMNvR0TJtz3cg7 for ; Tue, 14 Jun 2022 06:48:35 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.166.180; helo=mail-il1-f180.google.com; envelope-from=robherring2@gmail.com; receiver=) Received: from mail-il1-f180.google.com (mail-il1-f180.google.com [209.85.166.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LMNtz4y8hz2yL2 for ; Tue, 14 Jun 2022 06:48:11 +1000 (AEST) Received: by mail-il1-f180.google.com with SMTP id y17so5148002ilj.11 for ; Mon, 13 Jun 2022 13:48:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/dzRBMIn98y05EN99Sgq5WDsEwo7wpH66xTE6XCo/M4=; b=iflkaZVxmeu6wWuL2KwDrhBFclUUwlK4vq7wujuru7msUdVVULiioaa2AOWXwJ4wZ5 mNkbvIKxB04jRuPxBEJp9e+844s4NwbOiN9/bSyOJOenZuWTtRwJ6+rii4iR6i+0EnhA GHV6jB8WZoGq8cU59LX5gUBanIhz6jbieBWOolnigC75cTglejwLuD0/M5Su0ErOrIz9 iHmuWmTvTk7pYSaqB2qpwkRP04mfAFnbq3b8/aJJf9bhYoGzXDKNWbBdqECMHxAF38co hYiH0CBt3TRAaBgiOcY9vp9h13R+fax39G5LtpFyKVYZRoCSx3y6C8EMgS8YWasRq88S y7EA== X-Gm-Message-State: AJIora9KUqK415szP9S9BUyRw3rzH77Yn7Rx95e8jxQH6xu3MQu5bXSR Jf6lCG7gj8sKa+HeIiYq6A== X-Google-Smtp-Source: AGRyM1uVO/KYjaDwGOXreGf4KGdEqy/t353ouqbFZgp5s/y6kuWD2fxXl3ut4zPLn500QHJwX/rd6w== X-Received: by 2002:a92:ca45:0:b0:2d1:b7cf:26a9 with SMTP id q5-20020a92ca45000000b002d1b7cf26a9mr962751ilo.52.1655153288816; Mon, 13 Jun 2022 13:48:08 -0700 (PDT) Received: from robh.at.kernel.org ([69.39.28.171]) by smtp.gmail.com with ESMTPSA id c2-20020a92c8c2000000b002d11397f4f9sm4380280ilq.74.2022.06.13.13.48.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 13:48:08 -0700 (PDT) Received: (nullmailer pid 56167 invoked by uid 1000); Mon, 13 Jun 2022 20:48:06 -0000 Date: Mon, 13 Jun 2022 14:48:06 -0600 From: Rob Herring To: Serge Semin Subject: Re: [PATCH v4 15/18] PCI: dwc: Add dw_ prefix to the pcie_port structure name Message-ID: <20220613204806.GA55629-robh@kernel.org> References: <20220610082535.12802-1-Sergey.Semin@baikalelectronics.ru> <20220610082535.12802-16-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220610082535.12802-16-Sergey.Semin@baikalelectronics.ru> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Thomas Petazzoni , Kunihiko Hayashi , Neil Armstrong , linux-pci@vger.kernel.org, Binghui Wang , Frank Li , Bjorn Andersson , Minghuan Lian , Thierry Reding , Pavel Parkhomenko , Alim Akhtar , Jonathan Chocron , Nobuhiro Iwamatsu , Jonathan Hunter , Fabio Estevam , Jerome Brunet , Srikanth Thokala , Jesper Nilsson , Lorenzo Pieralisi , Kevin Hilman , Pratyush Anand , linux-tegra@vger.kernel.org, linux-arm-kernel@axis. com, Kishon Vijay Abraham I , linux-rockchip@lists.infradead.org, Rahul Tanwar , Andy Gross , NXP Linux Team , Xiaowei Song , Greentime Hu , Richard Zhu , linux-omap@vger.kernel.org, Martin Blumenstingl , linux-arm-msm@vger.kernel.org, Sascha Hauer , Manivannan Sadhasivam , Yue Wang , linux-samsung-soc@vger.kernel.org, Paul Walmsley , Bjorn Helgaas , linux-amlogic@lists.infradead.org, Alexey Malahov , Mingkai Hu , linux-arm-kernel@lists.infradead.org, Roy Zang , Jingoo Han , linuxppc-dev@lists.ozlabs.org, Heiko Stuebner , linux-kernel@vger.kernel.org, Serge Semin , Stanimir Varbanov , Krzysztof Kozlowski , Masami Hiramatsu , Pengutronix Kernel Team , Gustavo Pimentel , Shawn Guo , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Jun 10, 2022 at 11:25:31AM +0300, Serge Semin wrote: > All of the DW PCIe core driver entities have names with the dw_ prefix in > order to easily distinguish local and common PCIe name spaces. All except > the pcie_port structure which contains the DW PCIe Root Port descriptor. > For historical reason the structure has retained the original name since > commit 340cba6092c2 ("pci: Add PCIe driver for Samsung Exynos") when > the DW PCIe IP-core support was added to the kernel. Let's finally fix > that by adding the dw_ prefix to the structure name and by adding the _rp > suffix to be similar to the EP counterpart. Thus the name will be coherent > with the common driver naming policy. It shall make the driver code more > readable eliminating visual confusion between the local and generic PCI > name spaces. > > Signed-off-by: Serge Semin > > --- > > Changelog v4: > - This is a new patch created on the v4 lap of the series. > --- > drivers/pci/controller/dwc/pci-dra7xx.c | 12 +++---- > drivers/pci/controller/dwc/pci-exynos.c | 6 ++-- > drivers/pci/controller/dwc/pci-imx6.c | 6 ++-- > drivers/pci/controller/dwc/pci-keystone.c | 20 +++++------ > drivers/pci/controller/dwc/pci-layerscape.c | 2 +- > drivers/pci/controller/dwc/pci-meson.c | 2 +- > drivers/pci/controller/dwc/pcie-al.c | 6 ++-- > drivers/pci/controller/dwc/pcie-armada8k.c | 4 +-- > drivers/pci/controller/dwc/pcie-artpec6.c | 4 +-- > .../pci/controller/dwc/pcie-designware-host.c | 36 +++++++++---------- > .../pci/controller/dwc/pcie-designware-plat.c | 2 +- > drivers/pci/controller/dwc/pcie-designware.h | 30 ++++++++-------- > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 4 +-- > drivers/pci/controller/dwc/pcie-fu740.c | 2 +- > drivers/pci/controller/dwc/pcie-histb.c | 10 +++--- > drivers/pci/controller/dwc/pcie-intel-gw.c | 6 ++-- > drivers/pci/controller/dwc/pcie-keembay.c | 4 +-- > drivers/pci/controller/dwc/pcie-kirin.c | 2 +- > drivers/pci/controller/dwc/pcie-qcom.c | 4 +-- > drivers/pci/controller/dwc/pcie-spear13xx.c | 6 ++-- > drivers/pci/controller/dwc/pcie-tegra194.c | 22 ++++++------ > drivers/pci/controller/dwc/pcie-uniphier.c | 10 +++--- > drivers/pci/controller/dwc/pcie-visconti.c | 6 ++-- > 23 files changed, 103 insertions(+), 103 deletions(-) Reviewed-by: Rob Herring