From: Dan Carpenter <dan.carpenter@oracle.com>
To: daniel watson <ozzloy@challenge-bot.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] staging: r8188eu: remove leading '_' on _rtw_IOL_append_WB_cmd
Date: Tue, 14 Jun 2022 17:42:45 +0300 [thread overview]
Message-ID: <20220614091654.GI2146@kadam> (raw)
In-Reply-To: <a1596a62d8e63afbe6a645919a349a8402277c5f.1655171591.git.ozzloy@challenge-bot.com>
On Mon, Jun 13, 2022 at 07:07:30PM -0700, daniel watson wrote:
> From: Daniel Watson <ozzloy@challenge-bot.com>
>
> name the function rtw_IOL_append_WB_cmd and call it directly,
> instead of using wrapper macro
>
> delete wrapper macro, which is not needed
>
> NOTE: code compiles, not tested on hardware
Don't put this kind of comment in the commit message. Put it under the
--- cut off line.
>
> Signed-off-by: Daniel Watson <ozzloy@challenge-bot.com>
> ---
^^^
Here.
You don't even really need to tell us that you compiled the code,
because we take that as a given.
regards,
dan carpenter
next prev parent reply other threads:[~2022-06-14 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 2:07 [PATCH 0/4] remove wrappers on _rtw_IOL_append_*_cmd daniel watson
2022-06-14 2:07 ` [PATCH 1/4] staging: r8188eu: remove leading '_' on _rtw_IOL_append_WB_cmd daniel watson
2022-06-14 14:42 ` Dan Carpenter [this message]
2022-06-14 2:07 ` [PATCH 2/4] staging: r8188eu: remove leading '_' on _rtw_IOL_append_WW_cmd daniel watson
2022-06-14 2:07 ` [PATCH 3/4] staging: r8188eu: remove leading '_' on _rtw_IOL_append_WD_cmd daniel watson
2022-06-14 2:07 ` [PATCH 4/4] staging: r8188eu: remove leading '_' on _rtw_IOL_append_WRF_cmd daniel watson
2022-06-14 14:47 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614091654.GI2146@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=ozzloy@challenge-bot.com \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.