From: Yajun Deng <yajun.deng@linux.dev>
To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, namhyung@kernel.org, eranian@google.com
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Yajun Deng <yajun.deng@linux.dev>
Subject: [PATCH] perf/core: fix perf_event_mux_interval_ms when set zero
Date: Tue, 14 Jun 2022 18:37:51 +0800 [thread overview]
Message-ID: <20220614103751.1395645-1-yajun.deng@linux.dev> (raw)
The perf_event_mux_interval_ms is set to zero or one by default.
It can't change back when someone changes it from zero to another
value.
Make perf_event_mux_interval_ms to PERF_CPU_HRTIMER when set zero.
Fixes: 62b856397927 ("perf: Add sysfs entry to adjust multiplexing interval per PMU")
Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
---
kernel/events/core.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 61ad10862c21..73c8c7462bbf 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -10954,9 +10954,12 @@ perf_event_mux_interval_ms_store(struct device *dev,
if (ret)
return ret;
- if (timer < 1)
+ if (timer < 0)
return -EINVAL;
+ if (timer < 1)
+ timer = PERF_CPU_HRTIMER;
+
/* same value, noting to do */
if (timer == pmu->hrtimer_interval_ms)
return count;
--
2.25.1
next reply other threads:[~2022-06-14 10:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 10:37 Yajun Deng [this message]
2022-06-14 22:08 ` [PATCH] perf/core: fix perf_event_mux_interval_ms when set zero Namhyung Kim
2022-06-15 1:29 ` Yajun Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614103751.1395645-1-yajun.deng@linux.dev \
--to=yajun.deng@linux.dev \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.