All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Julia Suvorova <jusual@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
	David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag
Date: Tue, 14 Jun 2022 10:54:08 +0200	[thread overview]
Message-ID: <20220614105408.235f0f41@redhat.com> (raw)
In-Reply-To: <YqdTQYUhO/3dzJvZ@stefanha-x1.localdomain>

On Mon, 13 Jun 2022 16:09:53 +0100
Stefan Hajnoczi <stefanha@redhat.com> wrote:

> On Mon, Jun 13, 2022 at 05:01:10PM +0200, Julia Suvorova wrote:
> > On Tue, May 31, 2022 at 5:32 PM Stefan Hajnoczi <stefanha@redhat.com> wrote:  
> > >
> > > On Tue, May 31, 2022 at 04:51:47PM +0200, Julia Suvorova wrote:  
> > > > In the ACPI specification [1], the 'unarmed' bit is set when a device
> > > > cannot accept a persistent write. This means that when a memdev is
> > > > read-only, the 'unarmed' flag must be turned on. The logic is correct,
> > > > just changing the error message.
> > > >
> > > > [1] ACPI NFIT NVDIMM Region Mapping Structure "NVDIMM State Flags" Bit 3
> > > >
> > > > Signed-off-by: Julia Suvorova <jusual@redhat.com>
> > > > ---
> > > >  hw/mem/nvdimm.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)  
> > >
> > > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>  
> > 
> > It seems like Xiao is not active, whose tree should this patch go to?  

Perhaps David can add himself as maintainer (i.e. put it
under memory mantanership umbrella) and merge it 

> 
> Michael or Igor can merge it:
> 
>   $ scripts/get_maintainer.pl -f hw/mem/nvdimm.c
>   Xiao Guangrong <xiaoguangrong.eric@gmail.com> (maintainer:NVDIMM)
>   "Michael S. Tsirkin" <mst@redhat.com> (supporter:ACPI/SMBIOS)
>   Igor Mammedov <imammedo@redhat.com> (supporter:ACPI/SMBIOS)
>   Ani Sinha <ani@anisinha.ca> (reviewer:ACPI/SMBIOS)
>   qemu-devel@nongnu.org (open list:All patches CC here)
> 
> Stefan



  reply	other threads:[~2022-06-14  9:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-31 14:51 [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag Julia Suvorova
2022-05-31 15:32 ` Stefan Hajnoczi
2022-06-13 15:01   ` Julia Suvorova
2022-06-13 15:09     ` Stefan Hajnoczi
2022-06-14  8:54       ` Igor Mammedov [this message]
2022-06-14  9:50         ` David Hildenbrand
2022-06-14 12:13           ` Julia Suvorova
2022-06-15  8:24             ` David Hildenbrand
2022-06-15 11:17               ` Xiao Guangrong
2022-06-15 11:49                 ` David Hildenbrand
2022-06-17 12:03                   ` Xiao Guangrong
2022-06-14 14:08           ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220614105408.235f0f41@redhat.com \
    --to=imammedo@redhat.com \
    --cc=david@redhat.com \
    --cc=jusual@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=xiaoguangrong.eric@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.