From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 550C8C43334 for ; Tue, 14 Jun 2022 09:19:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4ufvqFi1JN7IC6RtoN7bMa+iLxRok+/R+wtULmoyJFI=; b=X9NoZ1+oG2q2sA Ng3AXmYU1Y0hzoQA7HcYeWWG0vSUKduLy78m0Qi4E/qJFoaJhyElxAL+g8dQ3Klw1VcPXZwgZF21K 3LpG2bIgbnShq6isiNx04FpVhfk1+1qaKJqQCJJzq/Iek3/RUd5dIoamEHiOL1tGaZy8q63xl9VMe /Kx5RalSNx0oKjdcg4nk5oOENI+ifdCHIxi7cIA4LHTtQ3prT9M8XpupYnJpAzV9rOlJuka1IyMha 7/6xAt2AeQo1XtiayOMf6ErScgv9rxnzrXTce0zN8aks6K0tsAFoHSLm/dtku5G73hjowX04qhGWs e+6s+C8F81kxIKlj4Lew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o12gx-008e6S-DP; Tue, 14 Jun 2022 09:18:31 +0000 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o12Rb-008VmV-FC; Tue, 14 Jun 2022 09:02:42 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id C03BCE001B; Tue, 14 Jun 2022 09:02:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1655197355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0VkpGiXPoXaWOWQvypa0vCIM+uO/ijHmOl4KXjKbX0k=; b=ZYsOgvJ4SheAj9johdMIEhkWhCZFkH3Rp+m6pvTevjhTrUmiZ/5WPeF0H+1A91/xUTGqIl 06rgGRGplqFKBI9bxayGayLsIE4YQ8468mhQ6tDsD94gcKo2kppaa8wqQH8hqgK96AGfAi 72esq1VG+/pvs2iYl2IsqWmTeh9UDHAPLO7ItL7Rr6BuyNeIq8D2wsbxCQldaHDkUzbVdU TMtI2jTGzKy8vmG7FVh+ONC3wMto4Qi0dcIHP7NKfuGgwoRMWIyaqAZ0Ee+rrV2ltoSUmB sIL3iI7WgyJ81OI/RWvsKU00LdLmV19EHAq3R01/xFLk1gmxcXMU5UdMsd9Phg== Date: Tue, 14 Jun 2022 11:02:30 +0200 From: Miquel Raynal To: Sascha Hauer Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Srinivas Kandagatla , Richard Weinberger , Vignesh Raghavendra , Tom Rini , Ahmad Fatoum , linux-arm-kernel@lists.infradead.org, u-boot@lists.denx.de, devicetree@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH V3 2/2] nvmem: add driver handling U-Boot environment variables Message-ID: <20220614110230.46fab506@xps-13> In-Reply-To: <20220614074657.GQ2387@pengutronix.de> References: <20220611204651.19947-1-zajec5@gmail.com> <20220611204651.19947-2-zajec5@gmail.com> <20220614074657.GQ2387@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_020239_688039_BC0B7D6B X-CRM114-Status: GOOD ( 13.48 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGVsbG8sCgo+ID4gK3N0YXRpYyBpbnQgdV9ib290X2Vudl9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1f ZGV2aWNlICpwZGV2KQo+ID4gK3sKPiA+ICsJc3RydWN0IG52bWVtX2NvbmZpZyBjb25maWcgPSB7 Cj4gPiArCQkubmFtZSA9ICJ1LWJvb3QtZW52IiwKPiA+ICsJCS5yZWdfcmVhZCA9IHVfYm9vdF9l bnZfcmVhZCwKPiA+ICsJfTsKPiA+ICsJc3RydWN0IGRldmljZSAqZGV2ID0gJnBkZXYtPmRldjsK PiA+ICsJc3RydWN0IGRldmljZV9ub2RlICpucCA9IGRldi0+b2Zfbm9kZTsKPiA+ICsJY29uc3Qg c3RydWN0IG9mX2RldmljZV9pZCAqb2ZfaWQ7Cj4gPiArCXN0cnVjdCB1X2Jvb3RfZW52ICpwcml2 Owo+ID4gKwlpbnQgZXJyOwo+ID4gKwo+ID4gKwlwcml2ID0gZGV2bV9remFsbG9jKGRldiwgc2l6 ZW9mKCpwcml2KSwgR0ZQX0tFUk5FTCk7Cj4gPiArCWlmICghcHJpdikKPiA+ICsJCXJldHVybiAt RU5PTUVNOwo+ID4gKwlwcml2LT5kZXYgPSBkZXY7Cj4gPiArCj4gPiArCW9mX2lkID0gb2ZfbWF0 Y2hfZGV2aWNlKHVfYm9vdF9lbnZfb2ZfbWF0Y2hfdGFibGUsIGRldik7Cj4gPiArCWlmICghb2Zf aWQpCj4gPiArCQlyZXR1cm4gLUVJTlZBTDsKPiA+ICsJcHJpdi0+Zm9ybWF0ID0gKHVpbnRwdHJf dClvZl9pZC0+ZGF0YTsKPiA+ICsKPiA+ICsJaWYgKG9mX3Byb3BlcnR5X3JlYWRfdTMyKG5wLCAi cmVnIiwgKHUzMiAqKSZwcml2LT5vZmZzZXQpIHx8Cj4gPiArCSAgICBvZl9wcm9wZXJ0eV9yZWFk X3UzMl9pbmRleChucCwgInJlZyIsIDEsICh1MzIgKikmcHJpdi0+c2l6ZSkpIHsKPiA+ICsJCWRl dl9lcnIoZGV2LCAiRmFpbGVkIHRvIHJlYWQgXCJyZWdcIiBwcm9wZXJ0eVxuIik7Cj4gPiArCQly ZXR1cm4gLUVJTlZBTDsKPiA+ICsJfQo+ID4gKwo+ID4gKwlwcml2LT5tdGQgPSBvZl9nZXRfbXRk X2RldmljZV9ieV9ub2RlKG5wLT5wYXJlbnQpOwo+ID4gKwlpZiAoSVNfRVJSKHByaXYtPm10ZCkp IHsKPiA+ICsJCWRldl9lcnIoZGV2LCAiRmFpbGVkIHRvIGdldCAlcE9GIE1URDogJWxkXG4iLCBu cC0+cGFyZW50LCBQVFJfRVJSKHByaXYtPm10ZCkpOwo+ID4gKwkJcmV0dXJuIFBUUl9FUlIocHJp di0+bXRkKTsKPiA+ICsJfSAgCj4gCj4gUGFydGl0aW9ucyBhcmUgbXRkIGRldmljZXMgdGhlbXNl bHZlcyBhbmQgdGhlIG10ZCBsYXllciBkaXJlY3RseQo+IGFzc29jaWF0ZXMgdGhlc2UgZGV2aWNl cyB0byB0aGVpciBPRiBub2RlLCBzbyBpdCBzaG91bGQgYmUgcG9zc2libGUKPiB0byBkbyBhIG9m X2dldF9tdGRfZGV2aWNlX2J5X25vZGUobnApIHdoaWNoIGdldHMgeW91IHRoZSBwYXJ0aXRpb24u Cj4gWW91IGNhbiB1c2UgdGhlIHdob2xlIG10ZCBkZXZpY2UgdGhlbiBhbmQgZG8gbm90IGhhdmUg dG8gZmlkZGxlIHdpdGgKPiByZWcgcHJvcGVydGllcywgb2Zmc2V0cyBhbmQgc2l6ZXMgaW4geW91 ciBkcml2ZXIgeW91cnNlbGYuCgpKdXN0IGZvciB0aGUgcmVjb3JkLCB0aGVyZSB3aWxsIGJlIG9u ZSBtdGQgZGV2aWNlIHBlciBwYXJ0aXRpb24sIGJ1dAp0aGUgImZ1bGwiIG10ZCBkZXZpY2Ugd2ls bCBvbmx5IGV4aXN0IGlmIHRoZSBjb25maWd1cmF0aW9uIGNvbnRhaW5zCkNPTkZJR19NVERfUEFS VElUSU9ORURfTUFTVEVSLgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFp bGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 455B2C433EF for ; Tue, 14 Jun 2022 09:19:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MrR+dqcUiGuBqspPukdIEsCec+hXof+KinWX1IEs73Y=; b=VcASKytkNyiQn9 uIkV684BJy4dKKjbEklyH9YrLPNhGExKD3WCx0pmxMbrEW1Yp7EHcCqEISoCO3chu/FGuArrAqN+9 7auuhGDpMpUgWkmcv+p/uE1fhJdXFY6251pjccpTy1gYbVf5pEvgmRSwQ4FhEy8bBbYG0+DFunyIK pEMHdasuN0z25/hzS7HsUUcJ5P0y1cCSJeCr8+FnUVqR8IQfZB/K3ZwRnZWEkxFIHYO/QW5n6f63e j0h16PaDKSTfYr0iPXTg04ZnFVUmkITTjPqbOX7jmHxfljhMS2GiqB0BifdV+37CSJsmGgHQUxM/6 7FjiNxpyRQCD7ZhbV10g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o12gI-008dkw-5g; Tue, 14 Jun 2022 09:17:50 +0000 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o12Rb-008VmV-FC; Tue, 14 Jun 2022 09:02:42 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id C03BCE001B; Tue, 14 Jun 2022 09:02:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1655197355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0VkpGiXPoXaWOWQvypa0vCIM+uO/ijHmOl4KXjKbX0k=; b=ZYsOgvJ4SheAj9johdMIEhkWhCZFkH3Rp+m6pvTevjhTrUmiZ/5WPeF0H+1A91/xUTGqIl 06rgGRGplqFKBI9bxayGayLsIE4YQ8468mhQ6tDsD94gcKo2kppaa8wqQH8hqgK96AGfAi 72esq1VG+/pvs2iYl2IsqWmTeh9UDHAPLO7ItL7Rr6BuyNeIq8D2wsbxCQldaHDkUzbVdU TMtI2jTGzKy8vmG7FVh+ONC3wMto4Qi0dcIHP7NKfuGgwoRMWIyaqAZ0Ee+rrV2ltoSUmB sIL3iI7WgyJ81OI/RWvsKU00LdLmV19EHAq3R01/xFLk1gmxcXMU5UdMsd9Phg== Date: Tue, 14 Jun 2022 11:02:30 +0200 From: Miquel Raynal To: Sascha Hauer Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Srinivas Kandagatla , Richard Weinberger , Vignesh Raghavendra , Tom Rini , Ahmad Fatoum , linux-arm-kernel@lists.infradead.org, u-boot@lists.denx.de, devicetree@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH V3 2/2] nvmem: add driver handling U-Boot environment variables Message-ID: <20220614110230.46fab506@xps-13> In-Reply-To: <20220614074657.GQ2387@pengutronix.de> References: <20220611204651.19947-1-zajec5@gmail.com> <20220611204651.19947-2-zajec5@gmail.com> <20220614074657.GQ2387@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_020239_688039_BC0B7D6B X-CRM114-Status: GOOD ( 13.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8sCgo+ID4gK3N0YXRpYyBpbnQgdV9ib290X2Vudl9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1f ZGV2aWNlICpwZGV2KQo+ID4gK3sKPiA+ICsJc3RydWN0IG52bWVtX2NvbmZpZyBjb25maWcgPSB7 Cj4gPiArCQkubmFtZSA9ICJ1LWJvb3QtZW52IiwKPiA+ICsJCS5yZWdfcmVhZCA9IHVfYm9vdF9l bnZfcmVhZCwKPiA+ICsJfTsKPiA+ICsJc3RydWN0IGRldmljZSAqZGV2ID0gJnBkZXYtPmRldjsK PiA+ICsJc3RydWN0IGRldmljZV9ub2RlICpucCA9IGRldi0+b2Zfbm9kZTsKPiA+ICsJY29uc3Qg c3RydWN0IG9mX2RldmljZV9pZCAqb2ZfaWQ7Cj4gPiArCXN0cnVjdCB1X2Jvb3RfZW52ICpwcml2 Owo+ID4gKwlpbnQgZXJyOwo+ID4gKwo+ID4gKwlwcml2ID0gZGV2bV9remFsbG9jKGRldiwgc2l6 ZW9mKCpwcml2KSwgR0ZQX0tFUk5FTCk7Cj4gPiArCWlmICghcHJpdikKPiA+ICsJCXJldHVybiAt RU5PTUVNOwo+ID4gKwlwcml2LT5kZXYgPSBkZXY7Cj4gPiArCj4gPiArCW9mX2lkID0gb2ZfbWF0 Y2hfZGV2aWNlKHVfYm9vdF9lbnZfb2ZfbWF0Y2hfdGFibGUsIGRldik7Cj4gPiArCWlmICghb2Zf aWQpCj4gPiArCQlyZXR1cm4gLUVJTlZBTDsKPiA+ICsJcHJpdi0+Zm9ybWF0ID0gKHVpbnRwdHJf dClvZl9pZC0+ZGF0YTsKPiA+ICsKPiA+ICsJaWYgKG9mX3Byb3BlcnR5X3JlYWRfdTMyKG5wLCAi cmVnIiwgKHUzMiAqKSZwcml2LT5vZmZzZXQpIHx8Cj4gPiArCSAgICBvZl9wcm9wZXJ0eV9yZWFk X3UzMl9pbmRleChucCwgInJlZyIsIDEsICh1MzIgKikmcHJpdi0+c2l6ZSkpIHsKPiA+ICsJCWRl dl9lcnIoZGV2LCAiRmFpbGVkIHRvIHJlYWQgXCJyZWdcIiBwcm9wZXJ0eVxuIik7Cj4gPiArCQly ZXR1cm4gLUVJTlZBTDsKPiA+ICsJfQo+ID4gKwo+ID4gKwlwcml2LT5tdGQgPSBvZl9nZXRfbXRk X2RldmljZV9ieV9ub2RlKG5wLT5wYXJlbnQpOwo+ID4gKwlpZiAoSVNfRVJSKHByaXYtPm10ZCkp IHsKPiA+ICsJCWRldl9lcnIoZGV2LCAiRmFpbGVkIHRvIGdldCAlcE9GIE1URDogJWxkXG4iLCBu cC0+cGFyZW50LCBQVFJfRVJSKHByaXYtPm10ZCkpOwo+ID4gKwkJcmV0dXJuIFBUUl9FUlIocHJp di0+bXRkKTsKPiA+ICsJfSAgCj4gCj4gUGFydGl0aW9ucyBhcmUgbXRkIGRldmljZXMgdGhlbXNl bHZlcyBhbmQgdGhlIG10ZCBsYXllciBkaXJlY3RseQo+IGFzc29jaWF0ZXMgdGhlc2UgZGV2aWNl cyB0byB0aGVpciBPRiBub2RlLCBzbyBpdCBzaG91bGQgYmUgcG9zc2libGUKPiB0byBkbyBhIG9m X2dldF9tdGRfZGV2aWNlX2J5X25vZGUobnApIHdoaWNoIGdldHMgeW91IHRoZSBwYXJ0aXRpb24u Cj4gWW91IGNhbiB1c2UgdGhlIHdob2xlIG10ZCBkZXZpY2UgdGhlbiBhbmQgZG8gbm90IGhhdmUg dG8gZmlkZGxlIHdpdGgKPiByZWcgcHJvcGVydGllcywgb2Zmc2V0cyBhbmQgc2l6ZXMgaW4geW91 ciBkcml2ZXIgeW91cnNlbGYuCgpKdXN0IGZvciB0aGUgcmVjb3JkLCB0aGVyZSB3aWxsIGJlIG9u ZSBtdGQgZGV2aWNlIHBlciBwYXJ0aXRpb24sIGJ1dAp0aGUgImZ1bGwiIG10ZCBkZXZpY2Ugd2ls bCBvbmx5IGV4aXN0IGlmIHRoZSBjb25maWd1cmF0aW9uIGNvbnRhaW5zCkNPTkZJR19NVERfUEFS VElUSU9ORURfTUFTVEVSLgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76D0FCCA47A for ; Tue, 14 Jun 2022 09:02:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242587AbiFNJCq (ORCPT ); Tue, 14 Jun 2022 05:02:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242692AbiFNJCk (ORCPT ); Tue, 14 Jun 2022 05:02:40 -0400 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E9BA2717F; Tue, 14 Jun 2022 02:02:36 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id C03BCE001B; Tue, 14 Jun 2022 09:02:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1655197355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0VkpGiXPoXaWOWQvypa0vCIM+uO/ijHmOl4KXjKbX0k=; b=ZYsOgvJ4SheAj9johdMIEhkWhCZFkH3Rp+m6pvTevjhTrUmiZ/5WPeF0H+1A91/xUTGqIl 06rgGRGplqFKBI9bxayGayLsIE4YQ8468mhQ6tDsD94gcKo2kppaa8wqQH8hqgK96AGfAi 72esq1VG+/pvs2iYl2IsqWmTeh9UDHAPLO7ItL7Rr6BuyNeIq8D2wsbxCQldaHDkUzbVdU TMtI2jTGzKy8vmG7FVh+ONC3wMto4Qi0dcIHP7NKfuGgwoRMWIyaqAZ0Ee+rrV2ltoSUmB sIL3iI7WgyJ81OI/RWvsKU00LdLmV19EHAq3R01/xFLk1gmxcXMU5UdMsd9Phg== Date: Tue, 14 Jun 2022 11:02:30 +0200 From: Miquel Raynal To: Sascha Hauer Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Srinivas Kandagatla , Richard Weinberger , Vignesh Raghavendra , Tom Rini , Ahmad Fatoum , linux-arm-kernel@lists.infradead.org, u-boot@lists.denx.de, devicetree@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH V3 2/2] nvmem: add driver handling U-Boot environment variables Message-ID: <20220614110230.46fab506@xps-13> In-Reply-To: <20220614074657.GQ2387@pengutronix.de> References: <20220611204651.19947-1-zajec5@gmail.com> <20220611204651.19947-2-zajec5@gmail.com> <20220614074657.GQ2387@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello, > > +static int u_boot_env_probe(struct platform_device *pdev) > > +{ > > + struct nvmem_config config =3D { > > + .name =3D "u-boot-env", > > + .reg_read =3D u_boot_env_read, > > + }; > > + struct device *dev =3D &pdev->dev; > > + struct device_node *np =3D dev->of_node; > > + const struct of_device_id *of_id; > > + struct u_boot_env *priv; > > + int err; > > + > > + priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > > + if (!priv) > > + return -ENOMEM; > > + priv->dev =3D dev; > > + > > + of_id =3D of_match_device(u_boot_env_of_match_table, dev); > > + if (!of_id) > > + return -EINVAL; > > + priv->format =3D (uintptr_t)of_id->data; > > + > > + if (of_property_read_u32(np, "reg", (u32 *)&priv->offset) || > > + of_property_read_u32_index(np, "reg", 1, (u32 *)&priv->size)) { > > + dev_err(dev, "Failed to read \"reg\" property\n"); > > + return -EINVAL; > > + } > > + > > + priv->mtd =3D of_get_mtd_device_by_node(np->parent); > > + if (IS_ERR(priv->mtd)) { > > + dev_err(dev, "Failed to get %pOF MTD: %ld\n", np->parent, PTR_ERR(pr= iv->mtd)); > > + return PTR_ERR(priv->mtd); > > + } =20 >=20 > Partitions are mtd devices themselves and the mtd layer directly > associates these devices to their OF node, so it should be possible > to do a of_get_mtd_device_by_node(np) which gets you the partition. > You can use the whole mtd device then and do not have to fiddle with > reg properties, offsets and sizes in your driver yourself. Just for the record, there will be one mtd device per partition, but the "full" mtd device will only exist if the configuration contains CONFIG_MTD_PARTITIONED_MASTER. Thanks, Miqu=C3=A8l