From: wuchi <wuchi.zero@gmail.com>
To: alexios.zavras@intel.com, allison@lohutok.net, armijn@tjaldur.nl
Cc: akpm@linux-foundation.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] lib/klist: Remove mb() before wake_up_process
Date: Tue, 14 Jun 2022 22:44:43 +0800 [thread overview]
Message-ID: <20220614144443.6566-1-wuchi.zero@gmail.com> (raw)
Function wake_up_process always executes a general memory barrier,
so remove the mb() before it.
Signed-off-by: wuchi <wuchi.zero@gmail.com>
---
lib/klist.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/klist.c b/lib/klist.c
index 332a4fbf18ff..c44498e31d91 100644
--- a/lib/klist.c
+++ b/lib/klist.c
@@ -194,7 +194,6 @@ static void klist_release(struct kref *kref)
list_del(&waiter->list);
waiter->woken = 1;
- mb();
wake_up_process(waiter->process);
}
spin_unlock(&klist_remove_lock);
--
2.20.1
next reply other threads:[~2022-06-14 14:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 14:44 wuchi [this message]
2022-06-14 14:58 ` [PATCH] lib/klist: Remove mb() before wake_up_process Greg KH
2022-06-15 3:30 ` chi wu
2022-06-15 6:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614144443.6566-1-wuchi.zero@gmail.com \
--to=wuchi.zero@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexios.zavras@intel.com \
--cc=allison@lohutok.net \
--cc=armijn@tjaldur.nl \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.