From: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
To: thuth@redhat.com, borntraeger@linux.ibm.com,
frankja@linux.ibm.com, imbrenda@linux.ibm.com,
pbonzini@redhat.com
Cc: david@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-s390@vger.kernel.org, scgl@linux.ibm.com, shuah@kernel.org
Subject: [PATCH] KVM: s390: selftests: Fix memop extension capability check
Date: Tue, 14 Jun 2022 18:26:35 +0200 [thread overview]
Message-ID: <20220614162635.3445019-1-scgl@linux.ibm.com> (raw)
In-Reply-To: <36d83871-343d-e8a0-1aed-05bf386f9b1b@redhat.com>
Fix the inverted logic of the memop extension capability check.
Fixes: 97da92c0ff92 ("KVM: s390: selftests: Use TAP interface in the memop test")
Signed-off-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
---
Here you go.
Hope it doesn't get lost as a reply, but I can always resend
and it's not super critical after all.
tools/testing/selftests/kvm/s390x/memop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/kvm/s390x/memop.c b/tools/testing/selftests/kvm/s390x/memop.c
index e704c6fa5758..e1056f20dfa1 100644
--- a/tools/testing/selftests/kvm/s390x/memop.c
+++ b/tools/testing/selftests/kvm/s390x/memop.c
@@ -769,7 +769,7 @@ int main(int argc, char *argv[])
ksft_set_plan(ARRAY_SIZE(testlist));
for (idx = 0; idx < ARRAY_SIZE(testlist); idx++) {
- if (testlist[idx].extension >= extension_cap) {
+ if (extension_cap >= testlist[idx].extension) {
testlist[idx].test();
ksft_test_result_pass("%s\n", testlist[idx].name);
} else {
--
2.32.0
next prev parent reply other threads:[~2022-06-14 16:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 10:15 [PATCH v4 0/4] KVM: s390: selftests: Provide TAP output in tests Thomas Huth
2022-05-31 10:15 ` [PATCH v4 1/4] KVM: s390: selftests: Use TAP interface in the memop test Thomas Huth
2022-06-14 10:38 ` Janis Schoetterl-Glausch
2022-06-14 14:24 ` Thomas Huth
2022-06-14 16:26 ` Janis Schoetterl-Glausch [this message]
2022-06-14 16:31 ` [PATCH] KVM: s390: selftests: Fix memop extension capability check Thomas Huth
2022-06-14 17:09 ` Paolo Bonzini
2022-05-31 10:15 ` [PATCH v4 2/4] KVM: s390: selftests: Use TAP interface in the sync_regs test Thomas Huth
2022-05-31 10:15 ` [PATCH v4 3/4] KVM: s390: selftests: Use TAP interface in the tprot test Thomas Huth
2022-05-31 10:15 ` [PATCH v4 4/4] KVM: s390: selftests: Use TAP interface in the reset test Thomas Huth
2022-05-31 11:29 ` [PATCH v4 0/4] KVM: s390: selftests: Provide TAP output in tests Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614162635.3445019-1-scgl@linux.ibm.com \
--to=scgl@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=shuah@kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.